{"id":819403,"url":"http://patchwork.ozlabs.org/api/patches/819403/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170928044132.30940-8-saeedm@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170928044132.30940-8-saeedm@mellanox.com>","list_archive_url":null,"date":"2017-09-28T04:41:28","name":"[net,07/11] net/mlx5e: Print netdev features correctly in error message","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"25caa7a05b716b4c312318d1c6f5486bbced4adc","submitter":{"id":65299,"url":"http://patchwork.ozlabs.org/api/people/65299/?format=json","name":"Saeed Mahameed","email":"saeedm@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170928044132.30940-8-saeedm@mellanox.com/mbox/","series":[{"id":5488,"url":"http://patchwork.ozlabs.org/api/series/5488/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=5488","date":"2017-09-28T04:41:23","name":"Mellanox, mlx5 fixes 2017-09-28","version":1,"mbox":"http://patchwork.ozlabs.org/series/5488/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819403/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819403/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2hqv19blz9t3x\n\tfor ;\n\tThu, 28 Sep 2017 14:42:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751895AbdI1EmH (ORCPT );\n\tThu, 28 Sep 2017 00:42:07 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:54396 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751587AbdI1EmG (ORCPT\n\t); Thu, 28 Sep 2017 00:42:06 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 28 Sep 2017 06:42:01 +0200","from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v8S4g1jB011096;\n\tThu, 28 Sep 2017 07:42:01 +0300"],"From":"Saeed Mahameed ","To":"\"David S. Miller\" ","Cc":"netdev@vger.kernel.org, Gal Pressman ,\n\tSaeed Mahameed ","Subject":"[net 07/11] net/mlx5e: Print netdev features correctly in error\n\tmessage","Date":"Thu, 28 Sep 2017 07:41:28 +0300","Message-Id":"<20170928044132.30940-8-saeedm@mellanox.com>","X-Mailer":"git-send-email 2.13.0","In-Reply-To":"<20170928044132.30940-1-saeedm@mellanox.com>","References":"<20170928044132.30940-1-saeedm@mellanox.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Gal Pressman \n\nUse the correct formatting for netdev features.\n\nFixes: 0e405443e803 (\"net/mlx5e: Improve set features ndo resiliency\")\nSigned-off-by: Gal Pressman \nSigned-off-by: Saeed Mahameed \n---\n drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\nindex dfc29720ab77..84b013dc62e9 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n@@ -3333,8 +3333,8 @@ static int mlx5e_handle_feature(struct net_device *netdev,\n \n \terr = feature_handler(netdev, enable);\n \tif (err) {\n-\t\tnetdev_err(netdev, \"%s feature 0x%llx failed err %d\\n\",\n-\t\t\t enable ? \"Enable\" : \"Disable\", feature, err);\n+\t\tnetdev_err(netdev, \"%s feature %pNF failed, err %d\\n\",\n+\t\t\t enable ? \"Enable\" : \"Disable\", &feature, err);\n \t\treturn err;\n \t}\n \n","prefixes":["net","07/11"]}