{"id":819365,"url":"http://patchwork.ozlabs.org/api/patches/819365/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170928005756.3938-2-kalyan.kinthada@alliedtelesis.co.nz/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170928005756.3938-2-kalyan.kinthada@alliedtelesis.co.nz>","list_archive_url":null,"date":"2017-09-28T00:57:56","name":"[v3,1/1] mtd: nand: pxa3xx: Set FORCE_CSX bit to ARMADA370 variants.","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"5570638bfd12fcdc5511d8d75f6269c916c88c4d","submitter":{"id":72417,"url":"http://patchwork.ozlabs.org/api/people/72417/?format=json","name":"Kalyan Kinthada","email":"kalyan.kinthada@alliedtelesis.co.nz"},"delegate":{"id":58324,"url":"http://patchwork.ozlabs.org/api/users/58324/?format=json","username":"bbrezillon","first_name":"Boris","last_name":"Brezillon","email":"boris.brezillon@free-electrons.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170928005756.3938-2-kalyan.kinthada@alliedtelesis.co.nz/mbox/","series":[{"id":5468,"url":"http://patchwork.ozlabs.org/api/series/5468/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=5468","date":"2017-09-28T00:57:56","name":"Set FORCE_CSX bit when arbitration between NAND and NOR is enabled.","version":3,"mbox":"http://patchwork.ozlabs.org/series/5468/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819365/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819365/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"TVFS4xK2\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=alliedtelesis.co.nz\n\theader.i=@alliedtelesis.co.nz header.b=\"onk1KogQ\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2btT37Slz9t5C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 10:59:13 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxNAJ-0001VC-M5; Thu, 28 Sep 2017 00:58:59 +0000","from gate2.alliedtelesis.co.nz ([202.36.163.20])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxN9t-0001TT-9i\n\tfor linux-mtd@lists.infradead.org; Thu, 28 Sep 2017 00:58:35 +0000","from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (Client did not present a certificate)\n\tby gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id B094E8365D;\n\tThu, 28 Sep 2017 13:58:00 +1300 (NZDT)","from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with\n\tTrustwave SEG (v7, 5, 8, 10121)\n\tid <B59cc49160001>; Thu, 28 Sep 2017 13:58:00 +1300","from kalyank-dl.ws.atlnz.lc (kalyank-dl.ws.atlnz.lc [10.33.14.14])\n\tby smtp (Postfix) with ESMTP id C995A13EECE;\n\tThu, 28 Sep 2017 13:58:09 +1300 (NZDT)","by kalyank-dl.ws.atlnz.lc (Postfix, from userid 1628)\n\tid 4BB98C0490; Thu, 28 Sep 2017 13:57:58 +1300 (NZDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=/EMapQxOUat6QwGBfm69QvHktp5BkHW1wigN+kwtBkg=;\n\tb=TVFS4xK2GGZOD4UlRKS9nBabvJ\n\tpKpIMbdwA7szim0HMWEK/5iY7lQleblOa3uZ8unw1kcvxlcKnOds3E7ANfCzeVpAUvgdJms+uHGbI\n\tDo5f/O9QnIkU5iTrh4KkYTI1VyN9Bue2YRDJEPPd/lGSESkScvsWHwpPYwJWIe+hYtJagd4l4vNT5\n\ttarM5IsMqi7r5i/ZNUw7yEHMroKJk66sFE6xxapkOmdji9AN562soAUWkzFNNbnLAOs/XQRrzyY3H\n\tfYmo2iy5uerMhcZq5LKUjwqONvrFlZrfPn3DhA/9Du0+dPgUqC9tO2hZlI50++qTs3jZpHRk/SeDT\n\twNknF0+Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; \n\ts=mail; t=1506560280;\n\tbh=uoU36mLrULuA412DGl8WcaR2l6/mS00FA9dgb3gmueo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=onk1KogQCVlJ75kZ+oRvzArOLVvG06a0XU0lO7oias3gTrmN/WYB1S7JbJSQZYgvt\n\tC3FUEwBRQWU2TkX5AhLhyuEfyrd3lUKsECQm+vyGxDzav/guKpDQ11BA8FTk6TMuWe\n\tJ7dG4OrcLi59jWmZDWpcMIQAjMc5hWdkY32eQqGk="],"From":"Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>","To":"dwmw2@infradead.org, computersforpeace@gmail.com,\n\tboris.brezillon@free-electrons.com, marek.vasut@gmail.com,\n\trichard@nod.at, \n\tcyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, \n\tezequiel.garcia@free-electrons.com, miquel.raynal@free-electrons.com, \n\tdevicetree@vger.kernel.org","Subject":"[PATCH v3 1/1] mtd: nand: pxa3xx: Set FORCE_CSX bit to ARMADA370\n\tvariants.","Date":"Thu, 28 Sep 2017 13:57:56 +1300","Message-Id":"<20170928005756.3938-2-kalyan.kinthada@alliedtelesis.co.nz>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170928005756.3938-1-kalyan.kinthada@alliedtelesis.co.nz>","References":"<20170928005756.3938-1-kalyan.kinthada@alliedtelesis.co.nz>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_175833_714091_9D3ADA40 ","X-CRM114-Status":"GOOD (  11.65  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_HELO_PASS          SPF: HELO matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-mtd/>","List-Post":"<mailto:linux-mtd@lists.infradead.org>","List-Help":"<mailto:linux-mtd-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>","Cc":"Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>,\n\tchris.packham@alliedtelesis.co.nz, linux-mtd@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"When the arbitration between NOR and NAND flash is enabled\nthe <FORCE_CSX> field bit[21] in the Data Flash Control Register\nneeds to be set to 1 according to guidleine GL-5830741 mentioned\nin Marvell Errata document MV-S501377-00, Rev. D.\n\nThis commit sets the FORCE_CSX bit to 1 for all\nARMADA370 variants as the arbitration is always enabled by default.\nThis change does not apply for pxa3xx variants because the FORCE_CSX\nbit does not exist/reserved on the NFCv1.\n\nThe NDCR_ND_MODE conflicts with the new NDCR_FORCE_CSX but is unused so\nremove it along with NDCR_NAND_MODE.\n\nSigned-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>\n---\n drivers/mtd/nand/pxa3xx_nand.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c\nindex 85cff68643e0..a6a7a5af7bed 100644\n--- a/drivers/mtd/nand/pxa3xx_nand.c\n+++ b/drivers/mtd/nand/pxa3xx_nand.c\n@@ -67,8 +67,7 @@\n #define NDCR_DWIDTH_M\t\t(0x1 << 26)\n #define NDCR_PAGE_SZ\t\t(0x1 << 24)\n #define NDCR_NCSX\t\t(0x1 << 23)\n-#define NDCR_ND_MODE\t\t(0x3 << 21)\n-#define NDCR_NAND_MODE   \t(0x0)\n+#define NDCR_FORCE_CSX\t\t(0x1 << 21)\n #define NDCR_CLR_PG_CNT\t\t(0x1 << 20)\n #define NFCV1_NDCR_ARB_CNTL\t(0x1 << 19)\n #define NFCV2_NDCR_STOP_ON_UNCOR\t(0x1 << 19)\n@@ -1464,6 +1463,9 @@ static int pxa3xx_nand_config_ident(struct pxa3xx_nand_info *info)\n \tinfo->chunk_size = PAGE_CHUNK_SIZE;\n \tinfo->reg_ndcr = 0x0; /* enable all interrupts */\n \tinfo->reg_ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0;\n+\t/* Set FORCE_CSX bit for all ARMADA370 Variants. Ref#: GL-5830741 */\n+\tif (info->variant == PXA3XX_NAND_VARIANT_ARMADA370)\n+\t\tinfo->reg_ndcr |= NDCR_FORCE_CSX;\n \tinfo->reg_ndcr |= NDCR_RD_ID_CNT(READ_ID_BYTES);\n \tinfo->reg_ndcr |= NDCR_SPARE_EN;\n \n@@ -1498,6 +1500,9 @@ static void pxa3xx_nand_detect_config(struct pxa3xx_nand_info *info)\n \tinfo->reg_ndcr = ndcr &\n \t\t~(NDCR_INT_MASK | NDCR_ND_ARB_EN | NFCV1_NDCR_ARB_CNTL);\n \tinfo->reg_ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0;\n+\t/* Set FORCE_CSX bit for all ARMADA370 Variants. Ref#: GL-5830741 */\n+\tif (info->variant == PXA3XX_NAND_VARIANT_ARMADA370)\n+\t\tinfo->reg_ndcr |= NDCR_FORCE_CSX;\n \tinfo->ndtr0cs0 = nand_readl(info, NDTR0CS0);\n \tinfo->ndtr1cs0 = nand_readl(info, NDTR1CS0);\n }\n","prefixes":["v3","1/1"]}