{"id":819355,"url":"http://patchwork.ozlabs.org/api/patches/819355/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-4-samuel.thibault@ens-lyon.org/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927231742.9050-4-samuel.thibault@ens-lyon.org>","list_archive_url":null,"date":"2017-09-27T23:17:41","name":"[hurd,commited,3/4] hurd: Fix `seekdir' symbol exposition from `rewinddir'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ed60044589852dd6011b6dc429f7aa3f05c20a8","submitter":{"id":418,"url":"http://patchwork.ozlabs.org/api/people/418/?format=json","name":"Samuel Thibault","email":"samuel.thibault@ens-lyon.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-4-samuel.thibault@ens-lyon.org/mbox/","series":[{"id":5459,"url":"http://patchwork.ozlabs.org/api/series/5459/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=5459","date":"2017-09-27T23:17:38","name":"Fixing symbol exposition.s","version":1,"mbox":"http://patchwork.ozlabs.org/series/5459/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819355/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819355/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85052-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Y69jOZHa\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Yq50FHDz9sRm\n\tfor ;\n\tThu, 28 Sep 2017 09:26:08 +1000 (AEST)","(qmail 104188 invoked by alias); 27 Sep 2017 23:26:01 -0000","(qmail 104175 invoked by uid 89); 27 Sep 2017 23:26:00 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=c1o/nyRbwby7UY6j+oawNIDR2rUanua\n\tkvBpnVY/FBNsTCGvaXx5L+H9y7cMRcYqbOeVHBW8ESqf1+9vbdqOiCoai6NoO8fw\n\tu3iQ3AojyEVK0mqAdwBZ/pXRm3FRY4EqtQtPcpZc6ZBY2lEYYV2Ie7F9KevfFP4R\n\t1lRy/MBvrei0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=HpKZ1JioNVCpf+C97QK8twPYjeU=; b=Y69jO\n\tZHanW3qDoxucmhdqZS2IU5kq4DRgO1wPMDNxP24hcEsqj/pzuBW9DN7Q1SHpzn9u\n\tO/nUq+C23ds/iXc6/rnSWVEqfkLqhcLUgyVkYlT7cohjNCLqV8BNBCqQCrRtpFBv\n\tfINmMTr5IKuyB51NE4kax9ahawOYctKwKuzmbk=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS,\n\tSPF_NEUTRAL autolearn=ham version=3.3.2 spammy=","X-HELO":"hera.aquilenet.fr","From":"Samuel Thibault ","To":"libc-alpha@sourceware.org","Cc":"Samuel Thibault ","Subject":"[hurd, commited 3/4] hurd: Fix `seekdir' symbol exposition from\n\t`rewinddir'","Date":"Thu, 28 Sep 2017 01:17:41 +0200","Message-Id":"<20170927231742.9050-4-samuel.thibault@ens-lyon.org>","In-Reply-To":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>","References":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>"},"content":"`seekdir' is MISC || XOPEN, it should not be exposed along `rewinddir' which\nis POSIX.\n\n\t* include/dirent.h (__seekdir): New declaration.\n\t* sysdeps/mach/hurd/seekdir.c (seekdir): Rename to __seekdir and\n\tredefine as weak alias.\n\t* sysdeps/mach/hurd/rewinddir.c (__rewinddir): Use __seekdir instead\n\tof seekdir.\n---\n ChangeLog | 5 +++++\n include/dirent.h | 1 +\n sysdeps/mach/hurd/rewinddir.c | 2 +-\n sysdeps/mach/hurd/seekdir.c | 5 +++--\n 4 files changed, 10 insertions(+), 3 deletions(-)","diff":"diff --git a/ChangeLog b/ChangeLog\nindex ff321d7e2b..737dc8f808 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -12,6 +12,11 @@\n \t* sysdeps/mach/hurd/revoke.c (revoke): Likewise.\n \t* sysdeps/unix/bsd/unlockpt.c (unlockpt): Use __revoke instead of\n \trevoke.\n+\t* include/dirent.h (__seekdir): New declaration.\n+\t* sysdeps/mach/hurd/seekdir.c (seekdir): Rename to __seekdir and\n+\tredefine as weak alias.\n+\t* sysdeps/mach/hurd/rewinddir.c (__rewinddir): Use __seekdir instead\n+\tof seekdir.\n \n 2017-09-26 H.J. Lu \n \ndiff --git a/include/dirent.h b/include/dirent.h\nindex 5720d589a2..d7dbf83964 100644\n--- a/include/dirent.h\n+++ b/include/dirent.h\n@@ -46,6 +46,7 @@ extern int __versionsort64 (const struct dirent64 **a,\n extern DIR *__alloc_dir (int fd, bool close_fd, int flags,\n \t\t\t const struct stat64 *statp) attribute_hidden;\n extern __typeof (rewinddir) __rewinddir;\n+extern __typeof (seekdir) __seekdir;\n extern __typeof (dirfd) __dirfd;\n \n extern void __scandir_cancel_handler (void *arg) attribute_hidden;\ndiff --git a/sysdeps/mach/hurd/rewinddir.c b/sysdeps/mach/hurd/rewinddir.c\nindex b6791d95c3..84aa87c961 100644\n--- a/sysdeps/mach/hurd/rewinddir.c\n+++ b/sysdeps/mach/hurd/rewinddir.c\n@@ -24,7 +24,7 @@\n void\n __rewinddir (DIR *dirp)\n {\n- seekdir (dirp, (off_t) 0L);\n+ __seekdir (dirp, (off_t) 0L);\n }\n libc_hidden_def (__rewinddir)\n weak_alias (__rewinddir, rewinddir)\ndiff --git a/sysdeps/mach/hurd/seekdir.c b/sysdeps/mach/hurd/seekdir.c\nindex 8d3020b02c..68f7ce07c5 100644\n--- a/sysdeps/mach/hurd/seekdir.c\n+++ b/sysdeps/mach/hurd/seekdir.c\n@@ -22,9 +22,8 @@\n #include \"dirstream.h\"\n \n /* Seek to position POS in DIRP. */\n-/* XXX should be __seekdir ? */\n void\n-seekdir (DIR *dirp, long int pos)\n+__seekdir (DIR *dirp, long int pos)\n {\n __libc_lock_lock (dirp->__lock);\n /* Change our entry index pointer to POS and discard any data already\n@@ -35,3 +34,5 @@ seekdir (DIR *dirp, long int pos)\n dirp->__size = 0;\n __libc_lock_unlock (dirp->__lock);\n }\n+\n+weak_alias (__seekdir, seekdir)\n","prefixes":["hurd","commited","3/4"]}