{"id":819337,"url":"http://patchwork.ozlabs.org/api/patches/819337/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-5-samuel.thibault@ens-lyon.org/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927231742.9050-5-samuel.thibault@ens-lyon.org>","list_archive_url":null,"date":"2017-09-27T23:17:42","name":"[hurd,commited,4/4] hurd: Fix `getifaddrs' and `freeifaddrs' symbol exposition","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"de48093682ee9bef15548fe3d5027fc7ab3bc002","submitter":{"id":418,"url":"http://patchwork.ozlabs.org/api/people/418/?format=json","name":"Samuel Thibault","email":"samuel.thibault@ens-lyon.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-5-samuel.thibault@ens-lyon.org/mbox/","series":[{"id":5459,"url":"http://patchwork.ozlabs.org/api/series/5459/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=5459","date":"2017-09-27T23:17:38","name":"Fixing symbol exposition.s","version":1,"mbox":"http://patchwork.ozlabs.org/series/5459/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819337/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819337/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85051-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"aOoPDXo1\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Yf75vLLz9t6B\n\tfor ;\n\tThu, 28 Sep 2017 09:18:23 +1000 (AEST)","(qmail 80363 invoked by alias); 27 Sep 2017 23:17:51 -0000","(qmail 80271 invoked by uid 89); 27 Sep 2017 23:17:50 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=ArO519PG1ePoebqIfQQX1XtJBNsdLJT\n\tVGmicH51qhKM7DRoJk4m5hsE/E61FAtYzkgq2QU30FoG076Ww3Jj3X2TWvr2vn+8\n\tPUOOSZYbudNyJYoMwhxtfVZhb46EvXZFHFzgnwXAfdZnEXbx1WoHI3+3NHmBX0mg\n\tbb0IaEdpLemg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=eLKme+GVNdPbwNOHQW4PqKpKMfo=; b=aOoPD\n\tXo1gHzUJRw+u/ktH18XqUYZrst2+0Wrc9HxiyqC5ID1xLp/hwQ1eKAN6Z/Sm+uSL\n\t6RbaUc8zneasgcC+S9o/alEQcarsIPzJQo4X6RpeOgSjXNWNxpD03vcCBQFrZFgC\n\t2qEthxqKJVEAmCAUok9k/PQtdTV7EypI22ojm8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS,\n\tSPF_NEUTRAL autolearn=ham version=3.3.2 spammy=","X-HELO":"hera.aquilenet.fr","From":"Samuel Thibault ","To":"libc-alpha@sourceware.org","Cc":"Samuel Thibault ","Subject":"[hurd, commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs' symbol\n\texposition","Date":"Thu, 28 Sep 2017 01:17:42 +0200","Message-Id":"<20170927231742.9050-5-samuel.thibault@ens-lyon.org>","In-Reply-To":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>","References":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>"},"content":"from `freeaddrinfo'.\n\n`getifaddrs' and `freeifaddrs' are not in POSIX, they should not be\nexposed along `freeaddrinfo' (through `__check_pf') which is POSIX.\n\n\t* include/ifaddrs.h (__getifaddrs, __freeifaddrs): New declarations,\n\tand use libc_hidden_def on them.\n\t* inet/ifaddrs.c (__getifaddrs, __freeifaddrs): Use libc_hidden_def on\n\tthem.\n\t* sysdeps/gnu/ifaddrs.c (__getifaddrs, __freeifaddrs): Likewise.\n\t* inet/check_pf.c (__check_pf): Use __getifaddrs and __freeifaddrs\n\tinstead of getifaddrs and freeifaddrs.\n---\n ChangeLog | 7 +++++++\n include/ifaddrs.h | 5 +++++\n inet/check_pf.c | 4 ++--\n inet/ifaddrs.c | 2 ++\n sysdeps/gnu/ifaddrs.c | 2 ++\n 5 files changed, 18 insertions(+), 2 deletions(-)","diff":"diff --git a/ChangeLog b/ChangeLog\nindex 737dc8f808..8e26c003a8 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -17,6 +17,13 @@\n \tredefine as weak alias.\n \t* sysdeps/mach/hurd/rewinddir.c (__rewinddir): Use __seekdir instead\n \tof seekdir.\n+\t* include/ifaddrs.h (__getifaddrs, __freeifaddrs): New declarations,\n+\tand use libc_hidden_def on them.\n+\t* inet/ifaddrs.c (__getifaddrs, __freeifaddrs): Use libc_hidden_def on\n+\tthem.\n+\t* sysdeps/gnu/ifaddrs.c (__getifaddrs, __freeifaddrs): Likewise.\n+\t* inet/check_pf.c (__check_pf): Use __getifaddrs and __freeifaddrs\n+\tinstead of getifaddrs and freeifaddrs.\n \n 2017-09-26 H.J. Lu \n \ndiff --git a/include/ifaddrs.h b/include/ifaddrs.h\nindex 54f4b7a3ce..416118f1b3 100644\n--- a/include/ifaddrs.h\n+++ b/include/ifaddrs.h\n@@ -9,6 +9,11 @@\n libc_hidden_proto (getifaddrs)\n libc_hidden_proto (freeifaddrs)\n \n+extern int __getifaddrs (struct ifaddrs **__ifap);\n+libc_hidden_proto (__getifaddrs)\n+extern void __freeifaddrs (struct ifaddrs *__ifa);\n+libc_hidden_proto (__freeifaddrs)\n+\n struct in6addrinfo\n {\n enum {\ndiff --git a/inet/check_pf.c b/inet/check_pf.c\nindex a56723a7df..84dd1699d5 100644\n--- a/inet/check_pf.c\n+++ b/inet/check_pf.c\n@@ -32,7 +32,7 @@ __check_pf (bool *seen_ipv4, bool *seen_ipv6,\n \n /* Get the interface list via getifaddrs. */\n struct ifaddrs *ifa = NULL;\n- if (getifaddrs (&ifa) != 0)\n+ if (__getifaddrs (&ifa) != 0)\n {\n /* We cannot determine what interfaces are available. Be\n \t pessimistic. */\n@@ -51,7 +51,7 @@ __check_pf (bool *seen_ipv4, bool *seen_ipv6,\n else if (runp->ifa_addr->sa_family == PF_INET6)\n *seen_ipv6 = true;\n \n- (void) freeifaddrs (ifa);\n+ (void) __freeifaddrs (ifa);\n }\n \n \ndiff --git a/inet/ifaddrs.c b/inet/ifaddrs.c\nindex 35cc277225..0a5c71c059 100644\n--- a/inet/ifaddrs.c\n+++ b/inet/ifaddrs.c\n@@ -30,6 +30,7 @@ __getifaddrs (struct ifaddrs **ifap)\n return -1;\n }\n weak_alias (__getifaddrs, getifaddrs)\n+libc_hidden_def (__getifaddrs)\n libc_hidden_weak (getifaddrs)\n stub_warning (getifaddrs)\n \n@@ -43,5 +44,6 @@ __freeifaddrs (struct ifaddrs *ifa)\n abort ();\n }\n weak_alias (__freeifaddrs, freeifaddrs)\n+libc_hidden_def (__freeifaddrs)\n libc_hidden_weak (freeifaddrs)\n stub_warning (freeifaddrs)\ndiff --git a/sysdeps/gnu/ifaddrs.c b/sysdeps/gnu/ifaddrs.c\nindex 37b3248669..80702eb1d1 100644\n--- a/sysdeps/gnu/ifaddrs.c\n+++ b/sysdeps/gnu/ifaddrs.c\n@@ -151,6 +151,7 @@ __getifaddrs (struct ifaddrs **ifap)\n return 0;\n }\n weak_alias (__getifaddrs, getifaddrs)\n+libc_hidden_def (__getifaddrs)\n #ifndef getifaddrs\n libc_hidden_weak (getifaddrs)\n #endif\n@@ -161,4 +162,5 @@ __freeifaddrs (struct ifaddrs *ifa)\n free (ifa);\n }\n weak_alias (__freeifaddrs, freeifaddrs)\n+libc_hidden_def (__freeifaddrs)\n libc_hidden_weak (freeifaddrs)\n","prefixes":["hurd","commited","4/4"]}