{"id":819335,"url":"http://patchwork.ozlabs.org/api/patches/819335/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-3-samuel.thibault@ens-lyon.org/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927231742.9050-3-samuel.thibault@ens-lyon.org>","list_archive_url":null,"date":"2017-09-27T23:17:40","name":"[hurd,commited,2/4] hurd: Fix `revoke' symbol exposition from `unlockpt'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94723c95fbe8c388bebcc6dacb025b4c8fa6dbc4","submitter":{"id":418,"url":"http://patchwork.ozlabs.org/api/people/418/?format=json","name":"Samuel Thibault","email":"samuel.thibault@ens-lyon.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170927231742.9050-3-samuel.thibault@ens-lyon.org/mbox/","series":[{"id":5459,"url":"http://patchwork.ozlabs.org/api/series/5459/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=5459","date":"2017-09-27T23:17:38","name":"Fixing symbol exposition.s","version":1,"mbox":"http://patchwork.ozlabs.org/series/5459/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819335/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819335/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85049-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"TFenuLOk\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Ydm5F2Bz9t6B\n\tfor ;\n\tThu, 28 Sep 2017 09:18:04 +1000 (AEST)","(qmail 79929 invoked by alias); 27 Sep 2017 23:17:49 -0000","(qmail 79904 invoked by uid 89); 27 Sep 2017 23:17:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=DqK3lDWDiN284SbEAN3NaKnsFmrGv4H\n\ttwhk2a1UVwu/ZjBSa3XTFoiRubZ6Kyhklo6+8X6EAMdFbUQs0XQl79jkk+v8oXif\n\tmIG/UePfruflkN30nj1qbCMYzblr+S6zqy2tnx5c30av9ZMZ/bOq2qDPMLbnzLbd\n\tIAZX8ycueSMk=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=NK5tachBSoHZE8xXyN/+SX7WBg0=; b=TFenu\n\tLOky4bmOY6PGJ5MUb3s7TEYOk1Lbm1dPzkY7zHmLS4h9d/6qbZBum2Z37zG28mwQ\n\tI1VTOJ3ZNm78wffkUqiGWexWVFPxkkm6fX0HHXcRmzwI8QitJsWUrnGKJ/XveooN\n\tzD8olhcWTJU4dH8jmsbmhU2d4m96vclJzV+R/Y=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS,\n\tSPF_NEUTRAL autolearn=ham version=3.3.2 spammy=","X-HELO":"hera.aquilenet.fr","From":"Samuel Thibault ","To":"libc-alpha@sourceware.org","Cc":"Samuel Thibault ","Subject":"[hurd,\n\tcommited 2/4] hurd: Fix `revoke' symbol exposition from `unlockpt'","Date":"Thu, 28 Sep 2017 01:17:40 +0200","Message-Id":"<20170927231742.9050-3-samuel.thibault@ens-lyon.org>","In-Reply-To":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>","References":"<20170927231742.9050-1-samuel.thibault@ens-lyon.org>"},"content":"`revoke' is MISC only, it should not be exposed along `unlockpt' which is\nXOPEN.\n\n\t* include/unistd.h (__revoke): New declaration.\n\t* misc/revoke.c (revoke): Rename to __revoke, and redefine as weak\n\talias.\n\t* sysdeps/mach/hurd/revoke.c (revoke): Likewise.\n\t* sysdeps/unix/bsd/unlockpt.c (unlockpt): Use __revoke instead of\n\trevoke.\n---\n ChangeLog | 6 ++++++\n include/unistd.h | 1 +\n misc/revoke.c | 4 +++-\n sysdeps/mach/hurd/revoke.c | 4 +++-\n sysdeps/unix/bsd/unlockpt.c | 2 +-\n 5 files changed, 14 insertions(+), 3 deletions(-)","diff":"diff --git a/ChangeLog b/ChangeLog\nindex a535da875c..ff321d7e2b 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -6,6 +6,12 @@\n \t* sysdeps/posix/dirfd/dirfd.c (dirfd): Likewise.\n \t* sysdeps/mach/hurd/dirfd.c (dirfd): Likewise.\n \t* io/ftw.c (open_dir_stream, ftw_dir): Use __dirfd instead of dirfd.\n+\t* include/unistd.h (__revoke): New declaration.\n+\t* misc/revoke.c (revoke): Rename to __revoke, and redefine as weak\n+\talias.\n+\t* sysdeps/mach/hurd/revoke.c (revoke): Likewise.\n+\t* sysdeps/unix/bsd/unlockpt.c (unlockpt): Use __revoke instead of\n+\trevoke.\n \n 2017-09-26 H.J. Lu \n \ndiff --git a/include/unistd.h b/include/unistd.h\nindex a5625ed7f4..bfe0e4de47 100644\n--- a/include/unistd.h\n+++ b/include/unistd.h\n@@ -130,6 +130,7 @@ extern int __symlink (const char *__from, const char *__to);\n extern ssize_t __readlink (const char *__path, char *__buf, size_t __len);\n extern int __unlink (const char *__name);\n extern int __gethostname (char *__name, size_t __len);\n+extern int __revoke (const char *__file);\n extern int __profil (unsigned short int *__sample_buffer, size_t __size,\n \t\t size_t __offset, unsigned int __scale);\n extern int __getdtablesize (void);\ndiff --git a/misc/revoke.c b/misc/revoke.c\nindex d953216246..21df2bbf90 100644\n--- a/misc/revoke.c\n+++ b/misc/revoke.c\n@@ -20,9 +20,11 @@\n #include \n \n int\n-revoke (const char *file)\n+__revoke (const char *file)\n {\n __set_errno (ENOSYS);\n return -1;\n }\n+\n+weak_alias (__revoke, revoke)\n stub_warning (revoke)\ndiff --git a/sysdeps/mach/hurd/revoke.c b/sysdeps/mach/hurd/revoke.c\nindex 15b955b733..2f47f42de6 100644\n--- a/sysdeps/mach/hurd/revoke.c\n+++ b/sysdeps/mach/hurd/revoke.c\n@@ -21,7 +21,7 @@\n #include \n \n int\n-revoke (const char *file_name)\n+__revoke (const char *file_name)\n {\n error_t err;\n file_t file = __file_name_lookup (file_name, 0, 0);\n@@ -36,3 +36,5 @@ revoke (const char *file_name)\n return __hurd_fail (err);\n return 0;\n }\n+\n+weak_alias (__revoke, revoke)\ndiff --git a/sysdeps/unix/bsd/unlockpt.c b/sysdeps/unix/bsd/unlockpt.c\nindex 7388c98523..ca4e7c654e 100644\n--- a/sysdeps/unix/bsd/unlockpt.c\n+++ b/sysdeps/unix/bsd/unlockpt.c\n@@ -32,5 +32,5 @@ unlockpt (int fd)\n /* BSD doesn't have a lock, but it does have `revoke'. */\n if (__ptsname_r (fd, buf, sizeof (buf)))\n return -1;\n- return revoke (buf);\n+ return __revoke (buf);\n }\n","prefixes":["hurd","commited","2/4"]}