{"id":819329,"url":"http://patchwork.ozlabs.org/api/patches/819329/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20170927214220.41216-2-gvaradar@cisco.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927214220.41216-2-gvaradar@cisco.com>","list_archive_url":null,"date":"2017-09-27T21:42:17","name":"[1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b8172854a2f9a512b283d14e5cc569b8cb3423f5","submitter":{"id":46073,"url":"http://patchwork.ozlabs.org/api/people/46073/?format=json","name":"Govindarajulu Varadarajan","email":"gvaradar@cisco.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20170927214220.41216-2-gvaradar@cisco.com/mbox/","series":[{"id":5455,"url":"http://patchwork.ozlabs.org/api/series/5455/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=5455","date":"2017-09-27T21:42:16","name":"pci aer: fix deadlock in do_recovery","version":1,"mbox":"http://patchwork.ozlabs.org/series/5455/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819329/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819329/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cisco.com header.i=@cisco.com\n\theader.b=\"OGhwSXO0\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2Wm53Rcyz9t67\n\tfor ;\n\tThu, 28 Sep 2017 07:53:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752144AbdI0Vwa (ORCPT );\n\tWed, 27 Sep 2017 17:52:30 -0400","from rcdn-iport-4.cisco.com ([173.37.86.75]:6653 \"EHLO\n\trcdn-iport-4.cisco.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751905AbdI0Vw2 (ORCPT\n\t); Wed, 27 Sep 2017 17:52:28 -0400","from alln-core-6.cisco.com ([173.36.13.139])\n\tby rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t27 Sep 2017 21:43:01 +0000","from a6.cisco.com (arch-kvm-vm.cisco.com [10.193.184.6])\n\t(authenticated bits=0)\n\tby alln-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id v8RLgpwf021066\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tWed, 27 Sep 2017 21:43:01 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=2173; q=dns/txt; s=iport;\n\tt=1506549148; x=1507758748;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=X7fSRQLsZ211tIM61Y9UPjaMS0toQmqfB5PzzOy2iUs=;\n\tb=OGhwSXO0h94x0o6c2D/zVSVYYXsCslVsSURupnyP/UZk7mTeM0jkBLzw\n\tMy3oZhIjfQn7yRi/6itzqphsU+Icx/189IqXiQJrw4Nxodm/s9PSgqRyr\n\tJ2Nix9yXGEYNtmX9tcAkq+eXcXZ2RQ/3BXVyTTcOZozG+6iYemdmoLUug k=;","X-IronPort-AV":"E=Sophos;i=\"5.42,446,1500940800\"; d=\"scan'208\";a=\"300794028\"","From":"Govindarajulu Varadarajan ","To":"benve@cisco.com, bhelgaas@google.com, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, jlbec@evilplan.org, hch@lst.de,\n\tmingo@redhat.com, peterz@infradead.org","Cc":"Govindarajulu Varadarajan ","Subject":"[PATCH 1/4] pci: introduce __pci_walk_bus for caller with\n\tpci_bus_sem held","Date":"Wed, 27 Sep 2017 14:42:17 -0700","Message-Id":"<20170927214220.41216-2-gvaradar@cisco.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170927214220.41216-1-gvaradar@cisco.com>","References":"<20170927214220.41216-1-gvaradar@cisco.com>","X-Authenticated-User":"gvaradar@cisco.com","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"Move pci_bus_sem down/up out of pci_walk_bus and rename it to\n__pci_walk_bus. Caller who already hold pci_bus_sem can call\n__pci_walk_bus.\n\nSigned-off-by: Govindarajulu Varadarajan \n---\n drivers/pci/bus.c | 13 +++++++++++--\n include/linux/pci.h | 2 ++\n 2 files changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c\nindex bc56cf19afd3..3cababe74af0 100644\n--- a/drivers/pci/bus.c\n+++ b/drivers/pci/bus.c\n@@ -376,8 +376,10 @@ EXPORT_SYMBOL(pci_bus_add_devices);\n * We check the return of @cb each time. If it returns anything\n * other than 0, we break out.\n *\n+ * Should be called with read pci_bus_sem held.\n+ *\n */\n-void pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n+void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n \t\t void *userdata)\n {\n \tstruct pci_dev *dev;\n@@ -386,7 +388,6 @@ void pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n \tint retval;\n \n \tbus = top;\n-\tdown_read(&pci_bus_sem);\n \tnext = top->devices.next;\n \tfor (;;) {\n \t\tif (next == &bus->devices) {\n@@ -409,6 +410,14 @@ void pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n \t\tif (retval)\n \t\t\tbreak;\n \t}\n+}\n+EXPORT_SYMBOL_GPL(__pci_walk_bus);\n+\n+void pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n+\t\t void *userdata)\n+{\n+\tdown_read(&pci_bus_sem);\n+\t__pci_walk_bus(top, cb, userdata);\n \tup_read(&pci_bus_sem);\n }\n EXPORT_SYMBOL_GPL(pci_walk_bus);\ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex f68c58a93dd0..b4b1a8a164c0 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -1297,6 +1297,8 @@ int pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max,\n \n void pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n \t\t void *userdata);\n+void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),\n+\t\t void *userdata);\n int pci_cfg_space_size(struct pci_dev *dev);\n unsigned char pci_bus_max_busnr(struct pci_bus *bus);\n void pci_setup_bridge(struct pci_bus *bus);\n","prefixes":["1/4"]}