{"id":819305,"url":"http://patchwork.ozlabs.org/api/patches/819305/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927204148.2311-3-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927204148.2311-3-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-27T20:41:48","name":"[v3,2/2] vl: Print warning when a default config file is loaded","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e0069e7152d99ec222cddd92344b6b1d6b806817","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927204148.2311-3-ehabkost@redhat.com/mbox/","series":[{"id":5444,"url":"http://patchwork.ozlabs.org/api/series/5444/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5444","date":"2017-09-27T20:41:46","name":"vl: Print warning if a non-empty default config file is found","version":3,"mbox":"http://patchwork.ozlabs.org/series/5444/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819305/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819305/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VBC3KFLz9t66\n\tfor ;\n\tThu, 28 Sep 2017 06:42:27 +1000 (AEST)","from localhost ([::1]:56273 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxJA1-0000n0-HB\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 16:42:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59982)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxJ9X-0000m2-Px\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:41:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxJ9X-0004DI-1b\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:41:55 -0400","from mx1.redhat.com ([209.132.183.28]:58782)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxJ9W-0004Cv-RL\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:41:54 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D5EE613D9E8\n\tfor ; Wed, 27 Sep 2017 20:41:53 +0000 (UTC)","from localhost (ovpn-116-18.gru2.redhat.com [10.97.116.18])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 70AC37F92B;\n\tWed, 27 Sep 2017 20:41:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D5EE613D9E8","From":"Eduardo Habkost ","To":"qemu-devel@nongnu.org","Date":"Wed, 27 Sep 2017 17:41:48 -0300","Message-Id":"<20170927204148.2311-3-ehabkost@redhat.com>","In-Reply-To":"<20170927204148.2311-1-ehabkost@redhat.com>","References":"<20170927204148.2311-1-ehabkost@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 27 Sep 2017 20:41:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config\n\tfile is loaded","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tMarkus Armbruster ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"In case there were options set in the default config file, print\na warning so users can update their scripts.\n\nIf somebody wants to keep the config file as-is, avoid the\nwarning and use a command-line that will work in future QEMU\nversions, they can use:\n\n $QEMU -no-user-config -readconfig /etc/qemu/qemu.conf\n\nI was going to add an additional message suggesting it as a\nsolution, but I thought it could make it more confusing. The\nsolution can be documented in the QEMU 2.11 ChangeLog.\n\nReviewed-by: Markus Armbruster \nSigned-off-by: Eduardo Habkost \n---\nChanges v2 -> v3:\n* Rebase (no code changes)\n* Commit message update: suggest -no-user-config\n---\n vl.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/vl.c b/vl.c\nindex 4fd01fda91..888649bbd1 100644\n--- a/vl.c\n+++ b/vl.c\n@@ -3048,6 +3048,12 @@ static int qemu_read_default_config_file(void)\n return ret;\n }\n \n+ if (ret > 0) {\n+ loc_set_none();\n+ error_report(\"Warning: Future QEMU versions won't load %s automatically\",\n+ CONFIG_QEMU_CONFDIR \"/qemu.conf\");\n+ }\n+\n return 0;\n }\n \n","prefixes":["v3","2/2"]}