{"id":819237,"url":"http://patchwork.ozlabs.org/api/patches/819237/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927170027.8539-4-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927170027.8539-4-david@redhat.com>","list_archive_url":null,"date":"2017-09-27T17:00:27","name":"[RFC,3/3] s390x/tcg: make STFL store into the lowcore","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7f82e5124e3482ee7a2ad216e7a625945680eba1","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927170027.8539-4-david@redhat.com/mbox/","series":[{"id":5406,"url":"http://patchwork.ozlabs.org/api/series/5406/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5406","date":"2017-09-27T17:00:24","name":"s390x/tcg: LAP support using immediate TLB invalidation","version":1,"mbox":"http://patchwork.ozlabs.org/series/5406/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819237/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819237/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2PKC0TKLz9tXb\n\tfor ;\n\tThu, 28 Sep 2017 03:03:11 +1000 (AEST)","from localhost ([::1]:55626 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxFjp-00088y-45\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 13:03:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60125)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxFha-0006fM-J7\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 13:00:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxFhV-00067c-26\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 13:00:50 -0400","from mx1.redhat.com ([209.132.183.28]:51260)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxFhU-000675-SW\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 13:00:44 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B6E301766DA;\n\tWed, 27 Sep 2017 17:00:43 +0000 (UTC)","from t460s.redhat.com (ovpn-117-241.ams2.redhat.com\n\t[10.36.117.241])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D63BAE819E;\n\tWed, 27 Sep 2017 17:00:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B6E301766DA","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Wed, 27 Sep 2017 19:00:27 +0200","Message-Id":"<20170927170027.8539-4-david@redhat.com>","In-Reply-To":"<20170927170027.8539-1-david@redhat.com>","References":"<20170927170027.8539-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 27 Sep 2017 17:00:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH RFC 3/3] s390x/tcg: make STFL store into the\n\tlowcore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, David Hildenbrand , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tChristian Borntraeger ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Using virtual memory access is wrong and will soon include low-address\nprotection checks, which is to be bypassed for STFL.\n\nThis was originally part of a bigger STFL(E) refactoring.\n\nSigned-off-by: David Hildenbrand \n---\n target/s390x/helper.h | 2 +-\n target/s390x/misc_helper.c | 7 ++++++-\n 2 files changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/target/s390x/helper.h b/target/s390x/helper.h\nindex 75ba04fc15..52c2963baa 100644\n--- a/target/s390x/helper.h\n+++ b/target/s390x/helper.h\n@@ -104,7 +104,6 @@ DEF_HELPER_FLAGS_5(calc_cc, TCG_CALL_NO_RWG_SE, i32, env, i32, i64, i64, i64)\n DEF_HELPER_FLAGS_2(sfpc, TCG_CALL_NO_RWG, void, env, i64)\n DEF_HELPER_FLAGS_2(sfas, TCG_CALL_NO_WG, void, env, i64)\n DEF_HELPER_FLAGS_1(popcnt, TCG_CALL_NO_RWG_SE, i64, i64)\n-DEF_HELPER_FLAGS_1(stfl, TCG_CALL_NO_RWG, void, env)\n DEF_HELPER_2(stfle, i32, env, i64)\n DEF_HELPER_FLAGS_2(lpq, TCG_CALL_NO_WG, i64, env, i64)\n DEF_HELPER_FLAGS_4(stpq, TCG_CALL_NO_WG, void, env, i64, i64, i64)\n@@ -153,6 +152,7 @@ DEF_HELPER_FLAGS_3(sturg, TCG_CALL_NO_WG, void, env, i64, i64)\n DEF_HELPER_1(per_check_exception, void, env)\n DEF_HELPER_FLAGS_3(per_branch, TCG_CALL_NO_RWG, void, env, i64, i64)\n DEF_HELPER_FLAGS_2(per_ifetch, TCG_CALL_NO_RWG, void, env, i64)\n+DEF_HELPER_FLAGS_1(stfl, TCG_CALL_NO_RWG, void, env)\n \n DEF_HELPER_2(xsch, void, env, i64)\n DEF_HELPER_2(csch, void, env, i64)\ndiff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c\nindex 293fc8428a..0b93381188 100644\n--- a/target/s390x/misc_helper.c\n+++ b/target/s390x/misc_helper.c\n@@ -541,13 +541,18 @@ static unsigned do_stfle(CPUS390XState *env, uint64_t words[MAX_STFL_WORDS])\n return max_bit / 64;\n }\n \n+#ifndef CONFIG_USER_ONLY\n void HELPER(stfl)(CPUS390XState *env)\n {\n uint64_t words[MAX_STFL_WORDS];\n+ LowCore *lowcore;\n \n+ lowcore = cpu_map_lowcore(env);\n do_stfle(env, words);\n- cpu_stl_data(env, 200, words[0] >> 32);\n+ lowcore->stfl_fac_list = cpu_to_be32(words[0] >> 32);\n+ cpu_unmap_lowcore(lowcore);\n }\n+#endif\n \n uint32_t HELPER(stfle)(CPUS390XState *env, uint64_t addr)\n {\n","prefixes":["RFC","3/3"]}