{"id":819167,"url":"http://patchwork.ozlabs.org/api/patches/819167/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1506519893-16509-7-git-send-email-patrice.chotard@st.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506519893-16509-7-git-send-email-patrice.chotard@st.com>","list_archive_url":null,"date":"2017-09-27T13:44:53","name":"[U-Boot,v1,6/6] serial: stm32x7: remove useless CONFIG_CLK and OF_CONTROL flag","commit_ref":"9a212d7f553d01a45172da34970e3a7d481302fd","pull_url":null,"state":"accepted","archived":false,"hash":"117c896cc7aab3692b8819c1c6dfb868ee9ec107","submitter":{"id":63958,"url":"http://patchwork.ozlabs.org/api/people/63958/?format=json","name":"Patrice CHOTARD","email":"patrice.chotard@st.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1506519893-16509-7-git-send-email-patrice.chotard@st.com/mbox/","series":[{"id":5372,"url":"http://patchwork.ozlabs.org/api/series/5372/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=5372","date":"2017-09-27T13:44:48","name":"Update stm32x7 serial driver","version":1,"mbox":"http://patchwork.ozlabs.org/series/5372/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819167/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819167/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2JzJ2pKXz9tXy\n\tfor ;\n\tWed, 27 Sep 2017 23:47:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1E0F9C21D7B; Wed, 27 Sep 2017 13:45:59 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9FF67C21DA6;\n\tWed, 27 Sep 2017 13:45:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 73F5DC21C46; Wed, 27 Sep 2017 13:45:06 +0000 (UTC)","from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com\n\t[91.207.212.93])\n\tby lists.denx.de (Postfix) with ESMTPS id 2E7AFC21C45\n\tfor ; Wed, 27 Sep 2017 13:45:06 +0000 (UTC)","from pps.filterd (m0046661.ppops.net [127.0.0.1])\n\tby mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8RDiHAD013817; Wed, 27 Sep 2017 15:45:05 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx08-00178001.pphosted.com with ESMTP id 2d8cw703rb-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tWed, 27 Sep 2017 15:45:05 +0200","from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 85ABB3F;\n\tWed, 27 Sep 2017 13:45:04 +0000 (GMT)","from Webmail-eu.st.com (sfhdag6node3.st.com [10.75.127.18])\n\tby zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 599D828F4;\n\tWed, 27 Sep 2017 13:45:04 +0000 (GMT)","from localhost (10.75.127.45) by SFHDAG6NODE3.st.com (10.75.127.18)\n\twith Microsoft SMTP Server (TLS) id 15.0.1178.4;\n\tWed, 27 Sep 2017 15:45:03 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","From":"","To":", , , \n\t","Date":"Wed, 27 Sep 2017 15:44:53 +0200","Message-ID":"<1506519893-16509-7-git-send-email-patrice.chotard@st.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1506519893-16509-1-git-send-email-patrice.chotard@st.com>","References":"<1506519893-16509-1-git-send-email-patrice.chotard@st.com>","MIME-Version":"1.0","X-Originating-IP":"[10.75.127.45]","X-ClientProxiedBy":"SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG6NODE3.st.com\n\t(10.75.127.18)","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_03:, , signatures=0","Subject":"[U-Boot] [PATCH v1 6/6] serial: stm32x7: remove useless CONFIG_CLK\n\tand OF_CONTROL flag","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"From: Patrice Chotard \n\nThis driver is currently used by STM32F7 and STM32H7 SoCs.\nAs CONFIG_CLK and OF_CONTROL flags are set by default for these\n2 SoCs, this flag becomes useless in this driver, so remove it.\n\nSigned-off-by: Patrice Chotard \n---\n drivers/serial/serial_stm32x7.c | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/serial/serial_stm32x7.c b/drivers/serial/serial_stm32x7.c\nindex 44e8b42..a5d529c 100644\n--- a/drivers/serial/serial_stm32x7.c\n+++ b/drivers/serial/serial_stm32x7.c\n@@ -83,7 +83,9 @@ static int stm32_serial_pending(struct udevice *dev, bool input)\n static int stm32_serial_probe(struct udevice *dev)\n {\n \tstruct stm32x7_serial_platdata *plat = dev_get_platdata(dev);\n+\tstruct clk clk;\n \tfdt_addr_t base = plat->base;\n+\tint ret;\n \tbool stm32f4;\n \tu8 uart_enable_bit;\n \n@@ -91,10 +93,6 @@ static int stm32_serial_probe(struct udevice *dev)\n \tstm32f4 = plat->uart_info->stm32f4;\n \tuart_enable_bit = plat->uart_info->uart_enable_bit;\n \n-#ifdef CONFIG_CLK\n-\tint ret;\n-\tstruct clk clk;\n-\n \tret = clk_get_by_index(dev, 0, &clk);\n \tif (ret < 0)\n \t\treturn ret;\n@@ -104,7 +102,6 @@ static int stm32_serial_probe(struct udevice *dev)\n \t\tdev_err(dev, \"failed to enable clock\\n\");\n \t\treturn ret;\n \t}\n-#endif\n \n \tplat->clock_rate = clk_get_rate(&clk);\n \tif (plat->clock_rate < 0) {\n@@ -125,7 +122,6 @@ static int stm32_serial_probe(struct udevice *dev)\n \treturn 0;\n }\n \n-#if CONFIG_IS_ENABLED(OF_CONTROL)\n static const struct udevice_id stm32_serial_id[] = {\n \t{ .compatible = \"st,stm32-uart\", .data = (ulong)&stm32f4_info},\n \t{ .compatible = \"st,stm32f7-uart\", .data = (ulong)&stm32f7_info},\n@@ -143,7 +139,6 @@ static int stm32_serial_ofdata_to_platdata(struct udevice *dev)\n \n \treturn 0;\n }\n-#endif\n \n static const struct dm_serial_ops stm32_serial_ops = {\n \t.putc = stm32_serial_putc,\n","prefixes":["U-Boot","v1","6/6"]}