{"id":819152,"url":"http://patchwork.ozlabs.org/api/patches/819152/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927130339.21444-6-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927130339.21444-6-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-27T13:03:39","name":"[5/5] scripts: Remove debug parameter from QEMUMachine","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3d18ecb9a7fc69fc23545fb28cc11818a7544cd8","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927130339.21444-6-ehabkost@redhat.com/mbox/","series":[{"id":5363,"url":"http://patchwork.ozlabs.org/api/series/5363/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5363","date":"2017-09-27T13:03:34","name":"scripts: Remove 'debug' parameter from QEMUMachine & QEMUMonitorProtocol","version":1,"mbox":"http://patchwork.ozlabs.org/series/5363/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819152/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819152/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2J6q39gpz9t3h\n\tfor ;\n\tWed, 27 Sep 2017 23:08:51 +1000 (AEST)","from localhost ([::1]:54777 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxC53-00041F-GW\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 09:08:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52833)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxC0n-00011r-BS\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:04:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxC0h-0006m3-Bm\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:04:25 -0400","from mx1.redhat.com ([209.132.183.28]:42388)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxC0h-0006lu-3Z\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:04:19 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2BCF47E454\n\tfor ; Wed, 27 Sep 2017 13:04:18 +0000 (UTC)","from localhost (ovpn-116-18.gru2.redhat.com [10.97.116.18])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BA6647E137;\n\tWed, 27 Sep 2017 13:04:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2BCF47E454","From":"Eduardo Habkost ","To":"qemu-devel@nongnu.org","Date":"Wed, 27 Sep 2017 10:03:39 -0300","Message-Id":"<20170927130339.21444-6-ehabkost@redhat.com>","In-Reply-To":"<20170927130339.21444-1-ehabkost@redhat.com>","References":"<20170927130339.21444-1-ehabkost@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 27 Sep 2017 13:04:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH 5/5] scripts: Remove debug parameter from\n\tQEMUMachine","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tCleber Rosa ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"All scripts that use the QEMUMachine and QEMUQtestMachine classes\n(device-crash-test, tests/migration/*, iotests.py, basevm.py)\nalready configure logging.\n\nThe basicConfig() call inside QEMUMachine.__init__() is being\nkept just to make sure a script would still work if it didn't\nconfigure logging.\n\nSigned-off-by: Eduardo Habkost \n---\n scripts/qemu.py | 6 ++----\n tests/migration/guestperf/engine.py | 6 ++----\n tests/qemu-iotests/iotests.py | 2 --\n 3 files changed, 4 insertions(+), 10 deletions(-)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex f6d2e68627..9bfdf6d37d 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -54,7 +54,7 @@ class QEMUMachine(object):\n \n def __init__(self, binary, args=None, wrapper=None, name=None,\n test_dir=\"/var/tmp\", monitor_address=None,\n- socket_scm_helper=None, debug=False):\n+ socket_scm_helper=None):\n '''\n Initialize a QEMUMachine\n \n@@ -65,7 +65,6 @@ class QEMUMachine(object):\n @param test_dir: where to create socket and log file\n @param monitor_address: address for QMP monitor\n @param socket_scm_helper: helper program, required for send_fd_scm()\"\n- @param debug: enable debug mode\n @note: Qemu process is not started until launch() is used.\n '''\n if args is None:\n@@ -85,12 +84,11 @@ class QEMUMachine(object):\n self._events = []\n self._iolog = None\n self._socket_scm_helper = socket_scm_helper\n- self._debug = debug\n self._qmp = None\n self._qemu_full_args = None\n \n # just in case logging wasn't configured by the main script:\n- logging.basicConfig(level=(logging.DEBUG if debug else logging.WARN))\n+ logging.basicConfig()\n \n def __enter__(self):\n return self\ndiff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py\nindex 0a13050bc6..e14d4320b2 100644\n--- a/tests/migration/guestperf/engine.py\n+++ b/tests/migration/guestperf/engine.py\n@@ -388,15 +388,13 @@ class Engine(object):\n args=self._get_src_args(hardware),\n wrapper=self._get_src_wrapper(hardware),\n name=\"qemu-src-%d\" % os.getpid(),\n- monitor_address=srcmonaddr,\n- debug=self._debug)\n+ monitor_address=srcmonaddr)\n \n dst = qemu.QEMUMachine(self._binary,\n args=self._get_dst_args(hardware, uri),\n wrapper=self._get_dst_wrapper(hardware),\n name=\"qemu-dst-%d\" % os.getpid(),\n- monitor_address=dstmonaddr,\n- debug=self._debug)\n+ monitor_address=dstmonaddr)\n \n try:\n src.launch()\ndiff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py\nindex 36a7757aaf..6f057904a9 100644\n--- a/tests/qemu-iotests/iotests.py\n+++ b/tests/qemu-iotests/iotests.py\n@@ -195,8 +195,6 @@ class VM(qtest.QEMUQtestMachine):\n super(VM, self).__init__(qemu_prog, qemu_opts, name=name,\n test_dir=test_dir,\n socket_scm_helper=socket_scm_helper)\n- if debug:\n- self._debug = True\n self._num_drives = 0\n \n def add_device(self, opts):\n","prefixes":["5/5"]}