{"id":819151,"url":"http://patchwork.ozlabs.org/api/patches/819151/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927130339.21444-4-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927130339.21444-4-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-09-27T13:03:37","name":"[3/5] basevm: Call logging.basicConfig()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dd70d8028d57657fed8a5ace1f765ddab39407f1","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927130339.21444-4-ehabkost@redhat.com/mbox/","series":[{"id":5363,"url":"http://patchwork.ozlabs.org/api/series/5363/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5363","date":"2017-09-27T13:03:34","name":"scripts: Remove 'debug' parameter from QEMUMachine & QEMUMonitorProtocol","version":1,"mbox":"http://patchwork.ozlabs.org/series/5363/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819151/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819151/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2J536pvdz9tXs\n\tfor ;\n\tWed, 27 Sep 2017 23:07:19 +1000 (AEST)","from localhost ([::1]:54772 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxC3a-0002nn-05\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 09:07:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52803)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxC0h-0000yS-Bv\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:04:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxC0d-0006kc-8b\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:04:19 -0400","from mx1.redhat.com ([209.132.183.28]:41508)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxC0d-0006kK-2L\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:04:15 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 098E33DBDC;\n\tWed, 27 Sep 2017 13:04:14 +0000 (UTC)","from localhost (ovpn-116-18.gru2.redhat.com [10.97.116.18])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BD1C589201;\n\tWed, 27 Sep 2017 13:04:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 098E33DBDC","From":"Eduardo Habkost ","To":"qemu-devel@nongnu.org","Date":"Wed, 27 Sep 2017 10:03:37 -0300","Message-Id":"<20170927130339.21444-4-ehabkost@redhat.com>","In-Reply-To":"<20170927130339.21444-1-ehabkost@redhat.com>","References":"<20170927130339.21444-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 27 Sep 2017 13:04:14 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tFam Zheng , =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tCleber Rosa ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Just setting level=DEBUG when debug is enabled is not enough: we\nneed to set up a log handler if we want debug messages generated\nusing logging.getLogger(...).debug() to be printed.\n\nThis was not a problem before because logging.debug() calls\nlogging.basicConfig() implicitly, but it's safer to not rely on\nthat.\n\nCc: \"Alex Bennée\" \nCc: Fam Zheng \nCc: \"Philippe Mathieu-Daudé\" \nSigned-off-by: Eduardo Habkost \n---\n tests/vm/basevm.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py\nindex 3c863bc237..686d88decf 100755\n--- a/tests/vm/basevm.py\n+++ b/tests/vm/basevm.py\n@@ -227,8 +227,8 @@ def main(vmcls):\n if not argv and not args.build_qemu and not args.build_image:\n print \"Nothing to do?\"\n return 1\n- if args.debug:\n- logging.getLogger().setLevel(logging.DEBUG)\n+ logging.basicConfig(level=(logging.DEBUG if args.debug\n+ else logging.WARN))\n vm = vmcls(debug=args.debug, vcpus=args.jobs)\n if args.build_image:\n if os.path.exists(args.image) and not args.force:\n","prefixes":["3/5"]}