{"id":819139,"url":"http://patchwork.ozlabs.org/api/patches/819139/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927125340.12360-7-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927125340.12360-7-berrange@redhat.com>","list_archive_url":null,"date":"2017-09-27T12:53:40","name":"[v4,6/6] block: support passthrough of BDRV_REQ_FUA in crypto driver","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5c06785dc25b5009f784451f113d5606b0ce2eae","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170927125340.12360-7-berrange@redhat.com/mbox/","series":[{"id":5359,"url":"http://patchwork.ozlabs.org/api/series/5359/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5359","date":"2017-09-27T12:53:35","name":"Misc improvements to crypto block driver","version":4,"mbox":"http://patchwork.ozlabs.org/series/5359/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819139/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819139/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Hq04Zqwz9tXQ\n\tfor ;\n\tWed, 27 Sep 2017 22:55:05 +1000 (AEST)","from localhost ([::1]:54696 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxBri-0004bj-Vf\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 08:55:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50116)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxBr0-0004Xc-2O\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:54:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxBqz-0001fL-Ct\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:54:18 -0400","from mx1.redhat.com ([209.132.183.28]:53066)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxBqq-0001Zb-Q0; Wed, 27 Sep 2017 08:54:08 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B7A3913AB3;\n\tWed, 27 Sep 2017 12:54:07 +0000 (UTC)","from localhost.localdomain.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 24A2F7FA46;\n\tWed, 27 Sep 2017 12:54:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B7A3913AB3","From":"\"Daniel P. Berrange\" ","To":"qemu-devel@nongnu.org","Date":"Wed, 27 Sep 2017 13:53:40 +0100","Message-Id":"<20170927125340.12360-7-berrange@redhat.com>","In-Reply-To":"<20170927125340.12360-1-berrange@redhat.com>","References":"<20170927125340.12360-1-berrange@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 27 Sep 2017 12:54:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v4 6/6] block: support passthrough of\n\tBDRV_REQ_FUA in crypto driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n\tStefan Hajnoczi , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The BDRV_REQ_FUA flag can trivially be allowed in the crypt driver\nas a passthrough to the underlying block driver.\n\nReviewed-by: Max Reitz \nReviewed-by: Eric Blake \nSigned-off-by: Daniel P. Berrange \n---\n block/crypto.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/block/crypto.c b/block/crypto.c\nindex edf53d49d1..60ddf8623e 100644\n--- a/block/crypto.c\n+++ b/block/crypto.c\n@@ -279,6 +279,9 @@ static int block_crypto_open_generic(QCryptoBlockFormat format,\n return -EINVAL;\n }\n \n+ bs->supported_write_flags = BDRV_REQ_FUA &\n+ bs->file->bs->supported_write_flags;\n+\n opts = qemu_opts_create(opts_spec, NULL, 0, &error_abort);\n qemu_opts_absorb_qdict(opts, options, &local_err);\n if (local_err) {\n@@ -462,7 +465,7 @@ block_crypto_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,\n uint64_t sector_size = qcrypto_block_get_sector_size(crypto->block);\n uint64_t payload_offset = qcrypto_block_get_payload_offset(crypto->block);\n \n- assert(!flags);\n+ assert(!(flags & ~BDRV_REQ_FUA));\n assert(payload_offset < INT64_MAX);\n assert(QEMU_IS_ALIGNED(offset, sector_size));\n assert(QEMU_IS_ALIGNED(bytes, sector_size));\n@@ -495,7 +498,7 @@ block_crypto_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,\n qemu_iovec_add(&hd_qiov, cipher_data, cur_bytes);\n \n ret = bdrv_co_pwritev(bs->file, payload_offset + offset + bytes_done,\n- cur_bytes, &hd_qiov, 0);\n+ cur_bytes, &hd_qiov, flags);\n if (ret < 0) {\n goto cleanup;\n }\n","prefixes":["v4","6/6"]}