{"id":819049,"url":"http://patchwork.ozlabs.org/api/patches/819049/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170927083555.16580-9-romain.izard.pro@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170927083555.16580-9-romain.izard.pro@gmail.com>","list_archive_url":null,"date":"2017-09-27T08:35:55","name":"[v3,8/8] tty/serial: atmel: Prevent a warning on suspend","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"1d08c6d3b399a5b0d16c0ea8181b8b41adab48e9","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/?format=json","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170927083555.16580-9-romain.izard.pro@gmail.com/mbox/","series":[{"id":5311,"url":"http://patchwork.ozlabs.org/api/series/5311/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=5311","date":"2017-09-27T08:35:49","name":"Various patches for SAMA5D2 backup mode","version":3,"mbox":"http://patchwork.ozlabs.org/series/5311/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819049/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819049/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"GZxTzdn1\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Tlz6AXFX\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2B7P3LPkz9t3x\n\tfor ;\n\tWed, 27 Sep 2017 18:38:57 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx7ri-00055P-Tg; Wed, 27 Sep 2017 08:38:46 +0000","from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx7pi-0002nw-H3\n\tfor linux-mtd@lists.infradead.org; Wed, 27 Sep 2017 08:36:52 +0000","by mail-wr0-x242.google.com with SMTP id z1so960049wre.1\n\tfor ;\n\tWed, 27 Sep 2017 01:36:21 -0700 (PDT)","from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\tr6sm9699900wrg.40.2017.09.27.01.36.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 01:36:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=95BOGtLjmLLUuYMe82AwExhBEpVtRsLOqLBwb2XvX44=;\n\tb=GZxTzdn17AetvcHtyhFCoiP+gQ\n\tT4F4hiOnFHGWEF3+6eV12fzB5GIDC6v/+kmrkr+lF8317bYMe85Q11ZfYBZiNil6qKmEIbDIt6qPj\n\tetCy4E81hstuzKwxHYuJuikXLEnxbik3JsjLkqUgvdq176Mbs4mXzQPbmuDsA0mKpNJN8xTqSKjC6\n\tsp4qx1lPR7Yqh/wfkVDvXlLoqUQnGvtWV48NuBEQZ6lM4ngR70IhCqreZCsGD+az+88GpcdDIP1Ro\n\tk32WfUfvjO3S5/UCaWnZLzue+ufxzGMMVbBiYCSXFmBr3/LU4ZDqpAPmfSApDO7N636NGBBhZWe1Q\n\tzglvTptw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Kb+eYUn6sUr9qLQ2ec5i4R8VU1m7KosNeKaMrwYeb1w=;\n\tb=Tlz6AXFXXPMIfqEei+I7ZLa4kEb8LRU1sh26niEIcfwzEkR0oig4yveNiW7THbOc9/\n\tjXK7eEjDISoQPmlg5Hq7o1cCgVpB2w5mMYgCq50NRH4OeIOp+q4YoJ5zpTDMqX1DquBL\n\tRWBWsPrWrCppR0QitLvkmvmk3C7MJhmDkTlqLbSrIyw1Ff8oCUwosMvGAaNaqsRkV55y\n\tHotMJM7yJMACz2sccGzY9npKDC16YDqe15AjSER2U0nxcOwaI7ZqJOc6Chw6o3qBQylA\n\tqfmig/9CelWJb5buRijqP+XzFWm7p/lddxdG1PISWPah8A5bs8BPKTF1EofH7jk1J9CG\n\tDgUg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Kb+eYUn6sUr9qLQ2ec5i4R8VU1m7KosNeKaMrwYeb1w=;\n\tb=eLyageDrRdu07mw2Yl/iznXCT7YSM6AldpQuQ23ZpNO13rj6DHc1Aa14FCDYKp9D0s\n\t8EyKvoXHIn/NLT8Z2PQd1HEqRewdMSUIn7SwqWPHrX/8xIAk15PWyOfMXxB06UqtwFrw\n\t407Ku1tnfiuNwFcdA1Mqt9Iu8PYrQ1IMqV3dPptxaEiQs/82fiVnBslpNBs295YDJmEr\n\tGcU7p8GRh0mJ9Gk3THRSge/dor6ptHSijrJHh/VsXMLFY5BqRTF7LlUfdqFyphxBvaaP\n\tLsYXNSIOf1TasVojlauMSQJux1McU9s/PQuZhLcGMl7/SJ+PubEd59AdlyrgROOtEFyM\n\tjmAg==","X-Gm-Message-State":"AHPjjUjG94rN3sG76RE6UjthnT7bHDWI8YBTNXD8Q83wQwneOsK/4cGu\n\tBb2bfKlnI3M0tmSa9tUm468=","X-Google-Smtp-Source":"AOwi7QCtoqZvxLg5YxbMyt35JhGrsdY+sk7ymi2T0qYjlAwuPZHSNgdCL2CsLOfdOJYe+lkx5Kd8/Q==","X-Received":"by 10.223.157.11 with SMTP id k11mr721633wre.252.1506501380557; \n\tWed, 27 Sep 2017 01:36:20 -0700 (PDT)","From":"Romain Izard ","To":"Boris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd , Lee Jones ,\n\tWenyou Yang , Josh Wu , \n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tJiri Slaby , Alan Stern , \n\tLudovic Desroches ,\n\tNicolas Ferre ,\n\tAlexandre Belloni ","Subject":"[PATCH v3 8/8] tty/serial: atmel: Prevent a warning on suspend","Date":"Wed, 27 Sep 2017 10:35:55 +0200","Message-Id":"<20170927083555.16580-9-romain.izard.pro@gmail.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170927083555.16580-1-romain.izard.pro@gmail.com>","References":"<20170927083555.16580-1-romain.izard.pro@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_013643_335118_4422645E ","X-CRM114-Status":"GOOD ( 14.87 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (romain.izard.pro[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, Romain Izard , \n\tlinux-clk@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"The atmel serial port driver reported the following warning on suspend:\natmel_usart f8020000.serial: ttyS1: Unable to drain transmitter\n\nAs the ATMEL_US_TXEMPTY status bit in ATMEL_US_CSR is always cleared\nwhen the transmitter is disabled, we need to know the transmitter's\nstate to return the real fifo state. And as ATMEL_US_CR is write-only,\nit is necessary to save the state of the transmitter in a local\nvariable, and update the variable when TXEN and TXDIS is written in\nATMEL_US_CR.\n\nAfter those changes, atmel_tx_empty can return \"empty\" on suspend, the\nwarning in uart_suspend_port disappears, and suspending is 20ms shorter\nfor each enabled Atmel serial port.\n\nSigned-off-by: Romain Izard \nTested-by: Nicolas Ferre \nAcked-by: Nicolas Ferre \nAcked-by: Richard Genoud \n---\n drivers/tty/serial/atmel_serial.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c\nindex 7551cab438ff..ce45b4ada0bf 100644\n--- a/drivers/tty/serial/atmel_serial.c\n+++ b/drivers/tty/serial/atmel_serial.c\n@@ -171,6 +171,7 @@ struct atmel_uart_port {\n \tbool\t\t\thas_hw_timer;\n \tstruct timer_list\tuart_timer;\n \n+\tbool\t\t\ttx_stopped;\n \tbool\t\t\tsuspended;\n \tunsigned int\t\tpending;\n \tunsigned int\t\tpending_status;\n@@ -380,6 +381,10 @@ static int atmel_config_rs485(struct uart_port *port,\n */\n static u_int atmel_tx_empty(struct uart_port *port)\n {\n+\tstruct atmel_uart_port *atmel_port = to_atmel_uart_port(port);\n+\n+\tif (atmel_port->tx_stopped)\n+\t\treturn TIOCSER_TEMT;\n \treturn (atmel_uart_readl(port, ATMEL_US_CSR) & ATMEL_US_TXEMPTY) ?\n \t\tTIOCSER_TEMT :\n \t\t0;\n@@ -485,6 +490,7 @@ static void atmel_stop_tx(struct uart_port *port)\n \t * is fully transmitted.\n \t */\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXDIS);\n+\tatmel_port->tx_stopped = true;\n \n \t/* Disable interrupts */\n \tatmel_uart_writel(port, ATMEL_US_IDR, atmel_port->tx_done_mask);\n@@ -521,6 +527,7 @@ static void atmel_start_tx(struct uart_port *port)\n \n \t/* re-enable the transmitter */\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN);\n+\tatmel_port->tx_stopped = false;\n }\n \n /*\n@@ -1866,6 +1873,7 @@ static int atmel_startup(struct uart_port *port)\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_RSTSTA | ATMEL_US_RSTRX);\n \t/* enable xmit & rcvr */\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN | ATMEL_US_RXEN);\n+\tatmel_port->tx_stopped = false;\n \n \tsetup_timer(&atmel_port->uart_timer,\n \t\t\tatmel_uart_timer_callback,\n@@ -2122,6 +2130,7 @@ static void atmel_set_termios(struct uart_port *port, struct ktermios *termios,\n \n \t/* disable receiver and transmitter */\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXDIS | ATMEL_US_RXDIS);\n+\tatmel_port->tx_stopped = true;\n \n \t/* mode */\n \tif (port->rs485.flags & SER_RS485_ENABLED) {\n@@ -2207,6 +2216,7 @@ static void atmel_set_termios(struct uart_port *port, struct ktermios *termios,\n \tatmel_uart_writel(port, ATMEL_US_BRGR, quot);\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_RSTSTA | ATMEL_US_RSTRX);\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN | ATMEL_US_RXEN);\n+\tatmel_port->tx_stopped = false;\n \n \t/* restore interrupts */\n \tatmel_uart_writel(port, ATMEL_US_IER, imr);\n@@ -2450,6 +2460,7 @@ static void atmel_console_write(struct console *co, const char *s, u_int count)\n \n \t/* Make sure that tx path is actually able to send characters */\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN);\n+\tatmel_port->tx_stopped = false;\n \n \tuart_console_write(port, s, count, atmel_console_putchar);\n \n@@ -2511,6 +2522,7 @@ static int __init atmel_console_setup(struct console *co, char *options)\n {\n \tint ret;\n \tstruct uart_port *port = &atmel_ports[co->index].uart;\n+\tstruct atmel_uart_port *atmel_port = to_atmel_uart_port(port);\n \tint baud = 115200;\n \tint bits = 8;\n \tint parity = 'n';\n@@ -2528,6 +2540,7 @@ static int __init atmel_console_setup(struct console *co, char *options)\n \tatmel_uart_writel(port, ATMEL_US_IDR, -1);\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_RSTSTA | ATMEL_US_RSTRX);\n \tatmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN | ATMEL_US_RXEN);\n+\tatmel_port->tx_stopped = false;\n \n \tif (options)\n \t\tuart_parse_options(options, &baud, &parity, &bits, &flow);\n","prefixes":["v3","8/8"]}