{"id":819025,"url":"http://patchwork.ozlabs.org/api/patches/819025/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506500637-13881-3-git-send-email-jasowang@redhat.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506500637-13881-3-git-send-email-jasowang@redhat.com>","list_archive_url":null,"date":"2017-09-27T08:23:56","name":"[net-next,2/3] tun: introduce ioctls to set and get steering policies","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"c75e27189c4a39b09a0d91b04a7692f3c28b7bbe","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/?format=json","name":"Jason Wang","email":"jasowang@redhat.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506500637-13881-3-git-send-email-jasowang@redhat.com/mbox/","series":[{"id":5306,"url":"http://patchwork.ozlabs.org/api/series/5306/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=5306","date":"2017-09-27T08:23:56","name":"support changing steering policies in tuntap","version":1,"mbox":"http://patchwork.ozlabs.org/series/5306/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/819025/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/819025/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jasowang@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y29pj32Kwz9t3B\n\tfor ;\n\tWed, 27 Sep 2017 18:24:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752386AbdI0IYO (ORCPT );\n\tWed, 27 Sep 2017 04:24:14 -0400","from mx1.redhat.com ([209.132.183.28]:55194 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752197AbdI0IYL (ORCPT );\n\tWed, 27 Sep 2017 04:24:11 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1C665A0C11;\n\tWed, 27 Sep 2017 08:24:11 +0000 (UTC)","from jason-ThinkPad-T450s.redhat.com (ovpn-12-60.pek2.redhat.com\n\t[10.72.12.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D871677C97;\n\tWed, 27 Sep 2017 08:24:08 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1C665A0C11","From":"Jason Wang ","To":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Cc":"mst@redhat.com, Jason Wang ","Subject":"[PATCH net-next 2/3] tun: introduce ioctls to set and get steering\n\tpolicies","Date":"Wed, 27 Sep 2017 16:23:56 +0800","Message-Id":"<1506500637-13881-3-git-send-email-jasowang@redhat.com>","In-Reply-To":"<1506500637-13881-1-git-send-email-jasowang@redhat.com>","References":"<1506500637-13881-1-git-send-email-jasowang@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 27 Sep 2017 08:24:11 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This patch introduces new ioctl for change packet steering policy for\ntun. Only automatic flow steering is supported, more policies will\ncome.\n\nSigned-off-by: Jason Wang \n---\n drivers/net/tun.c | 35 ++++++++++++++++++++++++++++++++++-\n include/uapi/linux/if_tun.h | 7 +++++++\n 2 files changed, 41 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/tun.c b/drivers/net/tun.c\nindex de83e72..1106521 100644\n--- a/drivers/net/tun.c\n+++ b/drivers/net/tun.c\n@@ -122,7 +122,8 @@ do {\t\t\t\t\t\t\t\t\\\n #define TUN_VNET_BE 0x40000000\n \n #define TUN_FEATURES (IFF_NO_PI | IFF_ONE_QUEUE | IFF_VNET_HDR | \\\n-\t\t IFF_MULTI_QUEUE | IFF_NAPI | IFF_NAPI_FRAGS)\n+\t\t IFF_MULTI_QUEUE | IFF_NAPI | IFF_NAPI_FRAGS | \\\n+\t\t IFF_MULTI_STEERING)\n \n #define GOODCOPY_LEN 128\n \n@@ -2506,6 +2507,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,\n \tunsigned int ifindex;\n \tint le;\n \tint ret;\n+\tunsigned int steering;\n \n \tif (cmd == TUNSETIFF || cmd == TUNSETQUEUE || _IOC_TYPE(cmd) == SOCK_IOC_TYPE) {\n \t\tif (copy_from_user(&ifr, argp, ifreq_len))\n@@ -2764,6 +2766,37 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,\n \t\tret = 0;\n \t\tbreak;\n \n+\tcase TUNSETSTEERING:\n+\t\tret = -EFAULT;\n+\t\tif (copy_from_user(&steering, argp, sizeof(steering)))\n+\t\t\tbreak;\n+\t\tret = 0;\n+\t\tswitch (steering) {\n+\t\tcase TUN_STEERING_AUTOMQ:\n+\t\t\ttun->steering_ops = &tun_automq_ops;\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tret = -EFAULT;\n+\t\t}\n+\t\tbreak;\n+\n+\tcase TUNGETSTEERING:\n+\t\tret = 0;\n+\t\tif (tun->steering_ops == &tun_automq_ops)\n+\t\t\tsteering = TUN_STEERING_AUTOMQ;\n+\t\telse\n+\t\t\tBUG();\n+\t\tif (copy_to_user(argp, &steering, sizeof(steering)))\n+\t\t\tret = -EFAULT;\n+\t\tbreak;\n+\n+\tcase TUNGETSTEERINGFEATURES:\n+\t\tret = 0;\n+\t\tsteering = TUN_STEERING_AUTOMQ;\n+\t\tif (copy_to_user(argp, &steering, sizeof(steering)))\n+\t\t\tret = -EFAULT;\n+\t\tbreak;\n+\n \tdefault:\n \t\tret = -EINVAL;\n \t\tbreak;\ndiff --git a/include/uapi/linux/if_tun.h b/include/uapi/linux/if_tun.h\nindex 365ade5..109760e 100644\n--- a/include/uapi/linux/if_tun.h\n+++ b/include/uapi/linux/if_tun.h\n@@ -56,6 +56,9 @@\n */\n #define TUNSETVNETBE _IOW('T', 222, int)\n #define TUNGETVNETBE _IOR('T', 223, int)\n+#define TUNSETSTEERING _IOW('T', 224, unsigned int)\n+#define TUNGETSTEERING _IOR('T', 225, unsigned int)\n+#define TUNGETSTEERINGFEATURES _IOR('T', 226, unsigned int)\n \n /* TUNSETIFF ifr flags */\n #define IFF_TUN\t\t0x0001\n@@ -70,6 +73,8 @@\n #define IFF_MULTI_QUEUE 0x0100\n #define IFF_ATTACH_QUEUE 0x0200\n #define IFF_DETACH_QUEUE 0x0400\n+#define IFF_MULTI_STEERING 0x2000\n+\n /* read-only flag */\n #define IFF_PERSIST\t0x0800\n #define IFF_NOFILTER\t0x1000\n@@ -106,4 +111,6 @@ struct tun_filter {\n \t__u8 addr[0][ETH_ALEN];\n };\n \n+#define TUN_STEERING_AUTOMQ 0x01 /* Automatic flow steering */\n+\n #endif /* _UAPI__IF_TUN_H */\n","prefixes":["net-next","2/3"]}