{"id":818830,"url":"http://patchwork.ozlabs.org/api/patches/818830/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170926211535.21273-4-vivien.didelot@savoirfairelinux.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170926211535.21273-4-vivien.didelot@savoirfairelinux.com>","list_archive_url":null,"date":"2017-09-26T21:15:33","name":"[net-next,3/5] net: dsa: use phy_ethtool_get_link_ksettings","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"8717d3561c3a913586c120ea4e1d5d8d3e4e9904","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/?format=json","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170926211535.21273-4-vivien.didelot@savoirfairelinux.com/mbox/","series":[{"id":5231,"url":"http://patchwork.ozlabs.org/api/series/5231/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=5231","date":"2017-09-26T21:15:33","name":"net: dsa: use generic slave phydev","version":1,"mbox":"http://patchwork.ozlabs.org/series/5231/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818830/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818830/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1v3R64vYz9sRV\n\tfor ;\n\tWed, 27 Sep 2017 07:19:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S937417AbdIZVT3 (ORCPT );\n\tTue, 26 Sep 2017 17:19:29 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:41200 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S937221AbdIZVTZ (ORCPT\n\t); Tue, 26 Sep 2017 17:19:25 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id B8AC79C2981;\n\tTue, 26 Sep 2017 17:19:24 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id U8im2LSmV1IH; Tue, 26 Sep 2017 17:19:23 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 28C389C2D89;\n\tTue, 26 Sep 2017 17:19:23 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id rB3XhQD-3KYK; Tue, 26 Sep 2017 17:19:22 -0400 (EDT)","from weeman.mtl.sfl (unknown [192.168.49.104])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id E58DB9C2DA1;\n\tTue, 26 Sep 2017 17:19:22 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" ,\n\tFlorian Fainelli , Andrew Lunn ,\n\tVivien Didelot ","Subject":"[PATCH net-next 3/5] net: dsa: use phy_ethtool_get_link_ksettings","Date":"Tue, 26 Sep 2017 17:15:33 -0400","Message-Id":"<20170926211535.21273-4-vivien.didelot@savoirfairelinux.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use phy_ethtool_get_link_ksettings now that dsa_slave_get_link_ksettings\ndoes exactly the same.\n\nSigned-off-by: Vivien Didelot \n---\n net/dsa/slave.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)","diff":"diff --git a/net/dsa/slave.c b/net/dsa/slave.c\nindex 4ea1c6eb0da8..bb0f64f47ae7 100644\n--- a/net/dsa/slave.c\n+++ b/net/dsa/slave.c\n@@ -420,17 +420,6 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev)\n }\n \n /* ethtool operations *******************************************************/\n-static int\n-dsa_slave_get_link_ksettings(struct net_device *dev,\n-\t\t\t struct ethtool_link_ksettings *cmd)\n-{\n-\tif (!dev->phydev)\n-\t\treturn -ENODEV;\n-\n-\tphy_ethtool_ksettings_get(dev->phydev, cmd);\n-\n-\treturn 0;\n-}\n \n static int\n dsa_slave_set_link_ksettings(struct net_device *dev,\n@@ -921,8 +910,8 @@ static const struct ethtool_ops dsa_slave_ethtool_ops = {\n \t.get_wol\t\t= dsa_slave_get_wol,\n \t.set_eee\t\t= dsa_slave_set_eee,\n \t.get_eee\t\t= dsa_slave_get_eee,\n-\t.get_link_ksettings\t= dsa_slave_get_link_ksettings,\n \t.set_link_ksettings\t= dsa_slave_set_link_ksettings,\n+\t.get_link_ksettings\t= phy_ethtool_get_link_ksettings,\n \t.get_rxnfc\t\t= dsa_slave_get_rxnfc,\n \t.set_rxnfc\t\t= dsa_slave_set_rxnfc,\n };\n","prefixes":["net-next","3/5"]}