{"id":818793,"url":"http://patchwork.ozlabs.org/api/patches/818793/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170926192142.42308-6-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170926192142.42308-6-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-26T19:21:33","name":"[U-Boot,v2,05/14] mtdparts: Correct use of debug()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"453b3bd54658983b0998cd8dfc9c528b65f90a43","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170926192142.42308-6-sjg@chromium.org/mbox/","series":[{"id":5217,"url":"http://patchwork.ozlabs.org/api/series/5217/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=5217","date":"2017-09-26T19:21:28","name":"log: Add a new logging feature","version":2,"mbox":"http://patchwork.ozlabs.org/series/5217/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818793/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818793/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"HZ2vN7S+\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1rZ16Xnvz9t3m\n\tfor ;\n\tWed, 27 Sep 2017 05:27:21 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4AA0FC21F58; Tue, 26 Sep 2017 19:23:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 650D9C21F5B;\n\tTue, 26 Sep 2017 19:22:39 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 48D20C21F38; Tue, 26 Sep 2017 19:22:19 +0000 (UTC)","from mail-oi0-f43.google.com (mail-oi0-f43.google.com\n\t[209.85.218.43])\n\tby lists.denx.de (Postfix) with ESMTPS id 5AC82C21E3B\n\tfor ; Tue, 26 Sep 2017 19:22:16 +0000 (UTC)","by mail-oi0-f43.google.com with SMTP id b1so13498230oih.4\n\tfor ; Tue, 26 Sep 2017 12:22:16 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm1587272otb.75.2017.09.26.12.22.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 12:22:14 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 4BB69140573; Tue, 26 Sep 2017 13:22:13 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=GrH2sf8EvC07ldo5S5Y9c6G/pJOPv/34OlOWGB4hNiQ=;\n\tb=HZ2vN7S+oh2ULE/87R0/zykBbEtKEn7B9mHWHupf5kqhHunDUb1yyky85gXGU629pD\n\tN47ei7gZKkJjGOHVp3uHjXWP53YM8BooMXAjV3+LQfj5dUfQHstKIYxkOM8R1+8BGDoO\n\tTXBgWLv7kVbEBrEN9b44VgAgPkhka402K94TVnlTHD6Y5oF4OM8qMamvhA9ijriruwmc\n\tnfis8yJ7vATFSionQeF6W+a4sjkm9jUPhGurco+Aj/1DgVMpmc7OCoLa7bApA9YOdsRf\n\tjollG7+ElHXYcb5pr6a4S7AzB0xhMui/y6ge7KNYZaEMTVFUh3YtK9nbYcQOseDMrmo3\n\t3cUQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=GrH2sf8EvC07ldo5S5Y9c6G/pJOPv/34OlOWGB4hNiQ=;\n\tb=HRsan7L4pPsUxq4Zdotz98ZA494c5HtUed5jcFqsK1H6pbtw1VpXUJ2WYx882G5lW+\n\tnNFLehC5wIw9EsaAXKXr1KGQvlTfalCpGQvECMTFJ/+3f/ssaPlh4PCf0BqTZKsVZZld\n\t2/+kdJQcqhEZXlZfHZljD2t7EzqNJFUlsb7WneHWdW37Lr16gtSyRyWMt6vifa0Tnofu\n\tycugJcvO06OradYYIRU1SvHcnziL4En0rq6AflEnYwvaFvbwS5LlphDBeOFyRa9ZbhW7\n\ttTGNgLogJ1ukE7maL5yV06AyruyCYzWiTckDo2uCFN8cJqrDxBEGe/jqBE5riK+9EZJS\n\tn3HA==","X-Gm-Message-State":"AHPjjUj0jjqkFFXFV081j1AblOcnDcZHaasJ0QjalRmEg1WEkl+u+OZD\n\t81YPBN6m79vJ9lpl53MBpWbrjQ==","X-Google-Smtp-Source":"AOwi7QACqyMduhuLLgAA5urJ9DLpiDXJROwULOhQt8/kAOpRgCB+9rfMIGVU8ICGgwJCdPymwMmQ0Q==","X-Received":"by 10.202.214.70 with SMTP id n67mr12611234oig.207.1506453734862;\n\tTue, 26 Sep 2017 12:22:14 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Tue, 26 Sep 2017 13:21:33 -0600","Message-Id":"<20170926192142.42308-6-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.992.g2c7b836f3a-goog","In-Reply-To":"<20170926192142.42308-1-sjg@chromium.org>","References":"<20170926192142.42308-1-sjg@chromium.org>","Cc":"Tom Rini ","Subject":"[U-Boot] [PATCH v2 05/14] mtdparts: Correct use of debug()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The debug() macro now evaluates its expression so does not need #ifdef\nprotection. In fact the current code causes a warning with the new log\nimplementation. Adjust the code to fix this.\n\nSigned-off-by: Simon Glass \nReviewed-by: Bin Meng \n---\n\nChanges in v2: None\n\n cmd/mtdparts.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/cmd/mtdparts.c b/cmd/mtdparts.c\nindex 3275eb919b..13677faf4b 100644\n--- a/cmd/mtdparts.c\n+++ b/cmd/mtdparts.c\n@@ -873,15 +873,12 @@ static int device_parse(const char *const mtd_dev, const char **ret, struct mtd_\n \t\treturn 1;\n \t}\n \n-#ifdef DEBUG\n \tpend = strchr(p, ';');\n-#endif\n \tdebug(\"dev type = %d (%s), dev num = %d, mtd-id = %s\\n\",\n \t\t\tid->type, MTD_DEV_TYPE(id->type),\n \t\t\tid->num, id->mtd_id);\n \tdebug(\"parsing partitions %.*s\\n\", (int)(pend ? pend - p : strlen(p)), p);\n \n-\n \t/* parse partitions */\n \tnum_parts = 0;\n \n","prefixes":["U-Boot","v2","05/14"]}