{"id":818791,"url":"http://patchwork.ozlabs.org/api/patches/818791/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170926192142.42308-4-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170926192142.42308-4-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-26T19:21:31","name":"[U-Boot,v2,03/14] Revert \"sandbox: Drop special case console code for sandbox\"","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6a1fe0de25b13d5eb5bed3e7d400c1cbd58cb2e2","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170926192142.42308-4-sjg@chromium.org/mbox/","series":[{"id":5217,"url":"http://patchwork.ozlabs.org/api/series/5217/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=5217","date":"2017-09-26T19:21:28","name":"log: Add a new logging feature","version":2,"mbox":"http://patchwork.ozlabs.org/series/5217/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818791/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818791/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"k6ibhwru\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1rWb4c1tz9t3F\n\tfor ;\n\tWed, 27 Sep 2017 05:25:15 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 43452C21F44; Tue, 26 Sep 2017 19:23:52 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 37B46C21EFF;\n\tTue, 26 Sep 2017 19:22:47 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 98A76C21EFF; Tue, 26 Sep 2017 19:22:12 +0000 (UTC)","from mail-oi0-f47.google.com (mail-oi0-f47.google.com\n\t[209.85.218.47])\n\tby lists.denx.de (Postfix) with ESMTPS id 491A4C21F3B\n\tfor ; Tue, 26 Sep 2017 19:22:12 +0000 (UTC)","by mail-oi0-f47.google.com with SMTP id b184so13510873oii.13\n\tfor ; Tue, 26 Sep 2017 12:22:12 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\tl184sm10202812oig.54.2017.09.26.12.22.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 12:22:09 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 03605140573; Tue, 26 Sep 2017 13:22:09 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Gp55DWCWtTuV74o34XF8MvucaV+hJ0UDg+vpJ/mAvi4=;\n\tb=k6ibhwruUFkGMqO6ckvBZhPvxHuQR5UHyUiXfjvjpPKLc6jsACxC8Jh+TrgFvuVDuY\n\t6L+jIb++8lB33l1UdS//LtHxtRgfEciGi0RNjmYXKjsXbPiI4FwnG5Dy2zEVvnWqnGn5\n\t7q8dAi8LHrOzxWj5dhAXuiauxLVNn9jYOlK/lrT8NcoEhk9+OL6xC5Mj+BbKzZ57P5TA\n\tPgAJPdxt2gmaDeskyaJnZuxvykuqhhnfQH9J+wK9mHknVQzZieiO1gGo9RIUCdT07fm+\n\tosI9dPDZPkzH+C0bdigqpdjm3oC0y/Iizg+d6d3yfGKDbcAz3UDCh1a8dK7S0aXtB0Sf\n\tLXhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=Gp55DWCWtTuV74o34XF8MvucaV+hJ0UDg+vpJ/mAvi4=;\n\tb=R8TGSZwPDTL9K8mL4Y4WoF58NwVlR2jP6ewqbL+YIhzbxFC4Se0bI/LUjFKt//f49P\n\tsgUdoBUla/GjbzFx9qSLKqXzlCjG/mvpwtt+GYevG7Pidh6y9TUsK7mq8FSiOzQNgBuM\n\tU893ijTGhq122yjufEk9i8Zp9mBIemKntxxQrh4mP3sOzyP+EggwEbWYvb669sht7LVO\n\tNTuv6HqjFDSgTa2UHcSQ7VoMp4ZXs9V5BxLVpPEkQKG4T/u+wZPCAd43ZvJZjthluy1g\n\t8GvMONsjc4frCOcmlzES3KzTLq+P1fUsnmHZ3kCjsSAw7VGaHaGVi1hGjLY1E94LxgQR\n\tKmFQ==","X-Gm-Message-State":"AHPjjUjnIgOlLR1xO5TaR64Qm2klkW5h01f0cSGY4ysLrYtE6WpTbdpN\n\tShYXkxg1mzLOvlooDaV5NyrEqg==","X-Google-Smtp-Source":"AOwi7QAEtqv9uviAcmxBfxL0cI5n0HIlnZlcI562ivyzL4E11pBQRWKhmf/9GZpE8lxNUx0yLEgdhQ==","X-Received":"by 10.157.20.99 with SMTP id h90mr2968505oth.219.1506453730858; \n\tTue, 26 Sep 2017 12:22:10 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Tue, 26 Sep 2017 13:21:31 -0600","Message-Id":"<20170926192142.42308-4-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.992.g2c7b836f3a-goog","In-Reply-To":"<20170926192142.42308-1-sjg@chromium.org>","References":"<20170926192142.42308-1-sjg@chromium.org>","Cc":"Tom Rini ","Subject":"[U-Boot] [PATCH v2 03/14] Revert \"sandbox: Drop special case\n\tconsole code for sandbox\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"While sandbox works OK without the special-case code, it does result in\nconsole output being stored in the pre-console buffer while sandbox starts\nup. If there is a crash or a problem then there is no indication of what\nis going on.\n\nFor ease of debugging it seems better to revert this change also.\n\nThis reverts commit d8c6fb8cedbc35eee27730a7fa544e499b3c81cc.\n\nSigned-off-by: Simon Glass \n---\n\nChanges in v2: None\n\n common/console.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/common/console.c b/common/console.c\nindex f83528ca60..18457aab3c 100644\n--- a/common/console.c\n+++ b/common/console.c\n@@ -482,6 +482,13 @@ static inline void print_pre_console_buffer(int flushpoint) {}\n \n void putc(const char c)\n {\n+#ifdef CONFIG_SANDBOX\n+\t/* sandbox can send characters to stdout before it has a console */\n+\tif (!gd || !(gd->flags & GD_FLG_SERIAL_READY)) {\n+\t\tos_putc(c);\n+\t\treturn;\n+\t}\n+#endif\n #ifdef CONFIG_DEBUG_UART\n \t/* if we don't have a console yet, use the debug UART */\n \tif (!gd || !(gd->flags & GD_FLG_SERIAL_READY)) {\n","prefixes":["U-Boot","v2","03/14"]}