{"id":818775,"url":"http://patchwork.ozlabs.org/api/patches/818775/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926183318.12995-4-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170926183318.12995-4-david@redhat.com>","list_archive_url":null,"date":"2017-09-26T18:33:15","name":"[v1,3/6] s390x/tcg: make lura(g) use the new _real mmu.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b94f07803804583788097b2c4bc85cb8713d1655","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170926183318.12995-4-david@redhat.com/mbox/","series":[{"id":5209,"url":"http://patchwork.ozlabs.org/api/series/5209/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5209","date":"2017-09-26T18:33:12","name":"s390x/tcg: fix some accesses using low address","version":1,"mbox":"http://patchwork.ozlabs.org/series/5209/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818775/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818775/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1qQ36bVVz9t3R\n\tfor ;\n\tWed, 27 Sep 2017 04:35:23 +1000 (AEST)","from localhost ([::1]:50672 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwuhW-0005Sc-1N\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 14:35:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45149)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwufj-0004Pf-Ec\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwufi-0003TY-Ks\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:31 -0400","from mx1.redhat.com ([209.132.183.28]:47914)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwufi-0003TN-FD\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:30 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7A21AC0587E6;\n\tTue, 26 Sep 2017 18:33:29 +0000 (UTC)","from t460s.redhat.com (ovpn-117-152.ams2.redhat.com\n\t[10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B5E6960841;\n\tTue, 26 Sep 2017 18:33:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7A21AC0587E6","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Tue, 26 Sep 2017 20:33:15 +0200","Message-Id":"<20170926183318.12995-4-david@redhat.com>","In-Reply-To":"<20170926183318.12995-1-david@redhat.com>","References":"<20170926183318.12995-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 26 Sep 2017 18:33:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v1 3/6] s390x/tcg: make lura(g) use the new\n\t_real mmu.","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, David Hildenbrand , cohuck@redhat.com,\n\tAlexander Graf ,\n\tChristian Borntraeger ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Looks like, lurag was not loading 64bit but only 32bit.\n\nAs we properly handle the return address now, we can drop\npotential_page_fault().\n\nSigned-off-by: David Hildenbrand \n---\n target/s390x/mem_helper.c | 7 ++-----\n target/s390x/translate.c | 2 --\n 2 files changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c\nindex ec4760e390..f8525e05b3 100644\n--- a/target/s390x/mem_helper.c\n+++ b/target/s390x/mem_helper.c\n@@ -1973,16 +1973,13 @@ void HELPER(purge)(CPUS390XState *env)\n /* load using real address */\n uint64_t HELPER(lura)(CPUS390XState *env, uint64_t addr)\n {\n- CPUState *cs = CPU(s390_env_get_cpu(env));\n \n- return (uint32_t)ldl_phys(cs->as, wrap_address(env, addr));\n+ return cpu_ldl_real_ra(env, wrap_address(env, addr), GETPC());\n }\n \n uint64_t HELPER(lurag)(CPUS390XState *env, uint64_t addr)\n {\n- CPUState *cs = CPU(s390_env_get_cpu(env));\n-\n- return ldq_phys(cs->as, wrap_address(env, addr));\n+ return cpu_ldq_real_ra(env, wrap_address(env, addr), GETPC());\n }\n \n /* store using real address */\ndiff --git a/target/s390x/translate.c b/target/s390x/translate.c\nindex 5abd34fb34..d0ce14d120 100644\n--- a/target/s390x/translate.c\n+++ b/target/s390x/translate.c\n@@ -2915,7 +2915,6 @@ static ExitStatus op_lpq(DisasContext *s, DisasOps *o)\n static ExitStatus op_lura(DisasContext *s, DisasOps *o)\n {\n check_privileged(s);\n- potential_page_fault(s);\n gen_helper_lura(o->out, cpu_env, o->in2);\n return NO_EXIT;\n }\n@@ -2923,7 +2922,6 @@ static ExitStatus op_lura(DisasContext *s, DisasOps *o)\n static ExitStatus op_lurag(DisasContext *s, DisasOps *o)\n {\n check_privileged(s);\n- potential_page_fault(s);\n gen_helper_lurag(o->out, cpu_env, o->in2);\n return NO_EXIT;\n }\n","prefixes":["v1","3/6"]}