{"id":818711,"url":"http://patchwork.ozlabs.org/api/patches/818711/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/f6221aa560d474bd822040ecb28ee4ea973f1ca4.1506437915.git.joseph.salisbury@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-26T15:19:00","name":"[SRU,Zesty,1/1] md: MD_CLOSING needs to be cleared after called md_set_readonly or do_md_stop","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0629a4f1b6b0f50ce4f3b58187282d6f6d80c50a","submitter":{"id":7793,"url":"http://patchwork.ozlabs.org/api/people/7793/?format=json","name":"Joseph Salisbury","email":"joseph.salisbury@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/f6221aa560d474bd822040ecb28ee4ea973f1ca4.1506437915.git.joseph.salisbury@canonical.com/mbox/","series":[{"id":5165,"url":"http://patchwork.ozlabs.org/api/series/5165/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=5165","date":"2017-09-26T15:18:59","name":"md: MD_CLOSING needs to be cleared after called md_set_readonly or do_md_stop","version":1,"mbox":"http://patchwork.ozlabs.org/series/5165/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818711/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818711/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1l3h4g5Yz9tXK;\n\tWed, 27 Sep 2017 01:19:12 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dwrdX-0007cF-Fk; Tue, 26 Sep 2017 15:19:03 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dwrdW-0007Vq-48\n\tfor kernel-team@lists.ubuntu.com; Tue, 26 Sep 2017 15:19:02 +0000","from 1.general.jsalisbury.us.vpn ([10.172.67.212] helo=salisbury)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dwrdV-0003i2-Nq\n\tfor kernel-team@lists.ubuntu.com; Tue, 26 Sep 2017 15:19:01 +0000","by salisbury (Postfix, from userid 1000)\n\tid 392347E2853; Tue, 26 Sep 2017 11:19:00 -0400 (EDT)"],"From":"Joseph Salisbury ","To":"kernel-team@lists.ubuntu.com","Subject":"[SRU][Zesty][PATCH 1/1] md: MD_CLOSING needs to be cleared after\n\tcalled md_set_readonly or do_md_stop","Date":"Tue, 26 Sep 2017 11:19:00 -0400","Message-Id":"","X-Mailer":"git-send-email 2.7.4","In-Reply-To":["",""],"References":["",""],"X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: NeilBrown \n\nBugLink: http://bugs.launchpad.net/bugs/1706243\n\nif called md_set_readonly and set MD_CLOSING bit, the mddev cannot\nbe opened any more due to the MD_CLOING bit wasn't cleared. Thus it\nneeds to be cleared in md_ioctl after any call to md_set_readonly()\nor do_md_stop().\n\nSigned-off-by: NeilBrown \nFixes: af8d8e6f0315 (\"md: changes for MD_STILL_CLOSED flag\")\nCc: stable@vger.kernel.org (v4.9+)\nSigned-off-by: Zhilong Liu \nSigned-off-by: Shaohua Li \n(cherry picked from commit 065e519e71b2c1f41936cce75b46b5ab34adb588)\nSigned-off-by: Joseph Salisbury \n---\n drivers/md/md.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/drivers/md/md.c b/drivers/md/md.c\nindex 01175da..643920c 100644\n--- a/drivers/md/md.c\n+++ b/drivers/md/md.c\n@@ -6787,6 +6787,7 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n \tvoid __user *argp = (void __user *)arg;\n \tstruct mddev *mddev = NULL;\n \tint ro;\n+\tbool did_set_md_closing = false;\n \n \tif (!md_ioctl_valid(cmd))\n \t\treturn -ENOTTY;\n@@ -6876,7 +6877,9 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n \t\t\terr = -EBUSY;\n \t\t\tgoto out;\n \t\t}\n+\t\tWARN_ON_ONCE(test_bit(MD_CLOSING, &mddev->flags));\n \t\tset_bit(MD_CLOSING, &mddev->flags);\n+\t\tdid_set_md_closing = true;\n \t\tmutex_unlock(&mddev->open_mutex);\n \t\tsync_blockdev(bdev);\n \t}\n@@ -7069,6 +7072,8 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n \t\tmddev->hold_active = 0;\n \tmddev_unlock(mddev);\n out:\n+\tif(did_set_md_closing)\n+\t\tclear_bit(MD_CLOSING, &mddev->flags);\n \treturn err;\n }\n #ifdef CONFIG_COMPAT\n","prefixes":["SRU","Zesty","1/1"]}