{"id":818627,"url":"http://patchwork.ozlabs.org/api/patches/818627/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1506429324-10416-2-git-send-email-antonio.fischetti@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506429324-10416-2-git-send-email-antonio.fischetti@intel.com>","list_archive_url":null,"date":"2017-09-26T12:35:21","name":"[ovs-dev,v2,1/4] dpctl: Add a comment to functions retrieving the datapath name.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"33ef9fd65dbf29db46a603e5b50020424cca1f6a","submitter":{"id":68178,"url":"http://patchwork.ozlabs.org/api/people/68178/?format=json","name":"Fischetti, Antonio","email":"antonio.fischetti@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1506429324-10416-2-git-send-email-antonio.fischetti@intel.com/mbox/","series":[{"id":5130,"url":"http://patchwork.ozlabs.org/api/series/5130/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=5130","date":"2017-09-26T12:35:20","name":"Conntrack: add commands to r/w CT parameters.","version":2,"mbox":"http://patchwork.ozlabs.org/series/5130/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818627/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818627/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1gRc2ZbXz9s83\n\tfor ;\n\tTue, 26 Sep 2017 22:36:12 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 115C5B37;\n\tTue, 26 Sep 2017 12:35:36 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 2A966A92\n\tfor ; Tue, 26 Sep 2017 12:35:33 +0000 (UTC)","from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 919433ED\n\tfor ; Tue, 26 Sep 2017 12:35:32 +0000 (UTC)","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2017 05:35:27 -0700","from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga001.fm.intel.com with ESMTP; 26 Sep 2017 05:35:26 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,440,1500966000\"; d=\"scan'208\";\n\ta=\"1199143984\"","From":"antonio.fischetti@intel.com","To":"dev@openvswitch.org","Date":"Tue, 26 Sep 2017 13:35:21 +0100","Message-Id":"<1506429324-10416-2-git-send-email-antonio.fischetti@intel.com>","X-Mailer":"git-send-email 1.7.0.7","In-Reply-To":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>","References":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH v2 1/4] dpctl: Add a comment to functions\n\tretrieving the datapath name.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Signed-off-by: Antonio Fischetti \n---\n lib/dpctl.c | 28 +++++++++++++++++++++++++++-\n 1 file changed, 27 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/dpctl.c b/lib/dpctl.c\nindex 8951d6e..b6eecf0 100644\n--- a/lib/dpctl.c\n+++ b/lib/dpctl.c\n@@ -825,6 +825,9 @@ dpctl_dump_flows(int argc, const char *argv[], struct dpctl_params *dpctl_p)\n }\n }\n \n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc == 1 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n name = (argc > 1) ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!name) {\n error = EINVAL;\n@@ -960,6 +963,9 @@ dpctl_put_flow(int argc, const char *argv[], enum dpif_flow_put_flags flags,\n struct simap port_names;\n int n, error;\n \n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 4 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n dp_name = argc == 4 ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!dp_name) {\n return EINVAL;\n@@ -1069,6 +1075,9 @@ dpctl_get_flow(int argc, const char *argv[], struct dpctl_params *dpctl_p)\n struct ds ds;\n int n, error;\n \n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 3 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n dp_name = argc == 3 ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!dp_name) {\n return EINVAL;\n@@ -1125,6 +1134,9 @@ dpctl_del_flow(int argc, const char *argv[], struct dpctl_params *dpctl_p)\n struct simap port_names;\n int n, error;\n \n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 3 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n dp_name = argc == 3 ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!dp_name) {\n return EINVAL;\n@@ -1202,6 +1214,9 @@ dpctl_del_flows(int argc, const char *argv[], struct dpctl_params *dpctl_p)\n char *name;\n int error;\n \n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 2 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n name = (argc == 2) ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!name) {\n return EINVAL;\n@@ -1268,6 +1283,9 @@ dpctl_dump_conntrack(int argc, const char *argv[],\n pzone = &zone;\n argc--;\n }\n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 2 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n name = (argc == 2) ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!name) {\n return EINVAL;\n@@ -1314,6 +1332,9 @@ dpctl_flush_conntrack(int argc, const char *argv[],\n pzone = &zone;\n argc--;\n }\n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 2 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n name = (argc == 2) ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!name) {\n return EINVAL;\n@@ -1361,7 +1382,9 @@ dpctl_ct_stats_show(int argc, const char *argv[],\n }\n }\n }\n-\n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc == 1 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n name = (argc > 1) ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!name) {\n return EINVAL;\n@@ -1489,6 +1512,9 @@ dpctl_ct_bkts(int argc, const char *argv[],\n }\n }\n \n+ /* The datapath name is not a mandatory parameter for this command.\n+ * If it is not specified - so argc < 2 - we retrieve it from the\n+ * current setup, assuming only one exists. */\n name = (argc == 2) ? xstrdup(argv[1]) : get_one_dp(dpctl_p);\n if (!name) {\n return EINVAL;\n","prefixes":["ovs-dev","v2","1/4"]}