{"id":818597,"url":"http://patchwork.ozlabs.org/api/patches/818597/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170926115843.12013-5-fw@strlen.de/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170926115843.12013-5-fw@strlen.de>","list_archive_url":null,"date":"2017-09-26T11:58:43","name":"[net-next,v4,4/4] rtnetlink: rtnl_have_link_slave_info doesn't need rtnl","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"e4976f2d9409af12e97d5d91de14dccfa4c64e2b","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170926115843.12013-5-fw@strlen.de/mbox/","series":[{"id":5115,"url":"http://patchwork.ozlabs.org/api/series/5115/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=5115","date":"2017-09-26T11:58:39","name":"rtnetlink: preparation patches for further rtnl lock pushdown/removal","version":4,"mbox":"http://patchwork.ozlabs.org/series/5115/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818597/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818597/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1fcM0PSxz9tXn\n\tfor ;\n\tTue, 26 Sep 2017 21:58:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965345AbdIZL6l (ORCPT );\n\tTue, 26 Sep 2017 07:58:41 -0400","from Chamillionaire.breakpoint.cc ([146.0.238.67]:58794 \"EHLO\n\tChamillionaire.breakpoint.cc\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S964827AbdIZL6j (ORCPT\n\t); Tue, 26 Sep 2017 07:58:39 -0400","from fw by Chamillionaire.breakpoint.cc with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dwoSF-0007BE-Hj; Tue, 26 Sep 2017 13:55:11 +0200"],"From":"Florian Westphal ","To":"","Cc":"Florian Westphal ","Subject":"[PATCH net-next v4 4/4] rtnetlink: rtnl_have_link_slave_info\n\tdoesn't need rtnl","Date":"Tue, 26 Sep 2017 13:58:43 +0200","Message-Id":"<20170926115843.12013-5-fw@strlen.de>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170926115843.12013-1-fw@strlen.de>","References":"<20170926115843.12013-1-fw@strlen.de>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"it can be switched to rcu.\n\nReviewed-by: David Ahern \nSigned-off-by: Florian Westphal \n---\n No changes in v4.\n\n net/core/rtnetlink.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c\nindex d524609c587c..e6955da0d58d 100644\n--- a/net/core/rtnetlink.c\n+++ b/net/core/rtnetlink.c\n@@ -522,11 +522,15 @@ static size_t rtnl_link_get_af_size(const struct net_device *dev,\n static bool rtnl_have_link_slave_info(const struct net_device *dev)\n {\n \tstruct net_device *master_dev;\n+\tbool ret = false;\n \n-\tmaster_dev = netdev_master_upper_dev_get((struct net_device *) dev);\n+\trcu_read_lock();\n+\n+\tmaster_dev = netdev_master_upper_dev_get_rcu((struct net_device *)dev);\n \tif (master_dev && master_dev->rtnl_link_ops)\n-\t\treturn true;\n-\treturn false;\n+\t\tret = true;\n+\trcu_read_unlock();\n+\treturn ret;\n }\n \n static int rtnl_link_slave_info_fill(struct sk_buff *skb,\n","prefixes":["net-next","v4","4/4"]}