{"id":818580,"url":"http://patchwork.ozlabs.org/api/patches/818580/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150642403705.3900.11372246446054638606.stgit@Misha-PC.lan02.inno/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150642403705.3900.11372246446054638606.stgit@Misha-PC.lan02.inno>","list_archive_url":null,"date":"2017-09-26T11:07:17","name":"[34/43] windbg: implemented kd_api_write_breakpoint and kd_api_restore_breakpoint","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"77129ba8ea17ba194f81f2f1fa3e38df1cb2fc77","submitter":{"id":71645,"url":"http://patchwork.ozlabs.org/api/people/71645/?format=json","name":"Mikhail Abakumov","email":"mikhail.abakumov@ispras.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150642403705.3900.11372246446054638606.stgit@Misha-PC.lan02.inno/mbox/","series":[{"id":5104,"url":"http://patchwork.ozlabs.org/api/series/5104/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5104","date":"2017-09-26T11:04:06","name":"Windbg supporting","version":1,"mbox":"http://patchwork.ozlabs.org/series/5104/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818580/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818580/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1f7Q0lmNz9tXn\n\tfor ;\n\tTue, 26 Sep 2017 21:37:06 +1000 (AEST)","from localhost ([::1]:46854 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwoAg-0006EB-QX\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 07:37:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60084)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwnhz-0005jE-0C\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwnhv-0001a3-JO\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:22 -0400","from mail.ispras.ru ([83.149.199.45]:52306)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwnhv-0001ZY-6m\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:19 -0400","from Misha-PC.lan02.inno (unknown [85.142.117.226])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id 84C895400FD;\n\tTue, 26 Sep 2017 14:07:18 +0300 (MSK)"],"From":"Mihail Abakumov ","To":"qemu-devel@nongnu.org","Date":"Tue, 26 Sep 2017 14:07:17 +0300","Message-ID":"<150642403705.3900.11372246446054638606.stgit@Misha-PC.lan02.inno>","In-Reply-To":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>","User-Agent":"StGit/0.17.1-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"83.149.199.45","Subject":"[Qemu-devel] [PATCH 34/43] windbg: implemented\n\tkd_api_write_breakpoint and kd_api_restore_breakpoint","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru,\n\trkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Added supporting of windbg breakpoints.\n\nSigned-off-by: Mihail Abakumov \nSigned-off-by: Pavel Dovgalyuk \nSigned-off-by: Dmitriy Koltunov \n---\n include/exec/windbgstub-utils.h | 2 +\n windbgstub-utils.c | 77 ++++++++++++++++++++++++++++++++++++++-\n windbgstub.c | 11 ++++++\n 3 files changed, 89 insertions(+), 1 deletion(-)","diff":"diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\nindex e368b2e85d..3d062ab9bb 100755\n--- a/include/exec/windbgstub-utils.h\n+++ b/include/exec/windbgstub-utils.h\n@@ -106,6 +106,8 @@ void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd);\n void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd);\n void kd_api_get_context(CPUState *cpu, PacketData *pd);\n void kd_api_set_context(CPUState *cpu, PacketData *pd);\n+void kd_api_write_breakpoint(CPUState *cpu, PacketData *pd);\n+void kd_api_restore_breakpoint(CPUState *cpu, PacketData *pd);\n void kd_api_read_control_space(CPUState *cpu, PacketData *pd);\n void kd_api_write_control_space(CPUState *cpu, PacketData *pd);\n void kd_api_unsupported(CPUState *cpu, PacketData *pd);\ndiff --git a/windbgstub-utils.c b/windbgstub-utils.c\nindex 05caf98c0c..c5d24c5d8e 100755\n--- a/windbgstub-utils.c\n+++ b/windbgstub-utils.c\n@@ -288,6 +288,8 @@ typedef struct _CPU_KPROCESSOR_STATE {\n typedef struct KDData {\n InitedAddr KPCR;\n InitedAddr version;\n+\n+ InitedAddr bps[KD_BREAKPOINT_MAX];\n } KDData;\n \n static KDData *kd;\n@@ -971,6 +973,62 @@ void kd_api_set_context(CPUState *cpu, PacketData *pd)\n }\n }\n \n+void kd_api_write_breakpoint(CPUState *cpu, PacketData *pd)\n+{\n+ DBGKD_WRITE_BREAKPOINT64 *m64c = &pd->m64.u.WriteBreakPoint;\n+ target_ulong addr = ldtul_p(&m64c->BreakPointAddress);\n+ int i = 0, err = 0;\n+\n+ for (; i < KD_BREAKPOINT_MAX; ++i) {\n+ if (!kd->bps[i].is_init) {\n+ err = cpu_breakpoint_insert(cpu, addr, BP_GDB, NULL);\n+ if (!err) {\n+ kd->bps[i].addr = addr;\n+ kd->bps[i].is_init = true;\n+ WINDBG_DEBUG(\"write_breakpoint: \" FMT_ADDR, addr);\n+ break;\n+ } else {\n+ WINDBG_ERROR(\"write_breakpoint: \" FMT_ADDR \", \" FMT_ERR,\n+ addr, err);\n+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n+ return;\n+ }\n+ } else if (addr == kd->bps[i].addr) {\n+ break;\n+ }\n+ }\n+\n+ if (!err) {\n+ m64c->BreakPointHandle = i + 1;\n+ pd->m64.ReturnStatus = STATUS_SUCCESS;\n+ } else {\n+ WINDBG_ERROR(\"write_breakpoint: All breakpoints occupied\");\n+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n+ }\n+}\n+\n+void kd_api_restore_breakpoint(CPUState *cpu, PacketData *pd)\n+{\n+ DBGKD_RESTORE_BREAKPOINT *m64c = &pd->m64.u.RestoreBreakPoint;\n+ uint8_t index = ldtul_p(&m64c->BreakPointHandle) - 1;\n+ int err = -1;\n+\n+ if (kd->bps[index].is_init) {\n+ err = cpu_breakpoint_remove(cpu, kd->bps[index].addr, BP_GDB);\n+ if (!err) {\n+ WINDBG_DEBUG(\"restore_breakpoint: \" FMT_ADDR \", index(%d)\",\n+ kd->bps[index].addr, index);\n+ } else {\n+ WINDBG_ERROR(\"restore_breakpoint: \" FMT_ADDR \", index(%d), \"\n+ FMT_ERR, kd->bps[index].addr, index, err);\n+ }\n+ kd->bps[index].is_init = false;\n+ pd->m64.ReturnStatus = STATUS_SUCCESS;\n+ } else {\n+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n+ }\n+}\n+\n void kd_api_read_control_space(CPUState *cpu, PacketData *pd)\n {\n DBGKD_READ_MEMORY64 *mem = &pd->m64.u.ReadMemory;\n@@ -1052,7 +1110,24 @@ void kd_api_unsupported(CPUState *cpu, PacketData *pd)\n \n static void kd_breakpoint_remove_range(CPUState *cpu, target_ulong base,\n target_ulong limit)\n-{}\n+{\n+ int i = 0, err = 0;\n+ for (; i < KD_BREAKPOINT_MAX; ++i) {\n+ if (kd->bps[i].is_init && kd->bps[i].addr >= base &&\n+ kd->bps[i].addr < limit) {\n+ err = cpu_breakpoint_remove(cpu, kd->bps[i].addr, BP_GDB);\n+ if (!err) {\n+ WINDBG_DEBUG(\"breakpoint_remove_range: \" FMT_ADDR\n+ \", index(%d)\", kd->bps[i].addr, i);\n+ } else {\n+ WINDBG_ERROR(\"breakpoint_remove_range: \" FMT_ADDR\n+ \", index(%d), \" FMT_ERR,\n+ kd->bps[i].addr, i, err);\n+ }\n+ kd->bps[i].is_init = false;\n+ }\n+ }\n+}\n \n static void kd_init_state_change(CPUState *cpu,\n DBGKD_ANY_WAIT_STATE_CHANGE *sc)\ndiff --git a/windbgstub.c b/windbgstub.c\nindex 24d0031167..f8e80c60ab 100755\n--- a/windbgstub.c\n+++ b/windbgstub.c\n@@ -149,6 +149,14 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n kd_api_set_context(cpu, &ctx->data);\n break;\n \n+ case DbgKdWriteBreakPointApi:\n+ kd_api_write_breakpoint(cpu, &ctx->data);\n+ break;\n+\n+ case DbgKdRestoreBreakPointApi:\n+ kd_api_restore_breakpoint(cpu, &ctx->data);\n+ break;\n+\n case DbgKdReadControlSpaceApi:\n kd_api_read_control_space(cpu, &ctx->data);\n break;\n@@ -157,6 +165,9 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n kd_api_write_control_space(cpu, &ctx->data);\n break;\n \n+ case DbgKdClearAllInternalBreakpointsApi:\n+ return;\n+\n default:\n kd_api_unsupported(cpu, &ctx->data);\n break;\n","prefixes":["34/43"]}