{"id":818578,"url":"http://patchwork.ozlabs.org/api/patches/818578/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150642403148.3900.7920017116044093005.stgit@Misha-PC.lan02.inno/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150642403148.3900.7920017116044093005.stgit@Misha-PC.lan02.inno>","list_archive_url":null,"date":"2017-09-26T11:07:11","name":"[33/43] windbg: implemented windbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5820c64980fd1321b143002898335d3bbda7933d","submitter":{"id":71645,"url":"http://patchwork.ozlabs.org/api/people/71645/?format=json","name":"Mikhail Abakumov","email":"mikhail.abakumov@ispras.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150642403148.3900.7920017116044093005.stgit@Misha-PC.lan02.inno/mbox/","series":[{"id":5104,"url":"http://patchwork.ozlabs.org/api/series/5104/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5104","date":"2017-09-26T11:04:06","name":"Windbg supporting","version":1,"mbox":"http://patchwork.ozlabs.org/series/5104/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818578/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818578/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1f4K4QrXz9sBZ\n\tfor ;\n\tTue, 26 Sep 2017 21:34:25 +1000 (AEST)","from localhost ([::1]:46832 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwo86-0003oP-R2\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 07:34:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60059)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwnhv-0005ce-Ou\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwnhp-0001Xh-Sq\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:19 -0400","from mail.ispras.ru ([83.149.199.45]:52292)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwnhp-0001XR-LX\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:07:13 -0400","from Misha-PC.lan02.inno (unknown [85.142.117.226])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id 039685400F1;\n\tTue, 26 Sep 2017 14:07:13 +0300 (MSK)"],"From":"Mihail Abakumov ","To":"qemu-devel@nongnu.org","Date":"Tue, 26 Sep 2017 14:07:11 +0300","Message-ID":"<150642403148.3900.7920017116044093005.stgit@Misha-PC.lan02.inno>","In-Reply-To":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>","User-Agent":"StGit/0.17.1-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"83.149.199.45","Subject":"[Qemu-devel] [PATCH 33/43] windbg: implemented\n\twindbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru,\n\trkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Mihail Abakumov \nSigned-off-by: Pavel Dovgalyuk \nSigned-off-by: Dmitriy Koltunov \n---\n windbgstub-utils.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 60 insertions(+)","diff":"diff --git a/windbgstub-utils.c b/windbgstub-utils.c\nindex e33789725e..05caf98c0c 100755\n--- a/windbgstub-utils.c\n+++ b/windbgstub-utils.c\n@@ -294,11 +294,71 @@ static KDData *kd;\n \n static int windbg_hw_breakpoint_insert(CPUState *cpu, int index)\n {\n+ CPUArchState *env = cpu->env_ptr;\n+\n+ if (!IS_BP_ENABLED(env->dr[7], index)) {\n+ return 0;\n+ }\n+\n+ target_ulong addr = env->dr[index];\n+ int type = BP_TYPE(env->dr[7], index);\n+ int len = BP_LEN(env->dr[7], index);\n+ int err = 0;\n+\n+ switch (type) {\n+ case DR7_TYPE_DATA_WR:\n+ err = cpu_watchpoint_insert(cpu, addr, len, BP_MEM_WRITE | BP_GDB,\n+ &env->cpu_watchpoint[index]);\n+ break;\n+ case DR7_TYPE_DATA_RW:\n+ err = cpu_watchpoint_insert(cpu, addr, len, BP_MEM_ACCESS | BP_GDB,\n+ &env->cpu_watchpoint[index]);\n+ break;\n+ case DR7_TYPE_BP_INST:\n+ err = cpu_breakpoint_insert(cpu, addr, BP_GDB,\n+ &env->cpu_breakpoint[index]);\n+ break;\n+ case DR7_TYPE_IO_RW:\n+ return HF_IOBPT_MASK;\n+ default:\n+ return 0;\n+ }\n+\n+ if (!err) {\n+ WINDBG_DEBUG(\"hw_breakpoint_insert: index(%d), \" FMT_ADDR,\n+ index, addr);\n+ } else {\n+ env->cpu_breakpoint[index] = NULL;\n+ WINDBG_ERROR(\"hw_breakpoint_insert: index(%d), \" FMT_ADDR \", \" FMT_ERR,\n+ index, addr, err);\n+ }\n return 0;\n }\n \n static int windbg_hw_breakpoint_remove(CPUState *cpu, int index)\n {\n+ CPUArchState *env = cpu->env_ptr;\n+ int type = BP_TYPE(env->dr[7], index);\n+\n+ switch (type) {\n+ case DR7_TYPE_BP_INST:\n+ if (env->cpu_breakpoint[index]) {\n+ cpu_breakpoint_remove_by_ref(cpu, env->cpu_breakpoint[index]);\n+ }\n+ break;\n+ case DR7_TYPE_DATA_WR:\n+ case DR7_TYPE_DATA_RW:\n+ if (env->cpu_watchpoint[index]) {\n+ cpu_watchpoint_remove_by_ref(cpu, env->cpu_watchpoint[index]);\n+ }\n+ break;\n+ default:\n+ return 0;\n+ }\n+\n+ env->cpu_breakpoint[index] = NULL;\n+ WINDBG_DEBUG(\"hw_breakpoint_remove: index(%d), \" FMT_ADDR,\n+ index, env->dr[index]);\n return 0;\n }\n \n","prefixes":["33/43"]}