{"id":818540,"url":"http://patchwork.ozlabs.org/api/patches/818540/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150642398608.3900.11026705123393046138.stgit@Misha-PC.lan02.inno/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150642398608.3900.11026705123393046138.stgit@Misha-PC.lan02.inno>","list_archive_url":null,"date":"2017-09-26T11:06:26","name":"[25/43] windbg: implemented kd_api_read_control_space and kd_api_write_control_space","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bed3fd053b40ee37b091dea68ebffa5431a55fe2","submitter":{"id":71645,"url":"http://patchwork.ozlabs.org/api/people/71645/?format=json","name":"Mikhail Abakumov","email":"mikhail.abakumov@ispras.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150642398608.3900.11026705123393046138.stgit@Misha-PC.lan02.inno/mbox/","series":[{"id":5104,"url":"http://patchwork.ozlabs.org/api/series/5104/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=5104","date":"2017-09-26T11:04:06","name":"Windbg supporting","version":1,"mbox":"http://patchwork.ozlabs.org/series/5104/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818540/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818540/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1dXV1vKQz9tXP\n\tfor ;\n\tTue, 26 Sep 2017 21:10:18 +1000 (AEST)","from localhost ([::1]:46708 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwnkm-0007SE-Af\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 07:10:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59714)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwnh7-0004qe-Rc\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:06:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwnh6-0001Ff-Mw\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:06:29 -0400","from mail.ispras.ru ([83.149.199.45]:52116)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwnh6-0001FR-Au\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:06:28 -0400","from Misha-PC.lan02.inno (unknown [85.142.117.226])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id 99DF85400D7;\n\tTue, 26 Sep 2017 14:06:27 +0300 (MSK)"],"From":"Mihail Abakumov ","To":"qemu-devel@nongnu.org","Date":"Tue, 26 Sep 2017 14:06:26 +0300","Message-ID":"<150642398608.3900.11026705123393046138.stgit@Misha-PC.lan02.inno>","In-Reply-To":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>","User-Agent":"StGit/0.17.1-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"83.149.199.45","Subject":"[Qemu-devel] [PATCH 25/43] windbg: implemented\n\tkd_api_read_control_space and kd_api_write_control_space","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru,\n\trkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Mihail Abakumov \nSigned-off-by: Pavel Dovgalyuk \nSigned-off-by: Dmitriy Koltunov \n---\n include/exec/windbgstub-utils.h | 2 +\n windbgstub-utils.c | 81 +++++++++++++++++++++++++++++++++++++++\n windbgstub.c | 8 ++++\n 3 files changed, 91 insertions(+)","diff":"diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\nindex 0b683f95ac..e368b2e85d 100755\n--- a/include/exec/windbgstub-utils.h\n+++ b/include/exec/windbgstub-utils.h\n@@ -106,6 +106,8 @@ void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd);\n void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd);\n void kd_api_get_context(CPUState *cpu, PacketData *pd);\n void kd_api_set_context(CPUState *cpu, PacketData *pd);\n+void kd_api_read_control_space(CPUState *cpu, PacketData *pd);\n+void kd_api_write_control_space(CPUState *cpu, PacketData *pd);\n void kd_api_unsupported(CPUState *cpu, PacketData *pd);\n \n SizedBuf kd_gen_exception_sc(CPUState *cpu);\ndiff --git a/windbgstub-utils.c b/windbgstub-utils.c\nindex b15d84c8d0..c3ae2ddf5b 100755\n--- a/windbgstub-utils.c\n+++ b/windbgstub-utils.c\n@@ -289,6 +289,18 @@ static int windbg_write_context(CPUState *cpu, uint8_t *buf, int len,\n return 0;\n }\n \n+static int windbg_read_ks_regs(CPUState *cpu, uint8_t *buf, int len,\n+ int offset)\n+{\n+ return 0;\n+}\n+\n+static int windbg_write_ks_regs(CPUState *cpu, uint8_t *buf, int len,\n+ int offset)\n+{\n+ return 0;\n+}\n+\n void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd)\n {\n DBGKD_READ_MEMORY64 *mem = &pd->m64.u.ReadMemory;\n@@ -361,6 +373,75 @@ void kd_api_set_context(CPUState *cpu, PacketData *pd)\n }\n }\n \n+void kd_api_read_control_space(CPUState *cpu, PacketData *pd)\n+{\n+ DBGKD_READ_MEMORY64 *mem = &pd->m64.u.ReadMemory;\n+ uint32_t len;\n+ target_ulong addr;\n+ int err = -1;\n+\n+ len = MIN(ldl_p(&mem->TransferCount), PACKET_MAX_SIZE - M64_SIZE);\n+ addr = ldtul_p(&mem->TargetBaseAddress);\n+\n+ if (addr < sizeof(CPU_KPROCESSOR_STATE)) {\n+ len = MIN(len, sizeof(CPU_KPROCESSOR_STATE) - addr);\n+\n+ uint32_t from_context = MAX(0, (int) (sizeof(CPU_CONTEXT) - addr));\n+ uint32_t from_ks_regs = len - from_context;\n+\n+ if (from_context > 0) {\n+ err = windbg_read_context(cpu, pd->extra, from_context, addr);\n+ }\n+ if (from_ks_regs > 0) {\n+ err = windbg_read_ks_regs(cpu, pd->extra + from_context,\n+ from_ks_regs, addr -\n+ sizeof(CPU_CONTEXT) + from_context);\n+ }\n+ }\n+\n+ if (!err) {\n+ pd->extra_size = len;\n+ mem->ActualBytesRead = ldl_p(&len);\n+ } else {\n+ pd->extra_size = mem->ActualBytesRead = 0;\n+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n+ }\n+}\n+\n+void kd_api_write_control_space(CPUState *cpu, PacketData *pd)\n+{\n+ DBGKD_WRITE_MEMORY64 *mem = &pd->m64.u.WriteMemory;\n+ uint32_t len;\n+ target_ulong addr;\n+ int err = -1;\n+\n+ len = MIN(ldl_p(&mem->TransferCount), pd->extra_size);\n+ addr = ldtul_p(&mem->TargetBaseAddress);\n+\n+ if (addr < sizeof(CPU_KPROCESSOR_STATE)) {\n+ len = MIN(len, sizeof(CPU_KPROCESSOR_STATE) - addr);\n+\n+ uint32_t to_context = MAX(0, (int) (sizeof(CPU_CONTEXT) - addr));\n+ uint32_t to_ks_regs = len - to_context;\n+\n+ if (to_context > 0) {\n+ err = windbg_write_context(cpu, pd->extra, to_context, addr);\n+ }\n+ if (to_ks_regs > 0) {\n+ err = windbg_write_ks_regs(cpu, pd->extra + to_context, to_ks_regs,\n+ addr - sizeof(CPU_CONTEXT) + to_context);\n+ }\n+ }\n+\n+ pd->extra_size = 0;\n+ if (!err) {\n+ mem->ActualBytesWritten = ldl_p(&len);\n+ } else {\n+ mem->ActualBytesWritten = 0;\n+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n+ }\n+}\n+\n void kd_api_unsupported(CPUState *cpu, PacketData *pd)\n {\n WINDBG_ERROR(\"Catched unimplemented api %s\",\ndiff --git a/windbgstub.c b/windbgstub.c\nindex 23930d195e..24d0031167 100755\n--- a/windbgstub.c\n+++ b/windbgstub.c\n@@ -149,6 +149,14 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n kd_api_set_context(cpu, &ctx->data);\n break;\n \n+ case DbgKdReadControlSpaceApi:\n+ kd_api_read_control_space(cpu, &ctx->data);\n+ break;\n+\n+ case DbgKdWriteControlSpaceApi:\n+ kd_api_write_control_space(cpu, &ctx->data);\n+ break;\n+\n default:\n kd_api_unsupported(cpu, &ctx->data);\n break;\n","prefixes":["25/43"]}