{"id":818518,"url":"http://patchwork.ozlabs.org/api/patches/818518/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20170926103751.21907-8-krebbel@linux.vnet.ibm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170926103751.21907-8-krebbel@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-26T10:37:50","name":"[7/8] S/390: Fix vector fp unordered compares","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"436db5bc95e1aa8967e1eb539fe92179fcfca6bf","submitter":{"id":4421,"url":"http://patchwork.ozlabs.org/api/people/4421/?format=json","name":"Andreas Krebbel","email":"krebbel@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20170926103751.21907-8-krebbel@linux.vnet.ibm.com/mbox/","series":[{"id":5096,"url":"http://patchwork.ozlabs.org/api/series/5096/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=5096","date":"2017-09-26T10:37:43","name":"S/390: Enable vect tests on S/390 + fixes and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/5096/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818518/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818518/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462951-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"k8Zg+9wx\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1crx0Rmcz9tXc\n\tfor ;\n\tTue, 26 Sep 2017 20:39:28 +1000 (AEST)","(qmail 103528 invoked by alias); 26 Sep 2017 10:38:10 -0000","(qmail 103140 invoked by uid 89); 26 Sep 2017 10:38:09 -0000","from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com)\n\t(148.163.158.5) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tTue, 26 Sep 2017 10:38:07 +0000","from pps.filterd (m0098417.ppops.net [127.0.0.1])\tby\n\tmx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QAZF8g065844\tfor ;\n\tTue, 26 Sep 2017 06:38:03 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com\n\t[195.75.94.109])\tby mx0a-001b2d01.pphosted.com with ESMTP id\n\t2d7mfk3bxp-1\t(version=TLSv1.2 cipher=AES256-SHA bits=256\n\tverify=NOT)\tfor ;\n\tTue, 26 Sep 2017 06:38:03 -0400","from localhost\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be\n\tprosecuted\tfor from\n\t; Tue, 26 Sep 2017 11:38:01 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\tby\n\te06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted;\n\tTue, 26 Sep 2017 11:38:00 +0100","from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\tby b06cxnps4076.portsmouth.uk.ibm.com\n\t(8.14.9/8.14.9/NCO v10.0) with ESMTP id v8QAbx8A21299322\tfor\n\t; Tue, 26 Sep 2017 10:37:59 GMT","from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\tby IMSVA\n\t(Postfix) with ESMTP id EF12152043\tfor ;\n\tTue, 26 Sep 2017 10:32:49 +0100 (BST)","from maggie.boeblingen.de.ibm.com (unknown [9.152.212.134])\tby\n\td06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id\n\tD4BC15203F\tfor ;\n\tTue, 26 Sep 2017 10:32:49 +0100 (BST)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:subject:date:in-reply-to:references:message-id; q=dns; s=\n\tdefault; b=PqouEtwzE9NboG9mwr4Rt1m8bOhiF1eGPp4YJMaz5LlGlDG04EbNO\n\tKUCS0MBNpe2+hwqHfG8HNzPFbqwpwZa7f9W9/qZPZIJU0u+wp4O3HdsOpBCKIPJO\n\ttMWV9YHBSgG9UZwAwISyGUPIDy8ThW7E3bp9cKnQ7urW6D+ROhRJBE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:subject:date:in-reply-to:references:message-id; s=default;\n\tbh=GSNgVlu+iNhJm89sVWEWjQ/CDds=; b=k8Zg+9wxqcDDrn7QDKylTfHYtVe9\n\tgLc7PyCHzSKmj9o34O3TUAAo71EGfl9m1fOtDEyr+I+a/JBQtmJQX0SwSWfFpzdh\n\tEJ/D4lZRcCeBatHhvqA/H+XGmKeIY++DNqwtfoLJEj+A1zQk8WKar+zuWJweL31U\n\tsJqRe5ZZLoUmjzY=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.6 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=vv, dv","X-HELO":"mx0a-001b2d01.pphosted.com","From":"Andreas Krebbel ","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH 7/8] S/390: Fix vector fp unordered compares","Date":"Tue, 26 Sep 2017 12:37:50 +0200","In-Reply-To":"<20170926103751.21907-1-krebbel@linux.vnet.ibm.com>","References":"<20170926103751.21907-1-krebbel@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17092610-0012-0000-0000-0000057C2DD4","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092610-0013-0000-0000-000018F57A30","Message-Id":"<20170926103751.21907-8-krebbel@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1 malwarescore=0 phishscore=0\n\tadultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260158","X-IsSubscribed":"yes"},"content":"V2DF mode was still hard-coded here.\n\ngcc/ChangeLog:\n\n2017-09-26 Andreas Krebbel \n\n\t* config/s390/s390.c (s390_expand_vec_compare): Use the new mode\n\tindependent expanders.\n\t* config/s390/vector.md (\"vec_cmpuneq\", \"vec_cmpltgt\")\n\t(\"vec_ordered\", \"vec_unordered\"): New expanders.\n---\n gcc/ChangeLog | 7 ++++++\n gcc/config/s390/s390.c | 8 +++---\n gcc/config/s390/vector.md | 64 +++++++++++++++++++++++++++++++++++++++++++++++\n 3 files changed, 75 insertions(+), 4 deletions(-)","diff":"diff --git a/gcc/ChangeLog b/gcc/ChangeLog\nindex a33de8f..d4f67f5 100644\n--- a/gcc/ChangeLog\n+++ b/gcc/ChangeLog\n@@ -1,5 +1,12 @@\n 2017-09-26 Andreas Krebbel \n \n+\t* config/s390/s390.c (s390_expand_vec_compare): Use the new mode\n+\tindependent expanders.\n+\t* config/s390/vector.md (\"vec_cmpuneq\", \"vec_cmpltgt\")\n+\t(\"vec_ordered\", \"vec_unordered\"): New expanders.\n+\n+2017-09-26 Andreas Krebbel \n+\n \t* config/s390/s390.c (s390_preferred_simd_mode): Return V4SFmode\n \tfor SFmode.\n \ndiff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c\nindex 0ceeef4..d2671ba 100644\n--- a/gcc/config/s390/s390.c\n+++ b/gcc/config/s390/s390.c\n@@ -6396,16 +6396,16 @@ s390_expand_vec_compare (rtx target, enum rtx_code cond,\n \t /* UNLT: a u< b -> !(a >= b) */\n \tcase UNLT: cond = GE; neg_p = true; break;\n \tcase UNEQ:\n-\t emit_insn (gen_vec_cmpuneqv2df (target, cmp_op1, cmp_op2));\n+\t emit_insn (gen_vec_cmpuneq (target, cmp_op1, cmp_op2));\n \t return;\n \tcase LTGT:\n-\t emit_insn (gen_vec_cmpltgtv2df (target, cmp_op1, cmp_op2));\n+\t emit_insn (gen_vec_cmpltgt (target, cmp_op1, cmp_op2));\n \t return;\n \tcase ORDERED:\n-\t emit_insn (gen_vec_orderedv2df (target, cmp_op1, cmp_op2));\n+\t emit_insn (gen_vec_ordered (target, cmp_op1, cmp_op2));\n \t return;\n \tcase UNORDERED:\n-\t emit_insn (gen_vec_unorderedv2df (target, cmp_op1, cmp_op2));\n+\t emit_insn (gen_vec_unordered (target, cmp_op1, cmp_op2));\n \t return;\n \tdefault: break;\n \t}\ndiff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md\nindex 06c88c1..d40bf1e 100644\n--- a/gcc/config/s390/vector.md\n+++ b/gcc/config/s390/vector.md\n@@ -1406,6 +1406,22 @@\n operands[3] = gen_reg_rtx (mode);\n })\n \n+(define_expand \"vec_cmpuneq\"\n+ [(match_operand 0 \"register_operand\" \"\")\n+ (match_operand 1 \"register_operand\" \"\")\n+ (match_operand 2 \"register_operand\" \"\")]\n+ \"TARGET_VX\"\n+{\n+ if (GET_MODE (operands[1]) == V4SFmode)\n+ emit_insn (gen_vec_cmpuneqv4sf (operands[0], operands[1], operands[2]));\n+ else if (GET_MODE (operands[1]) == V2DFmode)\n+ emit_insn (gen_vec_cmpuneqv2df (operands[0], operands[1], operands[2]));\n+ else\n+ gcc_unreachable ();\n+\n+ DONE;\n+})\n+\n ; LTGT a <> b -> a > b | b > a\n (define_expand \"vec_cmpltgt\"\n [(set (match_operand: 0 \"register_operand\" \"=v\")\n@@ -1418,6 +1434,22 @@\n operands[3] = gen_reg_rtx (mode);\n })\n \n+(define_expand \"vec_cmpltgt\"\n+ [(match_operand 0 \"register_operand\" \"\")\n+ (match_operand 1 \"register_operand\" \"\")\n+ (match_operand 2 \"register_operand\" \"\")]\n+ \"TARGET_VX\"\n+{\n+ if (GET_MODE (operands[1]) == V4SFmode)\n+ emit_insn (gen_vec_cmpltgtv4sf (operands[0], operands[1], operands[2]));\n+ else if (GET_MODE (operands[1]) == V2DFmode)\n+ emit_insn (gen_vec_cmpltgtv2df (operands[0], operands[1], operands[2]));\n+ else\n+ gcc_unreachable ();\n+\n+ DONE;\n+})\n+\n ; ORDERED (a, b): a >= b | b > a\n (define_expand \"vec_ordered\"\n [(set (match_operand: 0 \"register_operand\" \"=v\")\n@@ -1430,6 +1462,22 @@\n operands[3] = gen_reg_rtx (mode);\n })\n \n+(define_expand \"vec_ordered\"\n+ [(match_operand 0 \"register_operand\" \"\")\n+ (match_operand 1 \"register_operand\" \"\")\n+ (match_operand 2 \"register_operand\" \"\")]\n+ \"TARGET_VX\"\n+{\n+ if (GET_MODE (operands[1]) == V4SFmode)\n+ emit_insn (gen_vec_orderedv4sf (operands[0], operands[1], operands[2]));\n+ else if (GET_MODE (operands[1]) == V2DFmode)\n+ emit_insn (gen_vec_orderedv2df (operands[0], operands[1], operands[2]));\n+ else\n+ gcc_unreachable ();\n+\n+ DONE;\n+})\n+\n ; UNORDERED (a, b): !ORDERED (a, b)\n (define_expand \"vec_unordered\"\n [(set (match_operand: 0 \"register_operand\" \"=v\")\n@@ -1443,6 +1491,22 @@\n operands[3] = gen_reg_rtx (mode);\n })\n \n+(define_expand \"vec_unordered\"\n+ [(match_operand 0 \"register_operand\" \"\")\n+ (match_operand 1 \"register_operand\" \"\")\n+ (match_operand 2 \"register_operand\" \"\")]\n+ \"TARGET_VX\"\n+{\n+ if (GET_MODE (operands[1]) == V4SFmode)\n+ emit_insn (gen_vec_unorderedv4sf (operands[0], operands[1], operands[2]));\n+ else if (GET_MODE (operands[1]) == V2DFmode)\n+ emit_insn (gen_vec_unorderedv2df (operands[0], operands[1], operands[2]));\n+ else\n+ gcc_unreachable ();\n+\n+ DONE;\n+})\n+\n (define_insn \"*vec_load_pair\"\n [(set (match_operand:V_HW_64 0 \"register_operand\" \"=v,v\")\n \t(vec_concat:V_HW_64 (match_operand: 1 \"register_operand\" \"d,v\")\n","prefixes":["7/8"]}