{"id":818255,"url":"http://patchwork.ozlabs.org/api/patches/818255/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925135801.144261-3-vsementsov@virtuozzo.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170925135801.144261-3-vsementsov@virtuozzo.com>","list_archive_url":null,"date":"2017-09-25T13:57:55","name":"[2/8] block/nbd-client: refactor nbd_co_receive_reply","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"684faf9425e0ba0dd2e47ab58907f9b17f3de99a","submitter":{"id":66592,"url":"http://patchwork.ozlabs.org/api/people/66592/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@virtuozzo.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925135801.144261-3-vsementsov@virtuozzo.com/mbox/","series":[{"id":4967,"url":"http://patchwork.ozlabs.org/api/series/4967/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4967","date":"2017-09-25T13:58:01","name":"nbd minimal structured read","version":1,"mbox":"http://patchwork.ozlabs.org/series/4967/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818255/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818255/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y15Pj2376z9tX8\n\tfor ;\n\tTue, 26 Sep 2017 00:02:33 +1000 (AEST)","from localhost ([::1]:42594 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwTxv-0001B3-7I\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 10:02:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39733)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwTu2-0006bH-6X\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:58:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwTu1-0007HZ-8n\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:58:30 -0400","from mailhub.sw.ru ([195.214.232.25]:22094 helo=relay.sw.ru)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwTu0-0007G0-UH\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:58:29 -0400","from kvm.sw.ru (msk-vpn.virtuozzo.com [195.214.232.6])\n\tby relay.sw.ru (8.13.4/8.13.4) with ESMTP id v8PDw1fs013085;\n\tMon, 25 Sep 2017 16:58:02 +0300 (MSK)"],"From":"Vladimir Sementsov-Ogievskiy ","To":"qemu-devel@nongnu.org, qemu-block@nongnu.org","Date":"Mon, 25 Sep 2017 16:57:55 +0300","Message-Id":"<20170925135801.144261-3-vsementsov@virtuozzo.com>","X-Mailer":"git-send-email 2.11.1","In-Reply-To":"<20170925135801.144261-1-vsementsov@virtuozzo.com>","References":"<20170925135801.144261-1-vsementsov@virtuozzo.com>","X-detected-operating-system":"by eggs.gnu.org: OpenBSD 3.x [fuzzy]","X-Received-From":"195.214.232.25","Subject":"[Qemu-devel] [PATCH 2/8] block/nbd-client: refactor\n\tnbd_co_receive_reply","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, vsementsov@virtuozzo.com, Hmreitz@redhat.com,\n\tden@openvz.org, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Pass handle parameter directly, as the whole request isn't needed.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n block/nbd-client.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/block/nbd-client.c b/block/nbd-client.c\nindex 88fd10270e..e4f0c789f4 100644\n--- a/block/nbd-client.c\n+++ b/block/nbd-client.c\n@@ -180,11 +180,11 @@ err:\n }\n \n static int nbd_co_receive_reply(NBDClientSession *s,\n- NBDRequest *request,\n+ uint64_t handle,\n QEMUIOVector *qiov)\n {\n int ret;\n- int i = HANDLE_TO_INDEX(s, request->handle);\n+ int i = HANDLE_TO_INDEX(s, handle);\n \n /* Wait until we're woken up by nbd_read_reply_entry. */\n s->requests[i].receiving = true;\n@@ -193,7 +193,7 @@ static int nbd_co_receive_reply(NBDClientSession *s,\n if (!s->ioc || s->quit) {\n ret = -EIO;\n } else {\n- assert(s->reply.handle == request->handle);\n+ assert(s->reply.handle == handle);\n ret = -s->reply.error;\n if (qiov && s->reply.error == 0) {\n if (qio_channel_readv_all(s->ioc, qiov->iov, qiov->niov,\n@@ -238,7 +238,7 @@ static int nbd_co_request(BlockDriverState *bs,\n return ret;\n }\n \n- return nbd_co_receive_reply(client, request,\n+ return nbd_co_receive_reply(client, request->handle,\n request->type == NBD_CMD_READ ? qiov : NULL);\n }\n \n","prefixes":["2/8"]}