{"id":818231,"url":"http://patchwork.ozlabs.org/api/patches/818231/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170925125948.13507-4-antoine.tenart@free-electrons.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170925125948.13507-4-antoine.tenart@free-electrons.com>","list_archive_url":null,"date":"2017-09-25T12:59:48","name":"[net,v2,3/3] net: mvpp2: do not select the internal source clock","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a39a4ac8fa0b1e8d381eaa7402981af01e5ed69f","submitter":{"id":61603,"url":"http://patchwork.ozlabs.org/api/people/61603/?format=json","name":"Antoine Tenart","email":"antoine.tenart@free-electrons.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170925125948.13507-4-antoine.tenart@free-electrons.com/mbox/","series":[{"id":4955,"url":"http://patchwork.ozlabs.org/api/series/4955/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4955","date":"2017-09-25T12:59:48","name":"net: mvpp2: various fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/4955/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818231/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818231/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y141h1qZzz9tX8\n\tfor ;\n\tMon, 25 Sep 2017 23:00:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S964798AbdIYNAG (ORCPT );\n\tMon, 25 Sep 2017 09:00:06 -0400","from mail.free-electrons.com ([62.4.15.54]:43237 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S934840AbdIYNAD (ORCPT\n\t); Mon, 25 Sep 2017 09:00:03 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid F0F7A20983; Mon, 25 Sep 2017 15:00:01 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id C848520918;\n\tMon, 25 Sep 2017 15:00:01 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Antoine Tenart ","To":"davem@davemloft.net","Cc":"Antoine Tenart , andrew@lunn.ch,\n\tgregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com,\n\tmiquel.raynal@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"[PATCH net v2 3/3] net: mvpp2: do not select the internal source\n\tclock","Date":"Mon, 25 Sep 2017 14:59:48 +0200","Message-Id":"<20170925125948.13507-4-antoine.tenart@free-electrons.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170925125948.13507-1-antoine.tenart@free-electrons.com>","References":"<20170925125948.13507-1-antoine.tenart@free-electrons.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This patch stops the internal MAC Tx clock from being enabled as the\ninternal clock isn't used. The definition used for the bit controlling\nthis behaviour is renamed as well as it was wrongly named (bit 4 of\nGMAC_CTRL_2_REG).\n\nFixes: 3919357fb0bb (\"net: mvpp2: initialize the GMAC when using a port\")\nSigned-off-by: Antoine Tenart \n---\n drivers/net/ethernet/marvell/mvpp2.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c\nindex b2f99df81e9c..161055564720 100644\n--- a/drivers/net/ethernet/marvell/mvpp2.c\n+++ b/drivers/net/ethernet/marvell/mvpp2.c\n@@ -333,7 +333,7 @@\n #define MVPP2_GMAC_INBAND_AN_MASK\t\tBIT(0)\n #define MVPP2_GMAC_FLOW_CTRL_MASK\t\tGENMASK(2, 1)\n #define MVPP2_GMAC_PCS_ENABLE_MASK\t\tBIT(3)\n-#define MVPP2_GMAC_PORT_RGMII_MASK\t\tBIT(4)\n+#define MVPP2_GMAC_INTERNAL_CLK_MASK\tBIT(4)\n #define MVPP2_GMAC_DISABLE_PADDING\t\tBIT(5)\n #define MVPP2_GMAC_PORT_RESET_MASK\t\tBIT(6)\n #define MVPP2_GMAC_AUTONEG_CONFIG\t\t0xc\n@@ -4599,7 +4599,6 @@ static void mvpp2_port_mii_gmac_configure(struct mvpp2_port *port)\n \t val |= MVPP2_GMAC_INBAND_AN_MASK | MVPP2_GMAC_PCS_ENABLE_MASK;\n \t} else if (phy_interface_mode_is_rgmii(port->phy_interface)) {\n \t\tval &= ~MVPP2_GMAC_PCS_ENABLE_MASK;\n-\t\tval |= MVPP2_GMAC_PORT_RGMII_MASK;\n \t}\n \twritel(val, port->base + MVPP2_GMAC_CTRL_2_REG);\n \n","prefixes":["net","v2","3/3"]}