{"id":818202,"url":"http://patchwork.ozlabs.org/api/patches/818202/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925112917.21340-4-dgilbert@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170925112917.21340-4-dgilbert@redhat.com>","list_archive_url":null,"date":"2017-09-25T11:29:14","name":"[v2,3/6] migration: Check field save returns","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c27969d39510c9451cf5098d89483dcb0963864e","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/?format=json","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170925112917.21340-4-dgilbert@redhat.com/mbox/","series":[{"id":4941,"url":"http://patchwork.ozlabs.org/api/series/4941/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4941","date":"2017-09-25T11:29:11","name":"migration: let pre_save fail","version":2,"mbox":"http://patchwork.ozlabs.org/series/4941/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818202/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818202/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y12265v9Dz9t67\n\tfor ;\n\tMon, 25 Sep 2017 21:30:22 +1000 (AEST)","from localhost ([::1]:41791 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwRae-0007yY-Rx\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 07:30:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59826)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwRZs-0007xZ-Rv\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:29:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwRZs-00021r-0q\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:29:32 -0400","from mx1.redhat.com ([209.132.183.28]:53990)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwRZr-00021W-RX\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:29:31 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E8062C047B95;\n\tMon, 25 Sep 2017 11:29:30 +0000 (UTC)","from dgilbert-t530.redhat.com (ovpn-116-100.ams2.redhat.com\n\t[10.36.116.100])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6ECD96C410;\n\tMon, 25 Sep 2017 11:29:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E8062C047B95","From":"\"Dr. David Alan Gilbert (git)\" ","To":"qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com,\n\tfamz@redhat.com","Date":"Mon, 25 Sep 2017 12:29:14 +0100","Message-Id":"<20170925112917.21340-4-dgilbert@redhat.com>","In-Reply-To":"<20170925112917.21340-1-dgilbert@redhat.com>","References":"<20170925112917.21340-1-dgilbert@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 25 Sep 2017 11:29:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 3/6] migration: Check field save returns","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, cohuck@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: \"Dr. David Alan Gilbert\" \n\nCheck the return values from vmstate_save_state for fields and also the\nreturn values from 'put' for fields that use that.\n\nSigned-off-by: Dr. David Alan Gilbert \n---\n migration/vmstate.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex ae8abd3c32..848e8448c6 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -347,6 +347,7 @@ int vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd,\n }\n for (i = 0; i < n_elems; i++) {\n void *curr_elem = first_elem + size * i;\n+ ret = 0;\n \n vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems);\n old_offset = qemu_ftell_fast(f);\n@@ -357,11 +358,19 @@ int vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd,\n if (!curr_elem && size) {\n /* if null pointer write placeholder and do not follow */\n assert(field->flags & VMS_ARRAY_OF_POINTER);\n- vmstate_info_nullptr.put(f, curr_elem, size, NULL, NULL);\n+ ret = vmstate_info_nullptr.put(f, curr_elem, size, NULL,\n+ NULL);\n } else if (field->flags & VMS_STRUCT) {\n- vmstate_save_state(f, field->vmsd, curr_elem, vmdesc_loop);\n+ ret = vmstate_save_state(f, field->vmsd, curr_elem,\n+ vmdesc_loop);\n } else {\n- field->info->put(f, curr_elem, size, field, vmdesc_loop);\n+ ret = field->info->put(f, curr_elem, size, field,\n+ vmdesc_loop);\n+ }\n+ if (ret) {\n+ error_report(\"Save of field %s/%s failed\",\n+ vmsd->name, field->name);\n+ return ret;\n }\n \n written_bytes = qemu_ftell_fast(f) - old_offset;\n","prefixes":["v2","3/6"]}