{"id":818037,"url":"http://patchwork.ozlabs.org/api/patches/818037/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170925032941.14586-9-tom@quantonium.net/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170925032941.14586-9-tom@quantonium.net>","list_archive_url":null,"date":"2017-09-25T03:29:37","name":"[v3,net-next,08/12] gtp: Call function to update path mtu","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"96c326e18c6ce0bcc4d1bc7a1386b563cdce6d8c","submitter":{"id":72064,"url":"http://patchwork.ozlabs.org/api/people/72064/?format=json","name":"Tom Herbert","email":"tom@quantonium.net"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170925032941.14586-9-tom@quantonium.net/mbox/","series":[{"id":4865,"url":"http://patchwork.ozlabs.org/api/series/4865/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4865","date":"2017-09-25T03:29:29","name":"gtp: Additional feature support - Part I","version":3,"mbox":"http://patchwork.ozlabs.org/series/4865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/818037/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/818037/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=quantonium-net.20150623.gappssmtp.com\n\theader.i=@quantonium-net.20150623.gappssmtp.com\n\theader.b=\"faC8A0GM\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0qNJ1T2mz9t3t\n\tfor ;\n\tMon, 25 Sep 2017 13:30:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933054AbdIYDaU (ORCPT );\n\tSun, 24 Sep 2017 23:30:20 -0400","from mail-pf0-f173.google.com ([209.85.192.173]:56614 \"EHLO\n\tmail-pf0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933022AbdIYDaS (ORCPT\n\t); Sun, 24 Sep 2017 23:30:18 -0400","by mail-pf0-f173.google.com with SMTP id g65so3132230pfe.13\n\tfor ; Sun, 24 Sep 2017 20:30:18 -0700 (PDT)","from localhost.localdomain (c-73-162-13-107.hsd1.ca.comcast.net.\n\t[73.162.13.107]) by smtp.gmail.com with ESMTPSA id\n\tj2sm9112907pgn.26.2017.09.24.20.30.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Sep 2017 20:30:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=quantonium-net.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=c9b+Zk1pz2iqm+GXKGvvZ1oRizQA5GgRF8hIJCjrWB0=;\n\tb=faC8A0GMWkzvCkA7THHt6Y5Pe827okR/RNoZsjn8RxGXltKZb+bmd2kiUtpVRsRBWh\n\t7Ra3KlloB46ZOOWsXvuHSKb6cXwEKVN0ykl4hOYm4j+1DOOVCIWJbW4yXiywMc2ldz57\n\tKKAlh+GQx5ztFp2EgIId/2NsUSdgaygwr8eqWmK6O0fOs6P6/ThjjxU6uKWfjZ1RGlMg\n\t3ZeVi4FAXgf7MEOsk+PoodPNz8Z6KJThU3GmFBdi1XPnSHILsxTNXNfnyL+xAyd/K7sZ\n\tawA9E5Qv1nIp3xDuo6mQXM+Qt8h0QG1mJLmE9kdxwQpG7qlMFc4QkcLtZgIk2jEVK5A/\n\td/Mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=c9b+Zk1pz2iqm+GXKGvvZ1oRizQA5GgRF8hIJCjrWB0=;\n\tb=O1nkosoqLy79c+QLmZ4TFOtpPQAadTbRZbkMmTncRTvwZ+V1ZSJ1VFhfd6/L+tQaAR\n\tZyQp3A7Xxu7jpUeybMy/Qukp9QCNiYM/f9PRlxT7dwcvrlevI3ZelZ17YVumHBNAuM2G\n\tvEA67NNEDuLKhcE2R/REBCjOJMcIs5ssCTPXimdDPYOFV4CPXbZsLP5673z/csP+iSyM\n\tk3tiAUYhZoa7VwjIr39Fgavgk7hXzabo1RbXDLykK2b+UWIRVu0yfYxZq7wovyxoBr8B\n\t2J1s8R5O9zw3TbdM3AWUzJ25/tU6heXYYI/h6WYlJDsW+T2nErAOH3pv+DhhqT3nBuoS\n\tvNaA==","X-Gm-Message-State":"AHPjjUg589ihn7j9T+vHKmGd3B4w1T4ALleAjlK7QtH1ecs1qFNBMyub\n\t9UOS0T78ID6BHj9QkCagsQ3Kwg==","X-Google-Smtp-Source":"AOwi7QBanKcRNHlp7hZ7lFNERc5foVVlhHHfPDaoCnVAhwSkMavQkoLGI4brmEqAOxv4XRBVKgdkYg==","X-Received":"by 10.84.132.34 with SMTP id 31mr6193721ple.225.1506310217998;\n\tSun, 24 Sep 2017 20:30:17 -0700 (PDT)","From":"Tom Herbert ","To":"davem@davemloft.net","Cc":"pablo@netfilter.org, laforge@gnumonks.org, aschultz@tpip.net,\n\tnetdev@vger.kernel.org, rohit@quantonium.net,\n\tTom Herbert ","Subject":"[PATCH v3 net-next 08/12] gtp: Call function to update path mtu","Date":"Sun, 24 Sep 2017 20:29:37 -0700","Message-Id":"<20170925032941.14586-9-tom@quantonium.net>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170925032941.14586-1-tom@quantonium.net>","References":"<20170925032941.14586-1-tom@quantonium.net>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Replace mtu handling with call to __iptunnel_update_pmtu.\n\nSigned-off-by: Tom Herbert \n---\n drivers/net/gtp.c | 36 ++++++------------------------------\n 1 file changed, 6 insertions(+), 30 deletions(-)","diff":"diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c\nindex a6e2e0a1f424..bbb08f8849d3 100644\n--- a/drivers/net/gtp.c\n+++ b/drivers/net/gtp.c\n@@ -53,6 +53,7 @@ struct pdp_ctx {\n \t\t} v1;\n \t} u;\n \tu8\t\t\tgtp_version;\n+\tu8\t\t\thlen;\n \tu16\t\t\taf;\n \n \tstruct in_addr\t\tms_addr_ip4;\n@@ -467,8 +468,6 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,\n \tstruct iphdr *iph;\n \tstruct sock *sk;\n \t__be32 saddr;\n-\t__be16 df;\n-\tint mtu;\n \n \t/* Read the IP destination address and resolve the PDP context.\n \t * Prepend PDP header with TEI/TID from PDP ctx.\n@@ -514,37 +513,12 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,\n \n \tskb_dst_drop(skb);\n \n-\t/* This is similar to tnl_update_pmtu(). */\n-\tdf = iph->frag_off;\n-\tif (df) {\n-\t\tmtu = dst_mtu(&rt->dst) - dev->hard_header_len -\n-\t\t\tsizeof(struct iphdr) - sizeof(struct udphdr);\n-\t\tswitch (pctx->gtp_version) {\n-\t\tcase GTP_V0:\n-\t\t\tmtu -= sizeof(struct gtp0_header);\n-\t\t\tbreak;\n-\t\tcase GTP_V1:\n-\t\t\tmtu -= sizeof(struct gtp1_header);\n-\t\t\tbreak;\n-\t\t}\n-\t} else {\n-\t\tmtu = dst_mtu(&rt->dst);\n-\t}\n-\n-\trt->dst.ops->update_pmtu(&rt->dst, NULL, skb, mtu);\n-\n-\tif (!skb_is_gso(skb) && (iph->frag_off & htons(IP_DF)) &&\n-\t mtu < ntohs(iph->tot_len)) {\n-\t\tnetdev_dbg(dev, \"packet too big, fragmentation needed\\n\");\n-\t\tmemset(IPCB(skb), 0, sizeof(*IPCB(skb)));\n-\t\ticmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,\n-\t\t\t htonl(mtu));\n-\t\tgoto err_rt;\n-\t}\n-\n \tgtp_set_pktinfo_ipv4(pktinfo, sk, iph, pctx, rt, &fl4, dev);\n \tgtp_push_header(skb, pktinfo);\n \n+\t__iptunnel_update_pmtu(dev, skb, &rt->dst, !!iph->frag_off, iph,\n+\t\t\t pctx->hlen, pctx->peer_addr_ip4.s_addr);\n+\n \treturn 0;\n err_rt:\n \tip_rt_put(rt);\n@@ -915,10 +889,12 @@ static void ipv4_pdp_fill(struct pdp_ctx *pctx, struct genl_info *info)\n \t\t */\n \t\tpctx->u.v0.tid = nla_get_u64(info->attrs[GTPA_TID]);\n \t\tpctx->u.v0.flow = nla_get_u16(info->attrs[GTPA_FLOW]);\n+\t\tpctx->hlen = sizeof(struct udphdr) + sizeof(struct gtp0_header);\n \t\tbreak;\n \tcase GTP_V1:\n \t\tpctx->u.v1.i_tei = nla_get_u32(info->attrs[GTPA_I_TEI]);\n \t\tpctx->u.v1.o_tei = nla_get_u32(info->attrs[GTPA_O_TEI]);\n+\t\tpctx->hlen = sizeof(struct udphdr) + sizeof(struct gtp1_header);\n \t\tbreak;\n \tdefault:\n \t\tbreak;\n","prefixes":["v3","net-next","08/12"]}