{"id":817976,"url":"http://patchwork.ozlabs.org/api/patches/817976/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-14-xypron.glpk@gmx.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170924195716.3433-14-xypron.glpk@gmx.de>","list_archive_url":null,"date":"2017-09-24T19:57:12","name":"[U-Boot,13/17] efi_loader: size fields in SimpleNetworkProtocol","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"81dc2d6d702445a8987834d03c15c4ef96724856","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/?format=json","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-14-xypron.glpk@gmx.de/mbox/","series":[{"id":4841,"url":"http://patchwork.ozlabs.org/api/series/4841/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=4841","date":"2017-09-24T19:57:03","name":"efi_loader: Simple Network Protocol","version":1,"mbox":"http://patchwork.ozlabs.org/series/4841/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817976/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817976/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0dSW6nnQz9t1t\n\tfor ;\n\tMon, 25 Sep 2017 06:03:23 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 81B6FC2214A; Sun, 24 Sep 2017 20:01:04 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DC256C22154;\n\tSun, 24 Sep 2017 19:58:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid AA5C2C2213A; Sun, 24 Sep 2017 19:58:18 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id ED561C21C2B\n\tfor ; Sun, 24 Sep 2017 19:58:14 +0000 (UTC)","from workstation4.fritz.box ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id\n\t0LdKs1-1dWG8C1HQP-00iXH5; Sun, 24 Sep 2017 21:57:33 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","From":"Heinrich Schuchardt ","To":"Alexander Graf ","Date":"Sun, 24 Sep 2017 21:57:12 +0200","Message-Id":"<20170924195716.3433-14-xypron.glpk@gmx.de>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170924195716.3433-1-xypron.glpk@gmx.de>","References":"<20170924195716.3433-1-xypron.glpk@gmx.de>","X-Provags-ID":"V03:K0:o+ee/Vyz0ImmREKMXo41fDDmYQm6JnK0tEn1hl7T2PvH86KcSid\n\t7n7+rOs4ptBhOjD6mA7MBX0oBmNkR+HjRSjE58DKlLg88xqIZ9gAcNWla1ZNEin3nr4VfmO\n\tSG4ct98xY+BQV1IrF/Zt4tMZJsRtx9IuqqIRzrDpumpqFtadfEwmoDpn+gfsvgIKJA3jwGv\n\t6p9RHEg4HmjksiKC5eItw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:FPJL196reTM=:hDgNmd9RTuSP4eXySFe8rD\n\tfoPKQzZFfjEUpdW/8+P/0Eq9SoIu0qdWT2ABDPb3Fzn9zo56sJqMY37zNDLYNNzZlYBcYS6W7\n\ttDr5aJsLLYpOP0J5JKe6ccTl/lpZ3ZZdvZiN3qJW1N+SA3V11dGGV5qBKLq7A/NB640/SC65i\n\tdOyJPFBPNMWdR6npBua6STbxLlZ+g35luFsrbe3V6mqkgb9E8KRToFOwjZ3Hur1LBd/vVge6j\n\ta57Q+Che3LhhnnKXLpIdJ8S9sTcq+4MIT1T/c2cQDY+U89Zqf7H81y3ZcDRqGYXGoJORPSxuu\n\thSrXeYUaoLmnRZkpIj3YodBGudToYCW2wsRiYkJ/TTBTN2CNv5O/OrdtRL0dEgkg8UJVvNd1J\n\tbuPCnBGPHImMsuFNwigpwuH0kEL1ru5csjn4BoxD2YKtnnOMECy+0H2J6K5D2xUzKxhr46NqN\n\tmTWaXdaUVR3lI98ZS5qeiQGRCTwrocMtFvpynF2Rr++j6E/aR4qLVZv4qOYiEWtsodOg3jKWE\n\t98V+aZ3HhzjDzJaed0/Kp3yaykuZp6U6D1t7TEncggNAL0TBUbrTARfRqzOHx4JpJcfuBf5Cu\n\tf+u4uVKj1DliWlJum8YnJjppWC0b2hr37AKu7xI7rDXIf1YjuYsgo2SVjLk+wwLFLPjq5qfxL\n\t5V1LC30ok6N+bvBsw4p3q/gnaGwuj+Avh/N1kh7pGKU0/ANUNTgrxUN96t3tGGu6CTTk/2SA3\n\tXDI9lFnU8Pz4tNCXkiEIlrCzsTZ2t7t+ssfZ+W1l7HYfLsreeA0sEknzgR3yRsU7c17ztNEXI\n\tLT7QQ8puw2HcFv8zsAb9ur0dOYHNw==","Cc":"Heinrich Schuchardt , u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 13/17] efi_loader: size fields in\n\tSimpleNetworkProtocol","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The size fields in the Simple Network Protocol are all\nUINTN in the UEFI spec. So use size_t.\n\nProvide a function description of the receive function.\n\nSigned-off-by: Heinrich Schuchardt \n---\n include/efi_api.h | 4 ++--\n lib/efi_loader/efi_net.c | 24 ++++++++++++++++++++----\n 2 files changed, 22 insertions(+), 6 deletions(-)","diff":"diff --git a/include/efi_api.h b/include/efi_api.h\nindex 1f349db246..a9a6494afe 100644\n--- a/include/efi_api.h\n+++ b/include/efi_api.h\n@@ -636,11 +636,11 @@ struct efi_simple_network\n \tefi_status_t (EFIAPI *get_status)(struct efi_simple_network *this,\n \t\t\tu32 *int_status, void **txbuf);\n \tefi_status_t (EFIAPI *transmit)(struct efi_simple_network *this,\n-\t\t\tulong header_size, ulong buffer_size, void *buffer,\n+\t\t\tsize_t header_size, size_t buffer_size, void *buffer,\n \t\t\tstruct efi_mac_address *src_addr,\n \t\t\tstruct efi_mac_address *dest_addr, u16 *protocol);\n \tefi_status_t (EFIAPI *receive)(struct efi_simple_network *this,\n-\t\t\tulong *header_size, ulong *buffer_size, void *buffer,\n+\t\t\tsize_t *header_size, size_t *buffer_size, void *buffer,\n \t\t\tstruct efi_mac_address *src_addr,\n \t\t\tstruct efi_mac_address *dest_addr, u16 *protocol);\n \tstruct efi_event *wait_for_packet;\ndiff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c\nindex 89dc2006f1..5344210fff 100644\n--- a/lib/efi_loader/efi_net.c\n+++ b/lib/efi_loader/efi_net.c\n@@ -150,12 +150,13 @@ static efi_status_t EFIAPI efi_net_get_status(struct efi_simple_network *this,\n }\n \n static efi_status_t EFIAPI efi_net_transmit(struct efi_simple_network *this,\n-\t\tulong header_size, ulong buffer_size, void *buffer,\n+\t\tsize_t header_size, size_t buffer_size, void *buffer,\n \t\tstruct efi_mac_address *src_addr,\n \t\tstruct efi_mac_address *dest_addr, u16 *protocol)\n {\n-\tEFI_ENTRY(\"%p, %lx, %lx, %p, %p, %p, %p\", this, header_size,\n-\t\t buffer_size, buffer, src_addr, dest_addr, protocol);\n+\tEFI_ENTRY(\"%p, %lu, %lu, %p, %p, %p, %p\", this,\n+\t\t (unsigned long)header_size, (unsigned long)buffer_size,\n+\t\t buffer, src_addr, dest_addr, protocol);\n \n \tefi_timer_check();\n \n@@ -182,8 +183,23 @@ static void efi_net_push(void *pkt, int len)\n \tnew_rx_packet = true;\n }\n \n+/*\n+ * Receive a packet from a network interface.\n+ *\n+ * This function implements the Receive service of the Simple Network Protocol.\n+ * See the UEFI spec for details.\n+ *\n+ * @this\tthe instance of the Simple Network Protocol\n+ * @header_size\tsize of the media header\n+ * @buffer_size\tsize of the buffer to receive the packet\n+ * @buffer\tbuffer to receive the packet\n+ * @src_addr\tsource MAC address\n+ * @dest_addr\tdestination MAC address\n+ * @protocol\tprotocol\n+ * @return\tstatus code\n+ */\n static efi_status_t EFIAPI efi_net_receive(struct efi_simple_network *this,\n-\t\tulong *header_size, ulong *buffer_size, void *buffer,\n+\t\tsize_t *header_size, size_t *buffer_size, void *buffer,\n \t\tstruct efi_mac_address *src_addr,\n \t\tstruct efi_mac_address *dest_addr, u16 *protocol)\n {\n","prefixes":["U-Boot","13/17"]}