{"id":817973,"url":"http://patchwork.ozlabs.org/api/patches/817973/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-13-xypron.glpk@gmx.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170924195716.3433-13-xypron.glpk@gmx.de>","list_archive_url":null,"date":"2017-09-24T19:57:11","name":"[U-Boot,12/17] efi_loader: fix efi_net_get_status","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"48cb0de37e3cb6abfc471eb702c322eda2cde56a","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/?format=json","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-13-xypron.glpk@gmx.de/mbox/","series":[{"id":4841,"url":"http://patchwork.ozlabs.org/api/series/4841/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=4841","date":"2017-09-24T19:57:03","name":"efi_loader: Simple Network Protocol","version":1,"mbox":"http://patchwork.ozlabs.org/series/4841/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817973/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817973/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0dQQ4dMXz9t1t\n\tfor ;\n\tMon, 25 Sep 2017 06:01:34 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 57CECC220D2; Sun, 24 Sep 2017 20:00:18 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2D477C22142;\n\tSun, 24 Sep 2017 19:58:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8E153C22106; Sun, 24 Sep 2017 19:58:20 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id B035EC22127\n\tfor ; Sun, 24 Sep 2017 19:58:16 +0000 (UTC)","from workstation4.fritz.box ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id\n\t0M7m0a-1dA2KS45ei-00vLB0; Sun, 24 Sep 2017 21:57:33 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","From":"Heinrich Schuchardt ","To":"Alexander Graf ","Date":"Sun, 24 Sep 2017 21:57:11 +0200","Message-Id":"<20170924195716.3433-13-xypron.glpk@gmx.de>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170924195716.3433-1-xypron.glpk@gmx.de>","References":"<20170924195716.3433-1-xypron.glpk@gmx.de>","X-Provags-ID":"V03:K0:SzBov9O31V61Hu5eCuGqjAW7LjUnqaMij3GyLevlW1dN6ZUtTp2\n\tARAOSHiRiZS7i5lyFppEELqb0/GVh+CCVdoMC7ya1fmCGT1i5VfIMAwdpxfRp7RZqwZnELr\n\thYI2FC7HBDuPgD5Burh+t9kWlkcVHwsLvhVDZ37Nm27/YwXFL663y5LJc4/Lw/PySYPGzXX\n\tgRonFxRxRGJuxZ//GN8hw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:IIF8wHI4c7Q=:IAa5YIaL8cE9Fn8GIe9S5G\n\t8hB1BbELBsNRCEe+DBuglpRUVZ2x2+wTQ/bqmNmDEMVwyFoTXAAFBsgRbIZ7uQQaRqEy9L1A3\n\tav/HMyxXEHNVzBIvoLwmWQBK/kGti8KZoGcRe/RG83kXwBliuq5Bi5latW5D3m5z1WwOtKL5k\n\tOdVU93u97NQIubD/zfFk/zKQSl/l5k1dTiWM0M1h02q6vO5fPDugP6VBSbPN+IKm8Z3FEjp9r\n\tBcXFMFhO77a1V8F6HFmcoU9iT6Pn7AcPiaSEhfq4Yz05WrgYGCFdNgWPBzZWLdOaiUK2dj11P\n\tEJbXFfNaNgDVc7wR6ElkfFMlReyxz9vLhbYjuMbTDRmNHNOS7MHnKIN+nhe5zguqkyBtW1dhc\n\t/HpA+a9nVFEjrRohnRd7s8FvhUmW1sGHDZDV4gi5uasvx3rD7NRF2VnmhooTMpOGaGOB6LxNz\n\tM8f8HFHuvQxhkppQrokWbNWjkJsCfIW4A9xkjO2lBUkYJb9EE6EOzio6KKD10TXeS+/7DnYXD\n\tre1VfxPtizPBERvqW8wYZvGoZPiK42RJlbXwck2C9DiSzUrwbFGZzYzueZlBOUVNF6IX+2PWB\n\tc3+AVl390fNsA6+1Dny5oWpoz5xdMdEjd3c07CuNi3/Z2T43agTLo1t9FsDREi3mSYS5mttrB\n\tgJ5AW/rytCZNupGWfqPrELUYdi8KgUFS1aGgmT0obSiHcE1J5cQ6c14wvfzDiI49QSplTTaX4\n\tJB/3cQESgEKqfiV7MpcNJ7xAvuzDCkz3WnEL5158dn+ko/J+jk8t7XKCNX8BwMPGLn8Kff3XU\n\tKm/KnV9NTcql+Wwqmqml+j96J+f9g==","Cc":"Heinrich Schuchardt , u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 12/17] efi_loader: fix efi_net_get_status","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The returned interrupt status was wrong.\n\nAs out transmit buffer is empty we need to always set\nEFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT.\n\nWhen we have received a packet we need to set\nEFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT.\n\nFurthermore we should call efi_timer_check() to handle events.\n\nSigned-off-by: Heinrich Schuchardt \n---\n include/efi_api.h | 6 ++++++\n lib/efi_loader/efi_net.c | 11 ++++++++---\n 2 files changed, 14 insertions(+), 3 deletions(-)","diff":"diff --git a/include/efi_api.h b/include/efi_api.h\nindex 2f31464cb3..1f349db246 100644\n--- a/include/efi_api.h\n+++ b/include/efi_api.h\n@@ -600,6 +600,12 @@ struct efi_simple_network_mode {\n #define EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS 0x08\n #define EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS_MULTICAST 0x10\n \n+/* interrupt status bit mask */\n+#define EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT\t0x01\n+#define EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT\t0x02\n+#define EFI_SIMPLE_NETWORK_COMMAND_INTERRUPT\t0x04\n+#define EFI_SIMPLE_NETWORK_SOFTWARE_INTERRUPT\t0x08\n+\n /* revision of the simple network protocol */\n #define EFI_SIMPLE_NETWORK_PROTOCOL_REVISION\t0x00010000\n \ndiff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c\nindex 72a023803d..89dc2006f1 100644\n--- a/lib/efi_loader/efi_net.c\n+++ b/lib/efi_loader/efi_net.c\n@@ -133,9 +133,14 @@ static efi_status_t EFIAPI efi_net_get_status(struct efi_simple_network *this,\n {\n \tEFI_ENTRY(\"%p, %p, %p\", this, int_status, txbuf);\n \n-\t/* We send packets synchronously, so nothing is outstanding */\n-\tif (int_status)\n-\t\t*int_status = 0;\n+\tefi_timer_check();\n+\n+\tif (int_status) {\n+\t\t/* We send packets synchronously, so nothing is outstanding */\n+\t\t*int_status = EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT;\n+\t\tif (new_rx_packet)\n+\t\t\t*int_status |= EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT;\n+\t}\n \tif (txbuf)\n \t\t*txbuf = new_tx_packet;\n \n","prefixes":["U-Boot","12/17"]}