{"id":817971,"url":"http://patchwork.ozlabs.org/api/patches/817971/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-3-xypron.glpk@gmx.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170924195716.3433-3-xypron.glpk@gmx.de>","list_archive_url":null,"date":"2017-09-24T19:57:01","name":"[U-Boot,02/17] efi_loader: parameters of CopyMem and SetMem","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"0171226256715f3f7c791207595a69d54f852383","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/?format=json","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-3-xypron.glpk@gmx.de/mbox/","series":[{"id":4841,"url":"http://patchwork.ozlabs.org/api/series/4841/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=4841","date":"2017-09-24T19:57:03","name":"efi_loader: Simple Network Protocol","version":1,"mbox":"http://patchwork.ozlabs.org/series/4841/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817971/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817971/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0dPP4hgQz9t1t\n\tfor ;\n\tMon, 25 Sep 2017 06:00:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5F9DCC22147; Sun, 24 Sep 2017 19:59:03 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 66FAAC21C2B;\n\tSun, 24 Sep 2017 19:58:30 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A09E1C2212D; Sun, 24 Sep 2017 19:58:19 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lists.denx.de (Postfix) with ESMTPS id 3B5BAC220E5\n\tfor ; Sun, 24 Sep 2017 19:58:16 +0000 (UTC)","from workstation4.fritz.box ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id\n\t0M7DVi-1dBgDv2cDe-00wz4K; Sun, 24 Sep 2017 21:57:29 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","From":"Heinrich Schuchardt ","To":"Alexander Graf ","Date":"Sun, 24 Sep 2017 21:57:01 +0200","Message-Id":"<20170924195716.3433-3-xypron.glpk@gmx.de>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170924195716.3433-1-xypron.glpk@gmx.de>","References":"<20170924195716.3433-1-xypron.glpk@gmx.de>","X-Provags-ID":"V03:K0:54UCKfhK5kWsdyNiVmraWO2OOpyvIUkC8o1vopU27U6I/tU2TT5\n\tb/de3QnU3clptqVnPHAnL823mgHGRdVdMoktgMGUqFQLqh/0mB4ikHt7210+hchqJkFgmqU\n\tnO0h0BtYFJspj9spq/wWn/o+ZhDLariTgiajTjhaZbD59/2Cuxaq74is3xB4cJH4/kRB8+v\n\tFxDHIMG/h7GGXf7VGWoVw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:NQk1DX+/y9k=:vCjZQQSpbaG1prKuk4a5O0\n\taYA+vqbcHcZCNksr6CQSAJbaJ06mu6wUJRQzYaYz4WtVMRye6nDIlKHwDmrs7aH54FofNTuJ7\n\txcj2ImIZEZ3sFrM0DWMsINKfPP4F5C1XoRuxe4qhLM3bEkHV03pqKVTYeNsROULDJmSQ5qgyT\n\ts0JegScIbGLcC9/BIEr5EvkiWNw9GsvlNbn3NA2IVozVMkZkZX5KU+jIXjAEeHqdJ1lhJvAc5\n\t0nEhZTlZdPFA8pVvaMJH/RsBZGazAYy1x92our5o1NcFRJfe8fNaH7DI3k2lq6GNAF14Gjna0\n\tLuDaiYoGc8ayirHvr/VMp0SbZubT6E9W0qhydfdMvT006x3ex/g2yxhjQ8ZrZe8SdqmDyV8+g\n\teYpub5ZgjFZxhhHCEG8CEXdFNIhTQ4yGw8keHQzdA9pYKBjH3f7oAuUSjixRXANgxORY1j+lg\n\tJzJTrLvnjknYDRn71jtmMCxtItGUqFeqYgAaZ5aH2jfKJVn2VD3ZJEMWrTbUxzR7Z+YPljERc\n\tfBi/58h9yjgpxCco+C4OTSpDZwiEVHUoUoxuRbgdOobmXxF0qu+U6aXV7NZeKqz5C3B5/dq/U\n\txy62ckRS4tyUL+oW/yZbLDe9ay1P60De2/sY+b02XNyG28Hw0RLRvl65EKtUmmUs84UMI/hGd\n\t2dt6QaEKxtplr7fh9VMzHZDYgdTes9WeeaerhenN6MQtRxYYqUFDYY6hG/dTzMdsDGkAIh0OV\n\tmVpm+b2Vnp/IvKp7roDPlYlva+CbdrBWMotu+k3DhTqV11/OZSaC/6IyG+BRuR65ahJp0tKvQ\n\twSoxnoyxv7H93bSIawgAlHoq3iilw==","Cc":"Heinrich Schuchardt , u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 02/17] efi_loader: parameters of CopyMem and SetMem","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The UEFI spec defines the length parameters of CopyMem and SetMem\nas UINTN. We should size_t here.\n\nThe source buffer of CopyMem should be marked as const.\n\nSigned-off-by: Heinrich Schuchardt \n---\n include/efi_api.h | 7 +++----\n lib/efi_loader/efi_boottime.c | 10 +++++-----\n 2 files changed, 8 insertions(+), 9 deletions(-)","diff":"diff --git a/include/efi_api.h b/include/efi_api.h\nindex c3b9032a48..0b1a383e61 100644\n--- a/include/efi_api.h\n+++ b/include/efi_api.h\n@@ -156,10 +156,9 @@ struct efi_boot_services {\n \t\t\tvoid *handle, ...);\n \tefi_status_t (EFIAPI *calculate_crc32)(void *data,\n \t\t\tunsigned long data_size, uint32_t *crc32);\n-\tvoid (EFIAPI *copy_mem)(void *destination, void *source,\n-\t\t\tunsigned long length);\n-\tvoid (EFIAPI *set_mem)(void *buffer, unsigned long size,\n-\t\t\tuint8_t value);\n+\tvoid (EFIAPI *copy_mem)(void *destination, const void *source,\n+\t\t\tsize_t length);\n+\tvoid (EFIAPI *set_mem)(void *buffer, size_t size, uint8_t value);\n \tvoid *create_event_ex;\n };\n \ndiff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex 2c2620a46d..22e6e6c569 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -1877,10 +1877,10 @@ static efi_status_t EFIAPI efi_calculate_crc32(void *data,\n * @source\t\tsource of the copy operation\n * @length\t\tnumber of bytes to copy\n */\n-static void EFIAPI efi_copy_mem(void *destination, void *source,\n-\t\t\t\tunsigned long length)\n+static void EFIAPI efi_copy_mem(void *destination, const void *source,\n+\t\t\t\tsize_t length)\n {\n-\tEFI_ENTRY(\"%p, %p, %ld\", destination, source, length);\n+\tEFI_ENTRY(\"%p, %p, %ld\", destination, source, (unsigned long)length);\n \tmemcpy(destination, source, length);\n \tEFI_EXIT(EFI_SUCCESS);\n }\n@@ -1896,9 +1896,9 @@ static void EFIAPI efi_copy_mem(void *destination, void *source,\n * @size\t\tsize of buffer in bytes\n * @value\t\tbyte to copy to the buffer\n */\n-static void EFIAPI efi_set_mem(void *buffer, unsigned long size, uint8_t value)\n+static void EFIAPI efi_set_mem(void *buffer, size_t size, uint8_t value)\n {\n-\tEFI_ENTRY(\"%p, %ld, 0x%x\", buffer, size, value);\n+\tEFI_ENTRY(\"%p, %ld, 0x%x\", buffer, (unsigned long)size, value);\n \tmemset(buffer, value, size);\n \tEFI_EXIT(EFI_SUCCESS);\n }\n","prefixes":["U-Boot","02/17"]}