{"id":817968,"url":"http://patchwork.ozlabs.org/api/patches/817968/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-5-xypron.glpk@gmx.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170924195716.3433-5-xypron.glpk@gmx.de>","list_archive_url":null,"date":"2017-09-24T19:57:03","name":"[U-Boot,04/17] efi_loader: wrong type in wait_for_event","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"95064d8e84d6e1f8d97186245fc33bf875e2f1d1","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/?format=json","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170924195716.3433-5-xypron.glpk@gmx.de/mbox/","series":[{"id":4841,"url":"http://patchwork.ozlabs.org/api/series/4841/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=4841","date":"2017-09-24T19:57:03","name":"efi_loader: Simple Network Protocol","version":1,"mbox":"http://patchwork.ozlabs.org/series/4841/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817968/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817968/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0dLp5v8Cz9t1t\n\tfor ;\n\tMon, 25 Sep 2017 05:58:25 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4280CC22127; Sun, 24 Sep 2017 19:58:09 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5E9DBC21D9E;\n\tSun, 24 Sep 2017 19:58:07 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9ABA4C21D9E; Sun, 24 Sep 2017 19:58:05 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id 42B7FC21C2B\n\tfor ; Sun, 24 Sep 2017 19:58:05 +0000 (UTC)","from workstation4.fritz.box ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id\n\t0MWhRH-1dqXs916E7-00XrzB; Sun, 24 Sep 2017 21:57:30 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","From":"Heinrich Schuchardt ","To":"Alexander Graf ","Date":"Sun, 24 Sep 2017 21:57:03 +0200","Message-Id":"<20170924195716.3433-5-xypron.glpk@gmx.de>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170924195716.3433-1-xypron.glpk@gmx.de>","References":"<20170924195716.3433-1-xypron.glpk@gmx.de>","X-Provags-ID":"V03:K0:VNaLScouZmWf4uGeC5Z4Ikux9+2Cosf+AUdcWfKkVEN3UzoKeXl\n\tS+pSrHT22RCaAcIVfk1Hxo5D6m4APYigQRVxY7xW2zQDKs3W17fHwFNnpHygVXTyjYmTW1I\n\tlqiZRiCDbxwbGopBen2HY0yz/ITAnFk52C7EdKSefe4f+1ypOnJi8KLxEHqdanwWqy8nyyw\n\t9keF9ZY2cmM3okGCKy5LQ==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:FgngBK14cbA=:H0uAiLeyPWZuOYhlrndIQY\n\tarSlMQv1m6XDjM5dgsVgTlJlZ4qPRoAaBxcmzeOKVmCR7q+K3a+BS4/XZFi2gpbjEuKni/F9H\n\t+CYC/7HtlGuUFSvGFxRnXwQpe1ixvpPMdMyc7a+nylkvXAq9k/GnAQz+gnBrrAhNiivAkk/4v\n\t29dphelAe/kd38Ar9ZTxpGzD9NAs3CLdgMrdU+tfMRkObCbd+oicsABclZW2NDq+SIh3Ayy05\n\t18e9Ml59pOR7M5NfBkselGNubjIpPeRYE0W15WBb0B6GkgwScAuUY3Lg0Wr9Xg8eAyDYksgqb\n\thADea8RGz+heK00ZIvd7D45T5oHq2MMDlrZsEXAMrNGGjSbk4XP0wuNWy38lkBemzxqRLAzEW\n\tjgOm2gKx67EHL/fOcMCIjcwkvt0tggfTtPDytviE+DhGeshyrGN+UfKMky34q3CBcjppIsXFu\n\tG9sVRX4rLpAyW6tJHfWlNjte2R7ps1F4BHNzZ107cqZ6LbnrJ7W6GxKTBWKG1PUwy2RrRmuOI\n\t7da+NB+aYZfUODXlUe1oTeWXZUiDHE2hMKiG5+HorlaPkG09KxbgAshwjglLU3jnSzOZTnwON\n\tDY5s/+mWTR++GnsPCgRPnO+ZQG7E++ZwZbSLZrlJnN4rM3SCcrzy+Vi6CbJu6XNe33uSIL01L\n\tJajuVvKUnoS6afCac5F3VO104qYCRwmM93oRB26bLRoSMUGOcQCz/lHEjbZ3NysNrVsbChJBl\n\t8vODFgwJU9AaKeb1pukdLmKDs17Yb4GEC2CdDy8eivt55UZWr+HauynogOtyzBY/UtWY5tDsr\n\tqQrx4GMI4+scHgCHMvnI90m/FPoqg==","Cc":"Heinrich Schuchardt , u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 04/17] efi_loader: wrong type in wait_for_event","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The UEFI spec defines parameter index of WaitForEvent as UINTN*.\nSo we should use size_t here.\n\nI deliberately do not use UINTN because I hold a following patch\nthat will eliminate UINTN because uppercase types to not match\nthe U-Boot coding style.\n\nSigned-off-by: Heinrich Schuchardt \n---\n include/efi_api.h | 2 +-\n lib/efi_loader/efi_boottime.c | 2 +-\n lib/efi_selftest/efi_selftest_events.c | 2 +-\n lib/efi_selftest/efi_selftest_tpl.c | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/efi_api.h b/include/efi_api.h\nindex aa4306aac9..c44dc9d0cb 100644\n--- a/include/efi_api.h\n+++ b/include/efi_api.h\n@@ -71,7 +71,7 @@ struct efi_boot_services {\n \t\t\t\t\t enum efi_timer_delay type,\n \t\t\t\t\t uint64_t trigger_time);\n \tefi_status_t (EFIAPI *wait_for_event)(unsigned long number_of_events,\n-\t\t\tstruct efi_event **event, unsigned long *index);\n+\t\t\tstruct efi_event **event, size_t *index);\n \tefi_status_t (EFIAPI *signal_event)(struct efi_event *event);\n \tefi_status_t (EFIAPI *close_event)(struct efi_event *event);\n \tefi_status_t (EFIAPI *check_event)(struct efi_event *event);\ndiff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex b053b47262..0970d0ce7e 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -568,7 +568,7 @@ static efi_status_t EFIAPI efi_set_timer_ext(struct efi_event *event,\n */\n static efi_status_t EFIAPI efi_wait_for_event(unsigned long num_events,\n \t\t\t\t\t struct efi_event **event,\n-\t\t\t\t\t unsigned long *index)\n+\t\t\t\t\t size_t *index)\n {\n \tint i, j;\n \ndiff --git a/lib/efi_selftest/efi_selftest_events.c b/lib/efi_selftest/efi_selftest_events.c\nindex c4f66952b9..5cd182723d 100644\n--- a/lib/efi_selftest/efi_selftest_events.c\n+++ b/lib/efi_selftest/efi_selftest_events.c\n@@ -101,7 +101,7 @@ static int teardown(void)\n */\n static int execute(void)\n {\n-\tunsigned long index;\n+\tsize_t index;\n \tefi_status_t ret;\n \n \t/* Set 10 ms timer */\ndiff --git a/lib/efi_selftest/efi_selftest_tpl.c b/lib/efi_selftest/efi_selftest_tpl.c\nindex 90ace0f51e..6880463eda 100644\n--- a/lib/efi_selftest/efi_selftest_tpl.c\n+++ b/lib/efi_selftest/efi_selftest_tpl.c\n@@ -104,7 +104,7 @@ static int teardown(void)\n */\n static int execute(void)\n {\n-\tunsigned long index;\n+\tsize_t index;\n \tefi_status_t ret;\n \tUINTN old_tpl;\n \n","prefixes":["U-Boot","04/17"]}