{"id":817949,"url":"http://patchwork.ozlabs.org/api/patches/817949/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170924172212.10096-7-jiri@resnulli.us/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170924172212.10096-7-jiri@resnulli.us>","list_archive_url":null,"date":"2017-09-24T17:22:06","name":"[net-next,v2,06/12] net: mroute: Check if rule is a default rule","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"e709ce4008d919eca62c25123c9a2c0efc7debb0","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170924172212.10096-7-jiri@resnulli.us/mbox/","series":[{"id":4828,"url":"http://patchwork.ozlabs.org/api/series/4828/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4828","date":"2017-09-24T17:22:00","name":"mlxsw: Add support for offloading IPv4 multicast routes","version":2,"mbox":"http://patchwork.ozlabs.org/series/4828/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817949/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817949/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"iY/sahMw\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0YvV4cbCz9sRm\n\tfor ;\n\tMon, 25 Sep 2017 03:23:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752791AbdIXRXA (ORCPT );\n\tSun, 24 Sep 2017 13:23:00 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:36842 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752749AbdIXRWU (ORCPT\n\t); Sun, 24 Sep 2017 13:22:20 -0400","by mail-wr0-f195.google.com with SMTP id g50so66755wra.3\n\tfor ; Sun, 24 Sep 2017 10:22:20 -0700 (PDT)","from localhost (ip-89-177-136-69.net.upcbroadband.cz.\n\t[89.177.136.69]) by smtp.gmail.com with ESMTPSA id\n\t61sm3233632wre.44.2017.09.24.10.22.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 24 Sep 2017 10:22:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wn5mTOxJYfdtmybeaLQf6JLMAjc9sr6oACCunOKBVik=;\n\tb=iY/sahMwxLnMB7l5+VMC8e5Z9aT2Em7bV0w29LU0j8K/68iCuaZtByS8H7aHv8A01R\n\td/xXleexcLRcQ0FJCDMVlagm66Ffg3Ew8PL3UGlk/hpTMYFQ5Zkz2NzUKLvAjmg3B8zZ\n\ttVGJvV2+GJf7jdrW6aOMg07A3/OZJuOxk26cMZ4FRW4/a7AgYQmxHqC8KUowtdz0wWz9\n\t6bTBtks5yBz3DuU20ehqG7ltcj6/5Q9JCzOkdkvp74pcgHap52qCTDJU1AdE4Yf6ep9v\n\tyt4Sd9WwbJhco1ZVdFWwhw6cyFJWy49+2qJ0LYgBRMzCan7o5naY1qmfYt79902+T3N8\n\toZ5g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wn5mTOxJYfdtmybeaLQf6JLMAjc9sr6oACCunOKBVik=;\n\tb=QhG0SRoUoZJnyW4rzZVGy8obfkoAvKGqOs5dinyS24kqp2m2XL5wqcupGfzYSyN3VX\n\tJ5QgxtrtNTYtH2eL+89u+zxVcpi1ZNU2sDVn3ZZRMXGh+dwqSYkLXKhn/xZL1DUVuPkh\n\t2tZ3p8oZFib9IvQKwJ73ctGTljv1zon3Ywoy+SROeoge/nR04HhG5L9ov9JlAXVHzfmJ\n\tXTDSSoA7CMIAwcFd4JIJ4DZ4Huhi6DAYjVfjkDUdp7XTlgX+F8jxNxKYYKyfve4jGDbW\n\tV5IiU387uXeMI82Hdj0e6RAoi393EI+OXHTLp7nU80wij9UkfknYymmZaI24rctuTYM7\n\tfSaw==","X-Gm-Message-State":"AHPjjUit5dBso2B7hdlGyUh2fMgZcn1H9ZdO89d25vEdP5kW2ZzmiSHe\n\t53vinqeGr4FUahSUVrgAa5Ps2bkn","X-Google-Smtp-Source":"AOwi7QDQg38nWy0N+Gq92Ye5AfxTnzHkqn66JfH8f+qQmORy2MQOJOTwXhdhYYHbQj3LCVE/+kSjZg==","X-Received":"by 10.223.193.140 with SMTP id x12mr4009911wre.155.1506273739563;\n\tSun, 24 Sep 2017 10:22:19 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, yotamg@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com, nikolay@cumulusnetworks.com, andrew@lunn.ch","Subject":"[patch net-next v2 06/12] net: mroute: Check if rule is a default\n\trule","Date":"Sun, 24 Sep 2017 19:22:06 +0200","Message-Id":"<20170924172212.10096-7-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170924172212.10096-1-jiri@resnulli.us>","References":"<20170924172212.10096-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Yotam Gigi \n\nWhen the ipmr starts, it adds one default FIB rule that matches all packets\nand sends them to the DEFAULT (multicast) FIB table. A more complex rule\ncan be added by user to specify that for a specific interface, a packet\nshould be look up at either an arbitrary table or according to the l3mdev\nof the interface.\n\nFor drivers willing to offload the ipmr logic into a hardware but don't\nwant to offload all the FIB rules functionality, provide a function that\ncan indicate whether the FIB rule is the default multicast rule, thus only\none routing table is needed.\n\nThis way, a driver can register to the FIB notification chain, get\nnotifications about FIB rules added and trigger some kind of an internal\nabort mechanism when a non default rule is added by the user.\n\nSigned-off-by: Yotam Gigi \nReviewed-by: Ido Schimmel \nSigned-off-by: Jiri Pirko \n---\n include/linux/mroute.h | 7 +++++++\n net/ipv4/ipmr.c | 10 ++++++++++\n 2 files changed, 17 insertions(+)","diff":"diff --git a/include/linux/mroute.h b/include/linux/mroute.h\nindex 5566580..b072a84 100644\n--- a/include/linux/mroute.h\n+++ b/include/linux/mroute.h\n@@ -5,6 +5,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -19,6 +20,7 @@ int ip_mroute_getsockopt(struct sock *, int, char __user *, int __user *);\n int ipmr_ioctl(struct sock *sk, int cmd, void __user *arg);\n int ipmr_compat_ioctl(struct sock *sk, unsigned int cmd, void __user *arg);\n int ip_mr_init(void);\n+bool ipmr_rule_default(const struct fib_rule *rule);\n #else\n static inline int ip_mroute_setsockopt(struct sock *sock, int optname,\n \t\t\t\t char __user *optval, unsigned int optlen)\n@@ -46,6 +48,11 @@ static inline int ip_mroute_opt(int opt)\n {\n \treturn 0;\n }\n+\n+static inline bool ipmr_rule_default(const struct fib_rule *rule)\n+{\n+\treturn true;\n+}\n #endif\n \n struct vif_device {\ndiff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c\nindex 2a795d2..a714f55 100644\n--- a/net/ipv4/ipmr.c\n+++ b/net/ipv4/ipmr.c\n@@ -320,6 +320,16 @@ static unsigned int ipmr_rules_seq_read(struct net *net)\n }\n #endif\n \n+bool ipmr_rule_default(const struct fib_rule *rule)\n+{\n+#if IS_ENABLED(CONFIG_FIB_RULES)\n+\treturn fib_rule_matchall(rule) && rule->table == RT_TABLE_DEFAULT;\n+#else\n+\treturn true;\n+#endif\n+}\n+EXPORT_SYMBOL(ipmr_rule_default);\n+\n static inline int ipmr_hash_cmp(struct rhashtable_compare_arg *arg,\n \t\t\t\tconst void *ptr)\n {\n","prefixes":["net-next","v2","06/12"]}