{"id":817885,"url":"http://patchwork.ozlabs.org/api/patches/817885/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506244185-2129-4-git-send-email-Michal.Kalderon@cavium.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506244185-2129-4-git-send-email-Michal.Kalderon@cavium.com>","list_archive_url":null,"date":"2017-09-24T09:09:44","name":"[v2,net-next,3/4] qed: Fix maximum number of CQs for iWARP","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"16cfd43433efe08bad89466b3408fd22de388016","submitter":{"id":69904,"url":"http://patchwork.ozlabs.org/api/people/69904/?format=json","name":"Michal Kalderon","email":"Michal.Kalderon@cavium.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506244185-2129-4-git-send-email-Michal.Kalderon@cavium.com/mbox/","series":[{"id":4808,"url":"http://patchwork.ozlabs.org/api/series/4808/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4808","date":"2017-09-24T09:09:41","name":"qed: iWARP fixes and enhancements","version":2,"mbox":"http://patchwork.ozlabs.org/series/4808/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817885/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817885/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"Hkd7fMuY\"; \n\tdkim-atps=neutral","spf=none (sender IP is 50.232.66.26)\n\tsmtp.mailfrom=cavium.com; vger.kernel.org;\n\tdkim=none (message not signed)\n\theader.d=none; vger.kernel.org;\n\tdmarc=none action=none header.from=cavium.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0LzL2NY7z9tX6\n\tfor ;\n\tSun, 24 Sep 2017 19:10:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751993AbdIXJKd (ORCPT );\n\tSun, 24 Sep 2017 05:10:33 -0400","from mail-by2nam01on0082.outbound.protection.outlook.com\n\t([104.47.34.82]:53345\n\t\"EHLO NAM01-BY2-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751630AbdIXJK3 (ORCPT );\n\tSun, 24 Sep 2017 05:10:29 -0400","from DM5PR07CA0045.namprd07.prod.outlook.com (10.168.109.31) by\n\tBLUPR0701MB2082.namprd07.prod.outlook.com (10.163.122.152) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tSun, 24 Sep 2017 09:10:27 +0000","from BN1AFFO11FD008.protection.gbl (2a01:111:f400:7c10::102) by\n\tDM5PR07CA0045.outlook.office365.com (2603:10b6:3:16::31) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n\t15.20.56.11 via Frontend Transport; Sun, 24 Sep 2017 09:10:27 +0000","from CAEXCH02.caveonetworks.com (50.232.66.26) by\n\tBN1AFFO11FD008.mail.protection.outlook.com (10.58.52.68) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id\n\t15.20.35.14 via Frontend Transport; Sun, 24 Sep 2017 09:10:26 +0000","from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by\n\tCAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id\n\t14.2.347.0; Sun, 24 Sep 2017 02:10:24 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=tOf2r2lxMX9k2m5Cjn35+fQKX/OvrZeM0UyP50F4SZk=;\n\tb=Hkd7fMuY07xacqOvsSQH12WoVh4K2MqRpTr2lV3onjw9xg8RVrXAvb1o7ZsV5k9QgteDO1pe3jaLlm2KpMRGPXj+IBYecoKaXHTa7XxooSLx8ASLC1MmLFo5YudDWqBrIoU6LyFW5muKfgKoiOPqnIh7x+m4vQvgnO59ph/XThk=","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","From":"Michal Kalderon ","To":", , ","CC":", ,\n\tMichal Kalderon ,\n\tAriel Elior ","Subject":"[PATCH v2 net-next 3/4] qed: Fix maximum number of CQs for iWARP","Date":"Sun, 24 Sep 2017 12:09:44 +0300","Message-ID":"<1506244185-2129-4-git-send-email-Michal.Kalderon@cavium.com>","X-Mailer":"git-send-email 1.9.3","In-Reply-To":"<1506244185-2129-1-git-send-email-Michal.Kalderon@cavium.com>","References":"<1506244185-2129-1-git-send-email-Michal.Kalderon@cavium.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-EOPAttributedMessage":"0","X-Forefront-Antispam-Report":"CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(199003)(189002)(110136005)(86362001)(2950100002)(69596002)(356003)(189998001)(4326008)(77096006)(8936002)(2201001)(16586007)(72206003)(50466002)(316002)(81156014)(104016004)(47776003)(81166006)(8676002)(54906003)(305945005)(50986999)(5003940100001)(101416001)(48376002)(5660300001)(50226002)(36756003)(478600001)(105586002)(6666003)(106466001)(107886003)(76176999)(2906002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2082;\n\tH:CAEXCH02.caveonetworks.com; FPR:; SPF:None;\n\tPTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1;\n\tLANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; BN1AFFO11FD008;\n\t1:9lB3vZPNJy+ZmeTIOjKGhPEvcBYYzUNpbHClYOmINYoKJDaBhw31KRAxru/JOMJjK5K2r3LTvw3TASaCFfK1ICnAl6ysdZlZgcXfHDBR/ZfdipSwf12zFIeoN2biBNXu","1; BLUPR0701MB2082;\n\t3:pEeI2kbwj8Ue4+zSPqFS39xA2pO1nzHOg3Xi0FOuwv0vUXks4bk/k5SzC3/wWajMuntMgJApBHy+6Ml5ybo2hwa11S86oinsWVQszOJpOi7f6tc3GxpYxj15e5bww97h1mkqNwW6eNGJvzYuUSe8RnYuZwQW7Ciqeuj4S2v6/Ct7YjuPAPNa7noCgo7nvlX0jHKiBlMcfI/RBv49Z6vlcGHGMTTyzkNAn/vi9lhqIUAxezbR+40YF3CklADpA/Fw5BXKhJW080KeMsxYu39lj/DkGHPmn1eBMvNCBDTmtp9MMQY8YRfK4jJYt9X9qhgidZ//Z1fu3QKswhzTSbF+NQ==;\n\t25:Vxnzk2I5xwCac8+LTmyZ9Fm/7JS5fYSc2nDcASb9kwCgUbXLwhFP1rvvvOqzHutGKUy4TeL4w4iKRApzXcfxwRxogjWwyL5cE8rnMlmnwb5VE9bSed1nKQBBiVNFj/8FhIEaWNtMPW1P1aJPV6wU/2PTL93vl+o/90Vj6TJLdSrskhaYkIqFDwlrm1Nqkr0i+6DZAPrzxM11dF+9CjUaWFznPZtjyC2t5a8lE8f63t5uMORO0svy+SSXeddt1wutlEe86R/RcoIfNO6R7AxIpwNtgd/2ygV0tXz7MGeE2iVoOxO8IggJWznoDVvH1GNFku73pROR4Qh+zlgoDtXLUg==;\n\t31:GrvWtDCCXTQYiuBhRcu6P44bPHuczFpC/NjbcPoJAJH6av6NaDVHj5PDNLmUTq+jrcdnrTr20r4R2YFHxPmvdVR8waDixnbQL/+XpyHH4SQidj/VcZu/4dv6xBI6dXP/R3RD2Xlr4RgfHkC7WzxM0Yyq35QF5CXCRHU3jZ/W8FBhZCVOZSF0FMArshfHZW2cypkmrYwQnZOUBWuGJqRRamNXeHDuPbeT9ezGAjGsvr8=","1; BLUPR0701MB2082;\n\t20:XWZWayd+xIIfhn5FfvYdMjLAlQE0y9l+vjSeKH5IYlqjmAGFgavs5PPhbYT7cTbIelExGjKb0pAIUQCwFyLN5eXLCsLbCJte/eZjRZ213iEgCbsvbffjzF1L7etH1W4PNmvKvDVOQXmHAJGfbeh84tQoeWeAl28OGCw4pv8CdBoyS2LxFsbYMi4GemFq71DCQ56VZvMffomHsEL7MeqQXoaS3icxjCRkuigNqTmk3SO2xgDpdJlrmlgHSKkioMUk9dM0ZKuQ+tSTsRD6j5K4cKx9Ce9CDjVB/iHqZbMDhXss7B+JAzHOb85DETonHyasmx3x7vKDRM6MNvb7cQfR0coUEZrrU8QU+tQOtn8HNZErAT7qDRGsBzyC0Su1lsz2Ngh834E7BSKCbHXmifh2FxM4UctTvsiv3N0L0I/gX4tM4T3uF+rh5puWGh1Yq26R67Ff/YvSp5jT7ehv3tGU8qX3P4vW4NODildb6mAbAX1PZrkvMuLQSgG98RlBNPnU;\n\t4:cV/O3JJc7pSMU4dg8feniGuU/lljynHTGVgz+4/v36o+lgRl4hPD76l5EhtQbxkG7yLiP08eY8JM57tSHLroH6/cHhhkf8wp0r8CDzi6Q+a/C1/mMs57hskboIeTGcyTp4MCnPxQNE12sUBOQNPg0X1wafQxkvAiEQB8MBgtcWlVRZatwDdzEdorw84jozaC3XfaTAL4/tiorjyUE4taa+lBVxnD665x124DEBQTAd5Y2Wfgtw9L+4ZYM2YPNHyA","1; BLUPR0701MB2082;\n\t23:XX6jxa+PVpcAzfiD1Ni6EzGHe0744UEH7AtsVwRXU7RRZ5eoS2QNp0jeJOV2qQraZ9DK/Z3DNSD5RQlVAOh3uA5KbXLpZpC27TmCErDxZfCObDgf4ygYHAgfm7K2Pnv495z0xKR8CGtSrN+Z+cI134CRnul4+geH6vH8KcGc02QqutvyBdzDPF+YhO8eCVmDcfa5F5GVyqWsgcfa77POuSNN93BWjRn7CJs2Ng7zylQ3vus0paiFakNDO/7Gd1nfhQKdv/a3SO9bTNlfPT/8+88kZIiMKxq4/X46W2HczQ6mPWSbndEg7nkPwefl5m4B6iMSgyc9CGJT9RsVNh3VSqHxtK3r59EQ1eo1DWbY2eL6dmnYaAqc8mbCzaS9fWmZhMzOJqL3ueore6sFneWKpYm9lARYV9d4jr7QBAYjwatCR/gNaM2rwMz6Fu05OfuXwNNQ9RJ8hwmD+tEXeVjoZ1AmuQa8djH22yFEP7ItONr/SBCZDjy48dO2uOAnLI06WnGZtPODeMy/GXxXFBg4sPlXgSxXFlIsc0bzYsC4H8yKeQm/G3AAgrztqCzdKH4uW8qq6h+2apLKhAM+OyIUU/kV02VJt+OqhRVWwuxSVodAK5slJpS1UNV8fbYmxS3JeowXsu5ZiYpmkbLWQdXqIuJXMiL8Sk5gkODQM+qM1L7vlWnCb+L5+u1tbs7OBTymykPPsp18usHrZ3uEzghJXqKxjq78wtCSQ0WiCw+GctqD02RejYKRJkFxrwuTHLMCInDwxIzl+bHKjYOhxEYM7dWhurmXrpyKlEOgZkn8B8eWRVrJQXFhTb2oOLpZrM/v4bV4GmrPtaaMzVa5dr+h4DH0fmxdz/IlwR58le3K2mqy7JV6mk4Fo76xRYJELltZuJCIULcF5Lck66ymZv0TRugNhrAHdu1WeGMTcTkphcFj4Biuw5UKaiq+i4TxwCWDKqOaaJDoOgI/KJzSq7QfWExC9WJOg3ftbyL85BMALKhAXO2i5lr206CRBH+sTMdi","1; BLUPR0701MB2082;\n\t6:boaxFYWcfNj8vLgYPMNnGwcETrgbfz0Gb5e6FxUD4xZFI0T2emd2Au8GgFmoeSILqXNjmHu62FRm1Z1KMobbSYKQgX/259yc3sfwLSo+a9aHU8mNlkHfarzuVCvYQw82aLy1MyX24gAxgOxyOcx93nPk5G8ly9mbPamubabB/NqH3u+2O5/5KANTMaUc4V7Pkle2W3j7zrP/oHhlpHUNv37Fokgtf+dzMmzteSqlk7miH9USgAICHooPo3x0USB7Dn7FMdSqBo6T7OnNx97HgRdE5tORicrmKUTYVG1JD4ST9rI7zmJyPBXhZnLSMynevCQZrw4nFMuCCpQGTeX8Fw==;\n\t5:5UFZ6d33EgnK8cK253EOC2I7GGAlOwjysyi7R0AbRmILaV6XwGyJ4+UjFeKuT7jtHuIb1gF24odl0FvcWIQkxUQKhNSX7GJTsOKh5DDDhw8Cg3mOPlxDiOtYd+xmpALJzA6PmxNeNWhyaA1LL50cIA==;\n\t24:6KwoZJnPQ1BUX4vElajUnB2GIFS6SM8L/wOk2N5QKu+kHGQyCx521b82OgQH2oby2BbRPToSrUCguxI3kYgenOUO6pfJNuvzC9aIV+EYjbQ=;\n\t7:+TzmIa/myRh4s/qgfFIK3nHRooo1UVQuhWGQZybNcNlFlsSy/tl5o6W/99jtPUdNIWs18kNJRPK0QKUQO7E6bcORQ0AI5v06etQKWiDxLBvopOH8IgnkrxNbnIa3Ez5HiLHZWiQA93piOBwDtcCnRaHNkUNTw57aHMc6rWXbAP67Ly1Dhz5MM2nbIf3kwBTdemxA5uKnOz2AIgqKhH8lLU/HSFswMhOneqoIvAFMRF4="],"X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"3bdab1b7-26d8-4a1d-1a51-08d5032c18a6","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:BLUPR0701MB2082; ","X-MS-TrafficTypeDiagnostic":"BLUPR0701MB2082:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR0701MB2082; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR0701MB2082; ","X-Forefront-PRVS":"0440AC9990","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Sep 2017 09:10:26.6188\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;\n\tIp=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR0701MB2082","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The maximum number of CQs supported is bound to the number\nof connections supported, which differs between RoCE and iWARP.\n\nThis fixes a crash that occurred in iWARP when running 1000 sessions\nusing perftest.\n\nFixes: 67b40dccc45 (\"qed: Implement iWARP initialization, teardown and qp operations\")\n\nSigned-off-by: Michal Kalderon \nSigned-off-by: Ariel Elior \n---\n drivers/net/ethernet/qlogic/qed/qed_rdma.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c\nindex 4f46f28..c8c4b39 100644\n--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c\n+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c\n@@ -209,11 +209,11 @@ static int qed_rdma_alloc(struct qed_hwfn *p_hwfn,\n \t\tgoto free_pd_map;\n \t}\n \n-\t/* Allocate bitmap for cq's. The maximum number of CQs is bounded to\n-\t * twice the number of QPs.\n+\t/* Allocate bitmap for cq's. The maximum number of CQs is bound to\n+\t * the number of connections we support. (num_qps in iWARP or\n+\t * num_qps/2 in RoCE).\n \t */\n-\trc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->cq_map,\n-\t\t\t\t p_rdma_info->num_qps * 2, \"CQ\");\n+\trc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->cq_map, num_cons, \"CQ\");\n \tif (rc) {\n \t\tDP_VERBOSE(p_hwfn, QED_MSG_RDMA,\n \t\t\t \"Failed to allocate cq bitmap, rc = %d\\n\", rc);\n@@ -222,10 +222,10 @@ static int qed_rdma_alloc(struct qed_hwfn *p_hwfn,\n \n \t/* Allocate bitmap for toggle bit for cq icids\n \t * We toggle the bit every time we create or resize cq for a given icid.\n-\t * The maximum number of CQs is bounded to twice the number of QPs.\n+\t * Size needs to equal the size of the cq bmap.\n \t */\n \trc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->toggle_bits,\n-\t\t\t\t p_rdma_info->num_qps * 2, \"Toggle\");\n+\t\t\t\t num_cons, \"Toggle\");\n \tif (rc) {\n \t\tDP_VERBOSE(p_hwfn, QED_MSG_RDMA,\n \t\t\t \"Failed to allocate toogle bits, rc = %d\\n\", rc);\n","prefixes":["v2","net-next","3/4"]}