{"id":817838,"url":"http://patchwork.ozlabs.org/api/patches/817838/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20170923212414.16744-7-romain.naour@gmail.com/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170923212414.16744-7-romain.naour@gmail.com>","list_archive_url":null,"date":"2017-09-23T21:24:05","name":"[v3,6/7] package/flex: disable reallocarray","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9cc58d5ac70668142cc0a4fbf0d7799ecbec8530","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/?format=json","name":"Romain Naour","email":"romain.naour@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170923212414.16744-7-romain.naour@gmail.com/mbox/","series":[{"id":4786,"url":"http://patchwork.ozlabs.org/api/series/4786/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=4786","date":"2017-09-23T21:23:59","name":"glibc: bump to 2.26","version":3,"mbox":"http://patchwork.ozlabs.org/series/4786/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817838/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817838/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"V1n9qp93\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y03Jt3tVHz9t4P\n\tfor ;\n\tSun, 24 Sep 2017 07:24:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B32B388FBC;\n\tSat, 23 Sep 2017 21:24:42 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id On+anne-Nvfx; Sat, 23 Sep 2017 21:24:39 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7D7F388F1B;\n\tSat, 23 Sep 2017 21:24:38 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id C27B21C0060\n\tfor ;\n\tSat, 23 Sep 2017 21:24:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BDA12880F9\n\tfor ;\n\tSat, 23 Sep 2017 21:24:28 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id e94sQJOTyCB2 for ;\n\tSat, 23 Sep 2017 21:24:27 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 246AD8808F\n\tfor ; Sat, 23 Sep 2017 21:24:27 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id r136so4052499wmf.3\n\tfor ; Sat, 23 Sep 2017 14:24:27 -0700 (PDT)","from localhost.localdomain\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tf89sm1253848wmh.18.2017.09.23.14.24.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 14:24:24 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=pMW5zJRJWTg/WIozZo1IF52rPNykL/m5HyRjzwms7CY=;\n\tb=V1n9qp93gzmEay49qsSZi89gtPpZZC0tOa9Yo4s3tBEa+nV10cF9OV/BvRgbCZ69+l\n\tdM79k6fhV4DVvbgLVCw1Fi1DVkxzSzDgfVZ76gVDvuy02OJtlC5fPvHY4UXH0wxt/mAT\n\tIa9hNqpW16uR7/QELph24hUwZwgX/3q0vvnDuGhutGOY035kX9MrkE3PPYPhgaTBw1pX\n\t07eerUCTnHAOJwIEEFwF6KK/EJ0VhDEIVTVDbg4Vd3qnADaItLz5yMZMIy/LQl0AgoCh\n\tpY5EaDDeocOh+MXuGVE+K0xA/ei/jXkkGnbDVDJGGb9nCfBc8cutitjeypqzI+rjAZ72\n\t8w3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=pMW5zJRJWTg/WIozZo1IF52rPNykL/m5HyRjzwms7CY=;\n\tb=SwlRFK7XZqK90tcxFRZJIwNpnia+WGGqeggBuYgnkQz2ipde5Yor8afYNbNAeadqwP\n\t6ZKa0QFadK0NBbNMz1OMGSYTEPLBE+XO5Y6p56EoVunEcAqGebXdkXqy2RKtPqPzciTj\n\tV7tXH31xj/F3GPa+Dm1VX8gnS3LJRzsi+eXY5wt0lLNluMUXvp5VyV7+SM1AI4f5z3T/\n\t/IhPLnXnKeapdgoxaNHLajF/cJPcG2SC7gOlsOaBi+F8vVDTAqZTYW9up5xfVIetnu3t\n\t8m2yWOd99wpveFJAz8ARLCCJnMx7FTVTRA8/qVStgSaMTduuAOfiucdXFIW0UA/Wd+Kp\n\tbj0w==","X-Gm-Message-State":"AHPjjUjXTMwQ+6YKhJC3oQeazm9jCUKgJID0eiUS6vg8iiHOxEa5Y02d\n\tYh4Pws083QTRYOijGlksuEASbt6/","X-Google-Smtp-Source":"AOwi7QDu/kifMpcAUzQsgCTROsCRKG0DvCVaDpJbrwA+b44CXCPGCL9XYv+AZi7Wa5Fbkhx4DKViBQ==","X-Received":"by 10.28.181.1 with SMTP id e1mr6212927wmf.120.1506201865180;\n\tSat, 23 Sep 2017 14:24:25 -0700 (PDT)","From":"Romain Naour ","To":"buildroot@buildroot.org","Date":"Sat, 23 Sep 2017 23:24:05 +0200","Message-Id":"<20170923212414.16744-7-romain.naour@gmail.com>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170923212414.16744-1-romain.naour@gmail.com>","References":"<20170923212414.16744-1-romain.naour@gmail.com>","MIME-Version":"1.0","Cc":"Romain Naour ","Subject":"[Buildroot] [PATCH v3 6/7] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"This doesn't compile with glibc 2.26 where reallocarray() as been introduced.\n\nIt's a nasty issue, when reallocarray() is available for the target, flex will\nbuild a small tool called stage1flex for the host (using _FOR_BUILD) but with\nthe config.h generated for the target.\n\nWhen the host doesn't have a glibc >= 2.26, reallocarray() is never defined\nwhile building stage1flex:\n\nmisc.c:147:8: warning : implicit declaration of function « reallocarray »\n[-Wimplicit-function-declaration]\n mem = reallocarray(NULL, (size_t) size, element_size);\n ^~~~~~~~~~~~\nmisc.c:147:6: warning : assignment makes pointer from integer without a cast\n[-Wint-conversion]\n mem = reallocarray(NULL, (size_t) size, element_size);\n ^\n\nDisable reallocarray for now, reallocarray() support may be\nenabled in a followup patch.\n\nFixes:\nstage1flex-misc.o: In function `allocate_array':\nmisc.c:(.text+0x38f): undefined reference to `reallocarray'\nstage1flex-misc.o: In function `reallocate_array':\nmisc.c:(.text+0xc8a): undefined reference to `reallocarray'\ncollect2: error: ld returned 1 exit status\n\nSigned-off-by: Romain Naour \n---\n package/flex/flex.mk | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/package/flex/flex.mk b/package/flex/flex.mk\nindex b782699..0196624 100644\n--- a/package/flex/flex.mk\n+++ b/package/flex/flex.mk\n@@ -10,7 +10,8 @@ FLEX_INSTALL_STAGING = YES\n FLEX_LICENSE = FLEX\n FLEX_LICENSE_FILES = COPYING\n FLEX_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-m4\n-FLEX_CONF_ENV = ac_cv_path_M4=/usr/bin/m4\n+FLEX_CONF_ENV = ac_cv_path_M4=/usr/bin/m4 \\\n+\tac_cv_func_reallocarray=no\n HOST_FLEX_DEPENDENCIES = host-m4\n \n define FLEX_DISABLE_PROGRAM\n","prefixes":["v3","6/7"]}