{"id":817835,"url":"http://patchwork.ozlabs.org/api/patches/817835/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20170923212414.16744-5-romain.naour@gmail.com/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170923212414.16744-5-romain.naour@gmail.com>","list_archive_url":null,"date":"2017-09-23T21:24:03","name":"[v3,4/7] package/gcc: enable float128 on powerpc64le with glibc >= 2.26 toolchains","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0c4a216d046453ed6dae6c187b7eab7ca3436df3","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/?format=json","name":"Romain Naour","email":"romain.naour@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170923212414.16744-5-romain.naour@gmail.com/mbox/","series":[{"id":4786,"url":"http://patchwork.ozlabs.org/api/series/4786/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=4786","date":"2017-09-23T21:23:59","name":"glibc: bump to 2.26","version":3,"mbox":"http://patchwork.ozlabs.org/series/4786/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817835/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817835/checks/","tags":{},"related":[],"headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"i0WKOtTp\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y03Jm3ZJ6z9t5C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 24 Sep 2017 07:24:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B5D4388F38;\n\tSat, 23 Sep 2017 21:24:38 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zeqtr0KOtCiV; Sat, 23 Sep 2017 21:24:37 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 53E0F88F0E;\n\tSat, 23 Sep 2017 21:24:37 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 824CF1C0060\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 23 Sep 2017 21:24:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 78F1E88EEA\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 23 Sep 2017 21:24:28 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wju0Lm0kJo6m for <buildroot@lists.busybox.net>;\n\tSat, 23 Sep 2017 21:24:25 +0000 (UTC)","from mail-wr0-f196.google.com (mail-wr0-f196.google.com\n\t[209.85.128.196])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 3E81F88F31\n\tfor <buildroot@buildroot.org>; Sat, 23 Sep 2017 21:24:25 +0000 (UTC)","by mail-wr0-f196.google.com with SMTP id k20so2266325wre.1\n\tfor <buildroot@buildroot.org>; Sat, 23 Sep 2017 14:24:25 -0700 (PDT)","from localhost.localdomain\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tf89sm1253848wmh.18.2017.09.23.14.24.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 23 Sep 2017 14:24:23 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=e8yibvs9ImPJ+FZSNE2aTtYrIUvuzs0AP0JCrbCpNKs=;\n\tb=i0WKOtTpI7rjr1vkJNCfWtqKXzar6BYJErPqwM7H2OGLtU14khTYCWYb/cqwkfhjVE\n\tQLZMCee/BEWJDPv+VNkXu0vo1an9tIIN0dN3KKGr/dceaZ9p4Nq7z836n8HziY5ab5DK\n\tpuXqDxwkcJXB33PpSsx1u9annyWlF3bKN5Kc+I8g3ih7R1XBZJ1kXHhTMjAEe7ei+Mbn\n\tpVv5uAw3WzruaoHgmERDbWFcI6TDL2ZiXuTMLCWDzSD4QG916hR3R+ubxOEHWqtt1giX\n\tVgNUbbLl02Xk0eNYYw4D5gVu3TQCSsgPzBCjlf77qymmuMOq9y4E70SFlDxAN9hMEtio\n\tnREA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=e8yibvs9ImPJ+FZSNE2aTtYrIUvuzs0AP0JCrbCpNKs=;\n\tb=UB/E3LaZBVDDakgdUGj1WTsTiwD+oiHqijM+BH3kf2Vd/yjuKNhxNAnK9920aI1NoG\n\tphLWEIV338rReJlDigG6ndzeZFBoGMJd1ePS+CsH/kfnLmepS1OonwzcjWPgDU5NGbn7\n\tTiuVxsGri2NHSYBHjmB5EGpP+4wLkJLV9T4UghkjV3InBUjFMnntcY3+lYwN8EdpbWA/\n\t+24H5SkWCFnAekJLlc+3t4ujobbmgq0YZGi4HX4Qr7htrjv1WmmZmMeF4ASGgcd4APtB\n\tSE/uDcyTjTnqHYhltcJWmR3n4sIGKtynyj/sfbRhyQmskj75EO1ghlGNpR8HcxsaRo03\n\tDfbg==","X-Gm-Message-State":"AHPjjUjrUDm7KAQ1TvyCUfA2GXI+iFjyKaxDfANjH0ediCjCuk9dPjPR\n\tjG0zGiZJbmoM/GE1UTIi4pq5gb0K","X-Google-Smtp-Source":"AOwi7QBrzOxVSBsZD7Ad4aZf3jfGV8J4OSRcdrG/z7MFtBfcJjDcqlZw/73mguE6Zn9vpbEJkZ3K0A==","X-Received":"by 10.223.175.217 with SMTP id y25mr2630711wrd.255.1506201863450;\n\tSat, 23 Sep 2017 14:24:23 -0700 (PDT)","From":"Romain Naour <romain.naour@gmail.com>","To":"buildroot@buildroot.org","Date":"Sat, 23 Sep 2017 23:24:03 +0200","Message-Id":"<20170923212414.16744-5-romain.naour@gmail.com>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170923212414.16744-1-romain.naour@gmail.com>","References":"<20170923212414.16744-1-romain.naour@gmail.com>","Cc":"Romain Naour <romain.naour@gmail.com>","Subject":"[Buildroot] [PATCH v3 4/7] package/gcc: enable float128 on\n\tpowerpc64le with glibc >= 2.26 toolchains","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"},"content":"float128 is now required on powerpc64le with glibc >= 2.26 toolchains.\n\nFixes:\nrunning configure fragment for sysdeps/gnu\nrunning configure fragment for sysdeps/powerpc/powerpc64le\nchecking if [...]powerpc64le-buildroot-linux-gnu-gcc supports binary128 floating point type... no\nchecking if the target machine is at least POWER8... yes\nconfigure: error: ***  binary128 floating point type (GCC >= 6.2) is required on powerpc64le.\n\nIn order to prepare the glibc bump to this version, we enable\nbinary128 floating point in gcc. This require at least gcc >= 6.2.\n\nDisable gcc 4.x and 5.x for internal toolchain.\n\nSigned-off-by: Romain Naour <romain.naour@gmail.com>\n---\nv2: Disable gcc 4.x and 5.x for internal toolchain.\n---\n package/gcc/Config.in.host | 4 ++++\n package/gcc/gcc.mk         | 8 ++++++++\n 2 files changed, 12 insertions(+)","diff":"diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host\nindex ec7b692..0926560 100644\n--- a/package/gcc/Config.in.host\n+++ b/package/gcc/Config.in.host\n@@ -39,6 +39,8 @@ config BR2_GCC_VERSION_4_9_X\n \tdepends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))\n \t# musl mips64 unsupported\n \tdepends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el))\n+\t# glibc >= 2.26 needs gcc >= 6.2\n+\tdepends on !(BR2_TOOLCHAIN_USES_GLIBC && BR2_powerpc64le)\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_9\n \n config BR2_GCC_VERSION_5_X\n@@ -53,6 +55,8 @@ config BR2_GCC_VERSION_5_X\n \tdepends on !BR2_mips_interaptiv && !BR2_mips_m5150 && !BR2_mips_i6400\n \t# musl mips64 unsupported\n \tdepends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el))\n+\t# glibc >= 2.26 needs gcc >= 6.2\n+\tdepends on !(BR2_TOOLCHAIN_USES_GLIBC && BR2_powerpc64le)\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_5\n \n config BR2_GCC_VERSION_6_X\ndiff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk\nindex 49ccccf..54ef70c 100644\n--- a/package/gcc/gcc.mk\n+++ b/package/gcc/gcc.mk\n@@ -254,6 +254,14 @@ HOST_GCC_COMMON_CONF_OPTS += \\\n \t--without-long-double-128\n endif\n \n+# Since glibc >= 2.26, poerpc64le requires double/long double which\n+# requires at least gcc 6.2.\n+# See sysdeps/powerpc/powerpc64le/configure.ac\n+ifeq ($(BR2_TOOLCHAIN_USES_GLIBC)$(BR2_TOOLCHAIN_GCC_AT_LEAST_6)$(BR2_powerpc64le),yyy)\n+HOST_GCC_COMMON_CONF_OPTS += \\\n+\t--with-long-double-128\n+endif\n+\n HOST_GCC_COMMON_TOOLCHAIN_WRAPPER_ARGS += -DBR_CROSS_PATH_SUFFIX='\".br_real\"'\n ifeq ($(BR2_GCC_ARCH_HAS_CONFIGURABLE_DEFAULTS),)\n ifeq ($(call qstrip,$(BR2_GCC_TARGET_CPU_REVISION)),)\n","prefixes":["v3","4/7"]}