{"id":817749,"url":"http://patchwork.ozlabs.org/api/patches/817749/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506126008-9148-2-git-send-email-josef@toxicpanda.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506126008-9148-2-git-send-email-josef@toxicpanda.com>","list_archive_url":null,"date":"2017-09-23T00:20:06","name":"[1/3] net: set tb->fast_sk_family","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"c63e54edafa778ec020c44d28372a8571a28fae3","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506126008-9148-2-git-send-email-josef@toxicpanda.com/mbox/","series":[{"id":4727,"url":"http://patchwork.ozlabs.org/api/series/4727/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4727","date":"2017-09-23T00:20:07","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/4727/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817749/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817749/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"15wPcgoa\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzWH14fvVz9sNw\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 23 Sep 2017 10:21:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752632AbdIWAVE (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 20:21:04 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:37987 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752071AbdIWAUS (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 20:20:18 -0400","by mail-qt0-f195.google.com with SMTP id o3so1725611qte.5\n\tfor <netdev@vger.kernel.org>; Fri, 22 Sep 2017 17:20:18 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\tr22sm808764qtj.94.2017.09.22.17.20.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 17:20:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=XY7WAjJ2DJm/azlXuzcgl1+0KtAVBxbe1GhRw7VCsb8=;\n\tb=15wPcgoaoCK7pHPLSKg9D/TbYH0Ua39y+72bTL0j5UiZnNyBgtYj75NnrGyPfU+OkG\n\tSc0ohv3s4BNJ2l3gVBoZeeJ4Trii1TGJ80DHOM5sxGf6mkk66I0FYdE6QRlLNyLnmyBz\n\tGCTSoSG6wxGccLSq1WMfS6WiK8977jyKPXM0g/6lC5peTmS3+20v2p1MuvxZN1J4i7Mn\n\trremanyhlUr4zVqXknE310Y9DiEYlC4YMjMGbga8KgJtt+giOP5YdltY039vUrxKSrbi\n\tnW6YFjcdQFH/jsPOMfn0Jc5eCxYS6WmHXHS60FUpYOHXj+qt/qBmZAF59HpAOy1BsBXu\n\txk6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=XY7WAjJ2DJm/azlXuzcgl1+0KtAVBxbe1GhRw7VCsb8=;\n\tb=IcjHW5p5Bh3OqmhLxKkBuWVf9zbHqktLbdoxUeRrOWiVsy8FRQbm+8nT7An4lCLwhC\n\tnbtmEq1w+nwmVLriVBVcO9d2L2B1atyBUjApFLFiQ9rgk8C8PJLSme0ChgMjDDzQX5Ix\n\t4Je4j+KUYKIznYmdiGjNxATd3b2l8FT++ur75w/7Xlouj2tkNbnlW0AeY4TDcweDENNy\n\tI+2SnU61giSSGdJWYRpQBa+SMzwjFphQKdH2bLYMrLkOw8vevxbRIZxfhWS6TjOvYOnk\n\tPpjrA6cGXievTEijmlcf5cJlp9VXyqmxsPls5ld43aqlHfRhErkpEFp+uu8EX1MezOp5\n\tiQvA==","X-Gm-Message-State":"AHPjjUiA44IdGhMBwJD7BNQmSJ5E7TQUrE7c/6DDvTWfx48rO9O259FA\n\tB65gEz2J+NEie59TFK5LRmQhymC3","X-Google-Smtp-Source":"AOwi7QD9nQw4Bf/NgQP9cyYN7hzGKfPgsmFygZWHUtakP0MEWI8k0oxlwgL23ZlrTjB4jmbSF0uUSw==","X-Received":"by 10.200.12.11 with SMTP id k11mr1394524qti.105.1506126018064; \n\tFri, 22 Sep 2017 17:20:18 -0700 (PDT)","From":"Josef Bacik <josef@toxicpanda.com>","To":"davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com,\n\tlinux-kernel@vger.kernel.org","Cc":"Josef Bacik <jbacik@fb.com>","Subject":"[PATCH 1/3] net: set tb->fast_sk_family","Date":"Fri, 22 Sep 2017 20:20:06 -0400","Message-Id":"<1506126008-9148-2-git-send-email-josef@toxicpanda.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506126008-9148-1-git-send-email-josef@toxicpanda.com>","References":"<1506126008-9148-1-git-send-email-josef@toxicpanda.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Josef Bacik <jbacik@fb.com>\n\nWe need to set the tb->fast_sk_family properly so we can use the proper\ncomparison function for all subsequent reuseport bind requests.\n\nFixes: 637bc8bbe6c0 (\"inet: reset tb->fastreuseport when adding a reuseport sk\")\nReported-and-tested-by: Cole Robinson <crobinso@redhat.com>\nSigned-off-by: Josef Bacik <jbacik@fb.com>\n---\n net/ipv4/inet_connection_sock.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c\nindex b9c64b40a83a..f87f4805e244 100644\n--- a/net/ipv4/inet_connection_sock.c\n+++ b/net/ipv4/inet_connection_sock.c\n@@ -328,6 +328,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)\n \t\t\ttb->fastuid = uid;\n \t\t\ttb->fast_rcv_saddr = sk->sk_rcv_saddr;\n \t\t\ttb->fast_ipv6_only = ipv6_only_sock(sk);\n+\t\t\ttb->fast_sk_family = sk->sk_family;\n #if IS_ENABLED(CONFIG_IPV6)\n \t\t\ttb->fast_v6_rcv_saddr = sk->sk_v6_rcv_saddr;\n #endif\n@@ -354,6 +355,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)\n \t\t\t\ttb->fastuid = uid;\n \t\t\t\ttb->fast_rcv_saddr = sk->sk_rcv_saddr;\n \t\t\t\ttb->fast_ipv6_only = ipv6_only_sock(sk);\n+\t\t\t\ttb->fast_sk_family = sk->sk_family;\n #if IS_ENABLED(CONFIG_IPV6)\n \t\t\t\ttb->fast_v6_rcv_saddr = sk->sk_v6_rcv_saddr;\n #endif\n","prefixes":["1/3"]}