{"id":817747,"url":"http://patchwork.ozlabs.org/api/patches/817747/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506126008-9148-4-git-send-email-josef@toxicpanda.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506126008-9148-4-git-send-email-josef@toxicpanda.com>","list_archive_url":null,"date":"2017-09-23T00:20:08","name":"[3/3] inet: fix improper empty comparison","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"d395fd825056714e5558638dd77e41ef771a6bf7","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506126008-9148-4-git-send-email-josef@toxicpanda.com/mbox/","series":[{"id":4727,"url":"http://patchwork.ozlabs.org/api/series/4727/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4727","date":"2017-09-23T00:20:07","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/4727/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817747/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817747/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"Gl5bY1d3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzWGb3Kxhz9sNw\n\tfor ;\n\tSat, 23 Sep 2017 10:20:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752618AbdIWAUx (ORCPT );\n\tFri, 22 Sep 2017 20:20:53 -0400","from mail-qk0-f196.google.com ([209.85.220.196]:37461 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752439AbdIWAUV (ORCPT\n\t); Fri, 22 Sep 2017 20:20:21 -0400","by mail-qk0-f196.google.com with SMTP id r66so1664116qke.4\n\tfor ; Fri, 22 Sep 2017 17:20:21 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\tw20sm797728qkb.72.2017.09.22.17.20.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 17:20:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=QL+0EEWmxS/wZEVRe07YpPddyA3/gOLjXjbyGv8bKRk=;\n\tb=Gl5bY1d3CmGWfQVgOsah1Kb9T8IUAJesPk139Y1XjfWn4tZJLFLJwRtMoHMtDb+yWd\n\tKrne1xkJdDvd9tmDBDNFyZciALQCZpmTQeyCin5WqU4B5LEdhNuUbxy5pfISCThmRAH2\n\tTTDrV5JRtY+ZrFWFC7goAS9rQ7x+6cDpTKaxmCMXHS6r7p5CFyTSO107ytJbLFNUIGn2\n\tnIGRQywoH3mCjQuPtahQjMxzvWcGFb3jRQW4je9j7LNF3elikVGiz494Adah+VDaZaWg\n\tH+ex9M7Hg9xSV9JM5/YvKL/FoBX1gMcWkfTTa9/Wk8dq+wkRjLVQAI58chW2GiHcN7Xd\n\taYYw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=QL+0EEWmxS/wZEVRe07YpPddyA3/gOLjXjbyGv8bKRk=;\n\tb=KQ95YXtq7xKxMGH+ZCaBJNYOSSZY98pHp5QodjGTiEJzzJCxRTmW7QTABtoD9UPZdh\n\tCqswNcmHGWiqQFgspEuCoxLwIJSAvEJQEVAnLejYzv3Ymhraydgn6jxQnDxoHmmYs3Q6\n\t2phKuYMjUpfHUPhaUlwMhDDxNe1xvN4se6GMxGCMo7WQTlsgTqtsKPlfuVHjuCK0XwIa\n\tnuBg+RFuDtQiSqDXXL7UwDe2Drpw7NcrMrnMJcA1OQYS16xa/xNZ0JwwJe+pHxNKJhWw\n\tPNtLBOokaQ1LM8lEU/blOCE3NUVttOdKCTs1wQDtcXeNasMyOrbedK9K24sO43Vh94vY\n\t63eA==","X-Gm-Message-State":"AHPjjUhnsAXHS63FsDUkwaYgOyvRK1Nu7+LYrLZ4yrGTEgCa+WGCQAzT\n\tp3V3V8pH11kn/GIWRFvGFLjJjg==","X-Google-Smtp-Source":"AOwi7QDxPYn/Hj8ijhUfYGZ3z1RmTDp9acuaI4sh2JBw6U3yAIjDpBUHj46SZD45PihlYY5mr816yQ==","X-Received":"by 10.55.120.129 with SMTP id t123mr1244448qkc.13.1506126021290; \n\tFri, 22 Sep 2017 17:20:21 -0700 (PDT)","From":"Josef Bacik ","To":"davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com,\n\tlinux-kernel@vger.kernel.org","Cc":"Josef Bacik ","Subject":"[PATCH 3/3] inet: fix improper empty comparison","Date":"Fri, 22 Sep 2017 20:20:08 -0400","Message-Id":"<1506126008-9148-4-git-send-email-josef@toxicpanda.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506126008-9148-1-git-send-email-josef@toxicpanda.com>","References":"<1506126008-9148-1-git-send-email-josef@toxicpanda.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Josef Bacik \n\nWhen doing my reuseport rework I screwed up and changed a\n\nif (hlist_empty(&tb->owners))\n\nto\n\nif (!hlist_empty(&tb->owners))\n\nThis is obviously bad as all of the reuseport/reuse logic was reversed,\nwhich caused weird problems like allowing an ipv4 bind conflict if we\nopened an ipv4 only socket on a port followed by an ipv6 only socket on\nthe same port.\n\nFixes: b9470c27607b (\"inet: kill smallest_size and smallest_port\")\nReported-by: Cole Robinson \nSigned-off-by: Josef Bacik \n---\n net/ipv4/inet_connection_sock.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c\nindex a1bf30438bc5..c039c937ba90 100644\n--- a/net/ipv4/inet_connection_sock.c\n+++ b/net/ipv4/inet_connection_sock.c\n@@ -321,7 +321,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)\n \t\t\tgoto fail_unlock;\n \t}\n success:\n-\tif (!hlist_empty(&tb->owners)) {\n+\tif (hlist_empty(&tb->owners)) {\n \t\ttb->fastreuse = reuse;\n \t\tif (sk->sk_reuseport) {\n \t\t\ttb->fastreuseport = FASTREUSEPORT_ANY;\n","prefixes":["3/3"]}