{"id":817746,"url":"http://patchwork.ozlabs.org/api/patches/817746/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506126008-9148-3-git-send-email-josef@toxicpanda.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506126008-9148-3-git-send-email-josef@toxicpanda.com>","list_archive_url":null,"date":"2017-09-23T00:20:07","name":"[2/3] net: use inet6_rcv_saddr to compare sockets","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4ff6389534adf26c6945ad693ea5f341bfb6b04a","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506126008-9148-3-git-send-email-josef@toxicpanda.com/mbox/","series":[{"id":4727,"url":"http://patchwork.ozlabs.org/api/series/4727/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4727","date":"2017-09-23T00:20:07","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/4727/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817746/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817746/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"1Iz5BEXw\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzWGC4Clyz9sNw\n\tfor ;\n\tSat, 23 Sep 2017 10:20:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752528AbdIWAUX (ORCPT );\n\tFri, 22 Sep 2017 20:20:23 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:36592 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751974AbdIWAUU (ORCPT\n\t); Fri, 22 Sep 2017 20:20:20 -0400","by mail-qt0-f195.google.com with SMTP id t46so1728181qtj.3\n\tfor ; Fri, 22 Sep 2017 17:20:19 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\ta125sm826212qkg.13.2017.09.22.17.20.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 17:20:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=n8Qij1hamirWgjHrCp2xn8qR+YoODdbEj0mb2QzKHnc=;\n\tb=1Iz5BEXwseod8jwN2Cs3wOreLtQ3C+2QWzICM3mEVUzZXpBxJwkRGo04pKfQSjmgSK\n\tOox452hUnZVU0VbxnFXOBGxleSpe0IpmD8kQVJK+0qlpNhPn5i6QyPoFJqI4GM1fY/Bm\n\tWSqmKhjIHvvUAK73EaBc6g8ohGWeH9C7zzq4SM7VTj1LXEm1byFN3v+dQ5V3li5UUxNs\n\t8idr6v2PgrxvhhmPf/kKgpuVA66klpCFe+YbzphpfOf5l+88anpxYjdXOkQVYROY22WJ\n\twzEtWTskDtw3AfZ2YRXHZkVsBa7s15s35BsyzLir7mCXsmiXYnClozEjUTokwTnS2ex1\n\tFhfQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=n8Qij1hamirWgjHrCp2xn8qR+YoODdbEj0mb2QzKHnc=;\n\tb=r3aeo4M1edeFOKZAGP3c14IUtyjulOSzBIDOO9MCZ3eTQThvrPUvqtBV8IOyti5KSK\n\tKCSqalT9NlmNwjXFxNGuVCALRffLDmLoTrWc22EEhkBmk78XemLYAqpQ0MltQq9uCPyc\n\t+gRH5c7EW9fLhYDHomSXI+1ig88Jw/KVP0chVSqAXfcAmgWavIIl9Ekn9H1VvFGFlCza\n\tF8+US9cxBF1pNP7H1EPx2Bewj15e4c7GBMYg40PdI22GLJ5jEMZo6LNGUIVJ1937GG6i\n\tOoWbFWm7nXoZCBjElFLgytW5o2jk+l8AIMcb8LBKrR7WwTfnHBZAKaWK3IbXNmsdyFML\n\tsjbw==","X-Gm-Message-State":"AHPjjUiKPIxORHukRVzAon+8VgMMQ895Uba5GspQL4Boxuunjl3B1NSG\n\tf8b0Cie5LTEd1NSosX+Y6KI86cPQ","X-Google-Smtp-Source":"AOwi7QB7VFm61n+ABjfD3Mv5U2qR+kNyzxMYe/dfDmP/wHmOk9P7XA7gPtFP8wqeqQ1Rzu6xPp0PHg==","X-Received":"by 10.200.51.237 with SMTP id d42mr1417566qtb.25.1506126019319; \n\tFri, 22 Sep 2017 17:20:19 -0700 (PDT)","From":"Josef Bacik ","To":"davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com,\n\tlinux-kernel@vger.kernel.org","Cc":"Josef Bacik ","Subject":"[PATCH 2/3] net: use inet6_rcv_saddr to compare sockets","Date":"Fri, 22 Sep 2017 20:20:07 -0400","Message-Id":"<1506126008-9148-3-git-send-email-josef@toxicpanda.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506126008-9148-1-git-send-email-josef@toxicpanda.com>","References":"<1506126008-9148-1-git-send-email-josef@toxicpanda.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Josef Bacik \n\nIn ipv6_rcv_saddr_equal() we need to use inet6_rcv_saddr(sk) for the\nipv6 compare with the fast socket information to make sure we're doing\nthe proper comparisons.\n\nFixes: 637bc8bbe6c0 (\"inet: reset tb->fastreuseport when adding a reuseport sk\")\nReported-and-tested-by: Cole Robinson \nSigned-off-by: Josef Bacik \n---\n net/ipv4/inet_connection_sock.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c\nindex f87f4805e244..a1bf30438bc5 100644\n--- a/net/ipv4/inet_connection_sock.c\n+++ b/net/ipv4/inet_connection_sock.c\n@@ -266,7 +266,7 @@ static inline int sk_reuseport_match(struct inet_bind_bucket *tb,\n #if IS_ENABLED(CONFIG_IPV6)\n \tif (tb->fast_sk_family == AF_INET6)\n \t\treturn ipv6_rcv_saddr_equal(&tb->fast_v6_rcv_saddr,\n-\t\t\t\t\t &sk->sk_v6_rcv_saddr,\n+\t\t\t\t\t inet6_rcv_saddr(sk),\n \t\t\t\t\t tb->fast_rcv_saddr,\n \t\t\t\t\t sk->sk_rcv_saddr,\n \t\t\t\t\t tb->fast_ipv6_only,\n","prefixes":["2/3"]}