{"id":817604,"url":"http://patchwork.ozlabs.org/api/patches/817604/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170922154014.29350-11-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170922154014.29350-11-f4bug@amsat.org>","list_archive_url":null,"date":"2017-09-22T15:39:50","name":"[10/34] amd_iommu: avoid needless includes in header file","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"29894c39b62649e643823742f309a48f5c1403e9","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170922154014.29350-11-f4bug@amsat.org/mbox/","series":[{"id":4657,"url":"http://patchwork.ozlabs.org/api/series/4657/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4657","date":"2017-09-22T15:39:40","name":"remove i386/pc dependency from non-PC world (part 1)","version":1,"mbox":"http://patchwork.ozlabs.org/series/4657/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817604/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817604/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tka4e0vS\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzHy0375hz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 01:50:48 +1000 (AEST)","from localhost ([::1]:59619 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvQE2-0004FO-GW\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 11:50:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41466)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dvQ4k-0004hj-0w\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 11:41:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dvQ4g-0003E3-Vg\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 11:41:10 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:32890)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvQ4g-0003Di-RD; Fri, 22 Sep 2017 11:41:06 -0400","by mail-qk0-x244.google.com with SMTP id g128so879025qke.0;\n\tFri, 22 Sep 2017 08:41:06 -0700 (PDT)","from yoga.lan ([181.93.89.178]) by smtp.gmail.com with ESMTPSA id\n\tz75sm71742qkb.71.2017.09.22.08.41.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 08:41:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jykksLgZSb+7WhicF+r3LxKm9PwQjlcx2MM1jGOtmYM=;\n\tb=tka4e0vS8T6WcGS6pQyB0NfbS5IRC9ZkpO0hPgbMtJRddSRCSQXIJ74mIr4IfeI8l8\n\tyTd+NCxwUnr42mLuc8i8dyh7jRFEERVapDD4orE+IE2sMAjLYrngmcAfTEXu9Vfobjcb\n\twTu8mAW1uyAOSF7Z1mOPSC+eG8/KZqyLJ+C7KhB3BOjFU2f5uM7FHbadD6ixC1Y9jpzg\n\tkroKEziut/sKTP2ByHvUZG3Fa/xGFYpcBTVlann881efFarn8JaRrVBDWhQFWL6caxuf\n\tBr9YOdtOec2XlBtt71n2bQJhYemn2QcWSZYk4StvVTg+r56YJpN1bbrsyoI6Fl5bXP3W\n\tXt2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=jykksLgZSb+7WhicF+r3LxKm9PwQjlcx2MM1jGOtmYM=;\n\tb=GmuLs0bYdOrsn19LpWzX+KJm64kmYhfGgLR0RJMJXtNtWXbEvCzajHXB5BRW9LjnG1\n\tjmyyl4nfslEswgQhuKIKq3bekqQ4RKIQNvmE4eg9oK+FgZk7t9Bni6q7ndyCfLCn9g3N\n\tEjjfkYgbbxzVCP34MazuFmAUlslz3R0pb83cC7vhIW4s96ZxGC0XMNbkrKJnW/h0LpKk\n\t1xbikT4ZaDoWumkBtMc75etX2yqv45QKOkxuUja8je0lU9hifgu/cvKhqWDOW6S1MpbF\n\t9iyrUrLb2qIhs37i4nGJYnnVjsDW2z6Xq4SmFl1McBT4qmou8eswyYhsQ2lU+yAeKoea\n\tCenQ==","X-Gm-Message-State":"AHPjjUgQLae7RM5xxsFjdR/W7Bb6+GDaCK9MgEsox6mNem0qunsL1MKF\n\t6jXpmLD/yB9ewACXeYFjahM=","X-Google-Smtp-Source":"AOwi7QD7meXYBbPCTQUzimS57J9jRbDVFQ9Nvau5UigXGmDJpL/ke9f6RNz9AqQZEbu/mccq6UjCmw==","X-Received":"by 10.55.130.197 with SMTP id e188mr7918358qkd.203.1506094866276;\n\tFri, 22 Sep 2017 08:41:06 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Peter Maydell , Thomas Huth ,\n\tPaolo Bonzini ,\n\tRichard Henderson , \n\tEduardo Habkost ,\n\t\"Michael S. Tsirkin\" ","Date":"Fri, 22 Sep 2017 12:39:50 -0300","Message-Id":"<20170922154014.29350-11-f4bug@amsat.org>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170922154014.29350-1-f4bug@amsat.org>","References":"<20170922154014.29350-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"[Qemu-devel] [PATCH 10/34] amd_iommu: avoid needless includes in\n\theader file","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"instead move them to the source file\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/i386/amd_iommu.h | 5 -----\n hw/i386/amd_iommu.c | 5 ++++-\n 2 files changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h\nindex d370ae3549..aeef802364 100644\n--- a/hw/i386/amd_iommu.h\n+++ b/hw/i386/amd_iommu.h\n@@ -23,11 +23,6 @@\n \n #include \"hw/hw.h\"\n #include \"hw/pci/pci.h\"\n-#include \"hw/pci/msi.h\"\n-#include \"hw/sysbus.h\"\n-#include \"sysemu/dma.h\"\n-#include \"hw/i386/pc.h\"\n-#include \"hw/pci/pci_bus.h\"\n #include \"hw/i386/x86-iommu.h\"\n \n /* Capability registers */\ndiff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c\nindex 334938a280..e1bf9c5329 100644\n--- a/hw/i386/amd_iommu.c\n+++ b/hw/i386/amd_iommu.c\n@@ -20,7 +20,10 @@\n * Cache implementation inspired by hw/i386/intel_iommu.c\n */\n #include \"qemu/osdep.h\"\n-#include \"hw/i386/amd_iommu.h\"\n+#include \"hw/i386/pc.h\"\n+#include \"hw/pci/msi.h\"\n+#include \"hw/pci/pci_bus.h\"\n+#include \"amd_iommu.h\"\n #include \"qapi/error.h\"\n #include \"qemu/error-report.h\"\n #include \"trace.h\"\n","prefixes":["10/34"]}