{"id":817435,"url":"http://patchwork.ozlabs.org/api/patches/817435/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506077902-1796-4-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506077902-1796-4-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-22T10:58:20","name":"[3/5] net: af_packet: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"fdd5f45dfe663fdf3eb127b4a85d058f57e99b01","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506077902-1796-4-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4595,"url":"http://patchwork.ozlabs.org/api/series/4595/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4595","date":"2017-09-22T10:58:17","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4595/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817435/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817435/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qPyghPT3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz9TG6DrJz9sP1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 20:58:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752061AbdIVK6l (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 06:58:41 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:36727 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751903AbdIVK6i (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 06:58:38 -0400","by mail-pg0-f68.google.com with SMTP id d8so438668pgt.3\n\tfor <netdev@vger.kernel.org>; Fri, 22 Sep 2017 03:58:38 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\ts17sm6283035pgq.25.2017.09.22.03.58.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 22 Sep 2017 03:58:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=pXUnDk8uGEZ0ICph0oLkLgepZReBxxl8SA28lBH0NTU=;\n\tb=qPyghPT3s09fsFhKaADwaRaVh4czkukeT0jBRC9syYtWPoeIYKLQBMTlRn8U3/eNoi\n\tuarEWWJJeQmz8/8tkvLM5AYz3FoQCLZuVPtv6ungXfR6dPpJNOOn6twJy0UFUcdjBRG1\n\tLOwBJyDqKRA8he8SCp9Bu52L6FQHWZvzBBRcP8FGMkzGcCw8Vh6+brNbXfbbu0NggbYt\n\tKEE8Fadb3CNgk4pQZV6z9zOg/apO/KT9EbvPtJGvJ5L2u/8KWxS1f/O+06z+De4N2yTK\n\twAPUui30ndZxN69KUXnTCK6iiwmKeISRbpsd32TlCf2AxF2E+IffJ70opS9QSN31i8bk\n\tOc2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=pXUnDk8uGEZ0ICph0oLkLgepZReBxxl8SA28lBH0NTU=;\n\tb=ECfvK0OwKxF5PVsw5/iiopMTBfV+YM6f4U/cHbLnPu3K7fTL27a+oNgOSnci12L6Ft\n\t8tOO/laMkDmYkCkxRrU9VkZt7xtJBI8Cc7chUIYKLb/0g1QZakPCVaAW+TkS2bT4W73+\n\tTpMs5v0FVo57jPF4Hqbgn5UzCwx0Gm79UaKwEwXra5qzukzD2DgNY2s2ghepDDCxKKO/\n\tIANUwD3X1ZBmXiXoBpzrtM85HonfMo8Nr/6KD8RHqiyk+hvkLXBi7CVAQlRhjPgJvSxd\n\tqkIPwyt3JmS7zkfFEUeFeLc+cVg8dHlDlacg+egoDJEJDisGn5EBtnOXREWsLhBFDBKp\n\t0ZtQ==","X-Gm-Message-State":"AHPjjUjvB3GUO1hsvZiY5s4KfUl7lU8ienOBThuTdKLLVhtzMj0xWOeX\n\tzrZQMWTpRVjjuo3sOLPUGXA3zIka","X-Google-Smtp-Source":"AOwi7QCEKXCShh4KgDTqmHQWBEDWD4ryFZu/km1wCBEcS3MHI8FaWEMoYcmhTJ2bJhYdvRV9lYEnhQ==","X-Received":"by 10.101.68.65 with SMTP id e1mr9161176pgq.134.1506077918024;\n\tFri, 22 Sep 2017 03:58:38 -0700 (PDT)","From":"Allen Pais <allen.lkml@gmail.com>","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, sameo@linux.intel.com,\n\tAllen Pais <allen.lkml@gmail.com>","Subject":"[PATCH 3/5] net: af_packet: use setup_timer() helper.","Date":"Fri, 22 Sep 2017 16:28:20 +0530","Message-Id":"<1506077902-1796-4-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506077902-1796-1-git-send-email-allen.lkml@gmail.com>","References":"<1506077902-1796-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n   function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n net/packet/af_packet.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c\nindex c261729..1d3e3ce 100644\n--- a/net/packet/af_packet.c\n+++ b/net/packet/af_packet.c\n@@ -544,9 +544,7 @@ static void prb_init_blk_timer(struct packet_sock *po,\n \t\tstruct tpacket_kbdq_core *pkc,\n \t\tvoid (*func) (unsigned long))\n {\n-\tinit_timer(&pkc->retire_blk_timer);\n-\tpkc->retire_blk_timer.data = (long)po;\n-\tpkc->retire_blk_timer.function = func;\n+\tsetup_timer(&pkc->retire_blk_timer, func, (long)po);\n \tpkc->retire_blk_timer.expires = jiffies;\n }\n \n","prefixes":["3/5"]}