{"id":817418,"url":"http://patchwork.ozlabs.org/api/patches/817418/?format=json","web_url":"http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20170922093453.13250-3-sakari.ailus@linux.intel.com/","project":{"id":37,"url":"http://patchwork.ozlabs.org/api/projects/37/?format=json","name":"Devicetree Bindings","link_name":"devicetree-bindings","list_id":"devicetree.vger.kernel.org","list_email":"devicetree@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170922093453.13250-3-sakari.ailus@linux.intel.com>","list_archive_url":null,"date":"2017-09-22T09:34:51","name":"[RESEND,v3,2/4] dt: bindings: as3645a: Use LED number to refer to LEDs","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"e6ccb61fd8f0ed72377c0d8dfa98baf1cc4c06ee","submitter":{"id":65485,"url":"http://patchwork.ozlabs.org/api/people/65485/?format=json","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20170922093453.13250-3-sakari.ailus@linux.intel.com/mbox/","series":[{"id":4586,"url":"http://patchwork.ozlabs.org/api/series/4586/?format=json","web_url":"http://patchwork.ozlabs.org/project/devicetree-bindings/list/?series=4586","date":"2017-09-22T09:34:49","name":"AS3645A fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/4586/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817418/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817418/checks/","tags":{},"related":[],"headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz7cM0rb2z9sPk\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 19:34:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751972AbdIVJe5 (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tFri, 22 Sep 2017 05:34:57 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:42402 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751878AbdIVJe4 (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Fri, 22 Sep 2017 05:34:56 -0400","from lanttu.localdomain (unknown\n\t[IPv6:2001:1bc8:1a6:d3d5::e1:1002])\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTP id 94692600FD;\n\tFri, 22 Sep 2017 12:34:54 +0300 (EEST)"],"From":"Sakari Ailus <sakari.ailus@linux.intel.com>","To":"linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com","Cc":"linux-media@vger.kernel.org, devicetree@vger.kernel.org","Subject":"[RESEND PATCH v3 2/4] dt: bindings: as3645a: Use LED number to refer\n\tto LEDs","Date":"Fri, 22 Sep 2017 12:34:51 +0300","Message-Id":"<20170922093453.13250-3-sakari.ailus@linux.intel.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170922093453.13250-1-sakari.ailus@linux.intel.com>","References":"<20170922093453.13250-1-sakari.ailus@linux.intel.com>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"},"content":"Use integers (reg property) to tell the number of the LED to the driver\ninstead of the node name. While both of these approaches are currently\nused by the LED bindings, using integers will require less driver changes\nfor ACPI support. Additionally, it will make possible LED naming using\nchip and LED node names, effectively making the label property most useful\nfor human-readable names only.\n\nSigned-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>\nAcked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>\nAcked-by: Rob Herring <robh@kernel.org>\n---\n .../devicetree/bindings/leds/ams,as3645a.txt       | 28 ++++++++++++++--------\n 1 file changed, 18 insertions(+), 10 deletions(-)","diff":"diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt\nindex 12c5ef26ec73..fdc40e354a64 100644\n--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt\n+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt\n@@ -15,11 +15,14 @@ Required properties\n \n compatible\t: Must be \"ams,as3645a\".\n reg\t\t: The I2C address of the device. Typically 0x30.\n+#address-cells\t: 1\n+#size-cells\t: 0\n \n \n-Required properties of the \"flash\" child node\n-=============================================\n+Required properties of the flash child node (0)\n+===============================================\n \n+reg: 0\n flash-timeout-us: Flash timeout in microseconds. The value must be in\n \t\t  the range [100000, 850000] and divisible by 50000.\n flash-max-microamp: Maximum flash current in microamperes. Has to be\n@@ -33,20 +36,21 @@ ams,input-max-microamp: Maximum flash controller input current. The\n \t\t\tand divisible by 50000.\n \n \n-Optional properties of the \"flash\" child node\n-=============================================\n+Optional properties of the flash child node\n+===========================================\n \n label\t\t: The label of the flash LED.\n \n \n-Required properties of the \"indicator\" child node\n-=================================================\n+Required properties of the indicator child node (1)\n+===================================================\n \n+reg: 1\n led-max-microamp: Maximum indicator current. The allowed values are\n \t\t  2500, 5000, 7500 and 10000.\n \n-Optional properties of the \"indicator\" child node\n-=================================================\n+Optional properties of the indicator child node\n+===============================================\n \n label\t\t: The label of the indicator LED.\n \n@@ -55,16 +59,20 @@ Example\n =======\n \n \tas3645a@30 {\n+\t\t#address-cells: 1\n+\t\t#size-cells: 0\n \t\treg = <0x30>;\n \t\tcompatible = \"ams,as3645a\";\n-\t\tflash {\n+\t\tflash@0 {\n+\t\t\treg = <0x0>;\n \t\t\tflash-timeout-us = <150000>;\n \t\t\tflash-max-microamp = <320000>;\n \t\t\tled-max-microamp = <60000>;\n \t\t\tams,input-max-microamp = <1750000>;\n \t\t\tlabel = \"as3645a:flash\";\n \t\t};\n-\t\tindicator {\n+\t\tindicator@1 {\n+\t\t\treg = <0x1>;\n \t\t\tled-max-microamp = <10000>;\n \t\t\tlabel = \"as3645a:indicator\";\n \t\t};\n","prefixes":["RESEND","v3","2/4"]}