{"id":817405,"url":"http://patchwork.ozlabs.org/api/patches/817405/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/9e98f74834af349564b71bc8443bdad55d6e37c6.1505934128.git.naveen.n.rao@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<9e98f74834af349564b71bc8443bdad55d6e37c6.1505934128.git.naveen.n.rao@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/9e98f74834af349564b71bc8443bdad55d6e37c6.1505934128.git.naveen.n.rao@linux.vnet.ibm.com/","date":"2017-09-22T09:10:43","name":"[v2,1/6] powerpc/kprobes: Some cosmetic updates to try_to_emulate()","commit_ref":"22085337f5b9d7a7adf5c6cc4e007c28e5216a7f","pull_url":null,"state":"accepted","archived":false,"hash":"5a4acb8b84c5d9411d7de739aaaeb834d287c9c4","submitter":{"id":15185,"url":"http://patchwork.ozlabs.org/api/people/15185/?format=json","name":"Naveen N. Rao","email":"naveen.n.rao@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/9e98f74834af349564b71bc8443bdad55d6e37c6.1505934128.git.naveen.n.rao@linux.vnet.ibm.com/mbox/","series":[{"id":4580,"url":"http://patchwork.ozlabs.org/api/series/4580/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=4580","date":"2017-09-22T09:10:23","name":"powerpc/kprobes: More fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/4580/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817405/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817405/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz7Bf1Zszz9t16\n\tfor ;\n\tFri, 22 Sep 2017 19:16:10 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xz7Bf0KlWzDsNr\n\tfor ;\n\tFri, 22 Sep 2017 19:16:10 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xz74v265czDsMC\n\tfor ;\n\tFri, 22 Sep 2017 19:11:10 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8M999oS135936\n\tfor ; Fri, 22 Sep 2017 05:11:08 -0400","from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d4pnfk08q-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 05:11:08 -0400","from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from\n\t; Fri, 22 Sep 2017 19:11:04 +1000","from d23relay07.au.ibm.com (202.81.31.226)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 19:11:03 +1000","from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])\n\tby d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8M9B3tv40304748\n\tfor ; Fri, 22 Sep 2017 19:11:03 +1000","from d23av02.au.ibm.com (localhost [127.0.0.1])\n\tby d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8M9ArWj020431\n\tfor ; Fri, 22 Sep 2017 19:10:54 +1000","from naverao1-tp.ibm.com ([9.77.124.51])\n\tby d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8M9AoTV020313; Fri, 22 Sep 2017 19:10:51 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=naveen.n.rao@linux.vnet.ibm.com; receiver=)","From":"\"Naveen N. Rao\" ","To":"Michael Ellerman ","Subject":"[PATCH v2 1/6] powerpc/kprobes: Some cosmetic updates to\n\ttry_to_emulate()","Date":"Fri, 22 Sep 2017 14:40:43 +0530","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"","References":"","X-TM-AS-MML":"disable","x-cbid":"17092209-1617-0000-0000-000002005F07","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092209-1618-0000-0000-0000484FDF79","Message-Id":"<9e98f74834af349564b71bc8443bdad55d6e37c6.1505934128.git.naveen.n.rao@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220128","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, Masami Hiramatsu ,\n\tKamalesh Babulal ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"1. This is only used in kprobes.c, so make it static.\n2. Remove the un-necessary (ret == 0) comparison in the else clause.\n\nReviewed-by: Masami Hiramatsu \nReviewed-by: Kamalesh Babulal \nSigned-off-by: Naveen N. Rao \n---\n arch/powerpc/kernel/kprobes.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c\nindex 367494dc67d9..c2a6ab38a67f 100644\n--- a/arch/powerpc/kernel/kprobes.c\n+++ b/arch/powerpc/kernel/kprobes.c\n@@ -239,7 +239,7 @@ void arch_prepare_kretprobe(struct kretprobe_instance *ri, struct pt_regs *regs)\n }\n NOKPROBE_SYMBOL(arch_prepare_kretprobe);\n \n-int try_to_emulate(struct kprobe *p, struct pt_regs *regs)\n+static int try_to_emulate(struct kprobe *p, struct pt_regs *regs)\n {\n \tint ret;\n \tunsigned int insn = *p->ainsn.insn;\n@@ -261,7 +261,7 @@ int try_to_emulate(struct kprobe *p, struct pt_regs *regs)\n \t\t */\n \t\tprintk(\"Can't step on instruction %x\\n\", insn);\n \t\tBUG();\n-\t} else if (ret == 0)\n+\t} else\n \t\t/* This instruction can't be boosted */\n \t\tp->ainsn.boostable = -1;\n \n","prefixes":["v2","1/6"]}