{"id":817388,"url":"http://patchwork.ozlabs.org/api/patches/817388/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170922083855.102341-2-borntraeger@de.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170922083855.102341-2-borntraeger@de.ibm.com>","list_archive_url":null,"date":"2017-09-22T08:38:53","name":"[PATCH/RFC,1/3] s390x/ais: disable ais facility as it is broken","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b6a2cc9c70bf338c79891dd3ec1316dabcb3d755","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/?format=json","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170922083855.102341-2-borntraeger@de.ibm.com/mbox/","series":[{"id":4570,"url":"http://patchwork.ozlabs.org/api/series/4570/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4570","date":"2017-09-22T08:38:54","name":"ais fixups for 2.11","version":1,"mbox":"http://patchwork.ozlabs.org/series/4570/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817388/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817388/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz6Q30vrRz9sBd\n\tfor ;\n\tFri, 22 Sep 2017 18:40:59 +1000 (AEST)","from localhost ([::1]:57360 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvJW5-0006TJ-7B\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 04:40:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51352)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvJUM-0005TA-Iu\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 04:39:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvJUJ-0003uX-Ff\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 04:39:10 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51236)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvJUJ-0003tl-6W\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 04:39:07 -0400","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8M8cwID093334\n\tfor ; Fri, 22 Sep 2017 04:39:02 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d4xnn1k9e-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 22 Sep 2017 04:39:02 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 22 Sep 2017 09:38:59 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 09:38:56 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8M8cuZF12452092; Fri, 22 Sep 2017 08:38:56 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CDD1342042;\n\tFri, 22 Sep 2017 09:35:04 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id BC75742041;\n\tFri, 22 Sep 2017 09:35:04 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tFri, 22 Sep 2017 09:35:04 +0100 (BST)","by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 25651)\n\tid D846A20F62D; Fri, 22 Sep 2017 10:38:55 +0200 (CEST)"],"From":"Christian Borntraeger ","To":"Cornelia Huck ","Date":"Fri, 22 Sep 2017 10:38:53 +0200","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20170922083855.102341-1-borntraeger@de.ibm.com>","References":"<20170922083855.102341-1-borntraeger@de.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17092208-0016-0000-0000-000004EF3F67","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092208-0017-0000-0000-000028297FCA","Message-Id":"<20170922083855.102341-2-borntraeger@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220120","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"[Qemu-devel] [PATCH/RFC 1/3] s390x/ais: disable ais facility as it\n\tis broken","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Halil Pasic ,\n\tYi Min Zhao ,\n\tDavid Hildenbrand ,\n\tqemu-devel , Alexander Graf ,\n\tChristian Borntraeger ,\n\t\"Jason J . Herne\" ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The migration interface for ais was introduced with kernel 4.13\nbut the capability itself had been active since 4.12. As migration\nsupport is considered necessary lets disable ais in the 2.10\nstable version. A proper fix and re-enablement will be done\nfor qemu 2.11.\n\nSigned-off-by: Christian Borntraeger \nReviewed-by: Cornelia Huck \n---\n target/s390x/kvm.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c\nindex 720cb1d..ebb75ca 100644\n--- a/target/s390x/kvm.c\n+++ b/target/s390x/kvm.c\n@@ -311,8 +311,13 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n }\n }\n \n- /* Try to enable AIS facility */\n- kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0);\n+ /*\n+ * The migration interface for ais was introduced with kernel 4.13\n+ * but the capability itself had been active since 4.12. As migration\n+ * support is considered necessary let's disable ais in the 2.10\n+ * machine.\n+ */\n+ /* kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0); */\n \n qemu_mutex_init(&qemu_sigp_mutex);\n \n","prefixes":["PATCH/RFC","1/3"]}