{"id":817313,"url":"http://patchwork.ozlabs.org/api/patches/817313/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1506052009-8285-5-git-send-email-yamada.masahiro@socionext.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506052009-8285-5-git-send-email-yamada.masahiro@socionext.com>","list_archive_url":null,"date":"2017-09-22T03:46:41","name":"[v2,04/12] mtd: nand: denali: squash denali_enable_dma() helper into caller","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e9b7173406ac4dbc480f227400651df94a341004","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/?format=json","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"delegate":{"id":58324,"url":"http://patchwork.ozlabs.org/api/users/58324/?format=json","username":"bbrezillon","first_name":"Boris","last_name":"Brezillon","email":"boris.brezillon@free-electrons.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1506052009-8285-5-git-send-email-yamada.masahiro@socionext.com/mbox/","series":[{"id":4537,"url":"http://patchwork.ozlabs.org/api/series/4537/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4537","date":"2017-09-22T03:46:37","name":"mtd: nand: denali: more clean-ups","version":2,"mbox":"http://patchwork.ozlabs.org/series/4537/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817313/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817313/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"h7AQHUgI\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"vBp1cnQ+\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyzzf1yBQz9s5L\n\tfor ;\n\tFri, 22 Sep 2017 13:51:10 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvEzU-0007gf-Lg; Fri, 22 Sep 2017 03:51:00 +0000","from conuserg-09.nifty.com ([210.131.2.76])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvEwN-0004Fh-KM\n\tfor linux-mtd@lists.infradead.org; Fri, 22 Sep 2017 03:47:57 +0000","from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-09.nifty.com with ESMTP id v8M3kwAN029389;\n\tFri, 22 Sep 2017 12:47:02 +0900"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=skj5bMo1brTN6WApJX8bTdiwdLZI0Whyj/MTyfXUNkc=;\n\tb=h7AQHUgIht2rzZc3lxFF8AdVcm\n\tSAY/bYq2+LBWxO4GhnuZmekuSKrpkg3ny3UOajOWPklsZBnZjw0/NlSK+gICF3aAFDIKKfR7PFJ3j\n\tdQEIT++A3huVUFUR3PZQ77bHNL7sAtGk2TiXGuEWLXb8IGkFHk5XYKGRCsNmTiM14HdOEJYl9HprA\n\t28XAyLl/bL8aEiTWV3VD0+chgveFWFMDQSwbtkcuToAJTUABMc+nWBNw2eY0+Bow0i3fUyMl0tauL\n\tIjuYN/oJrQJLhKhNTxu1RB1ME8NDfPc6DtulA9VPUX+4cWGUu/CpvcZJruGp5DmFMX5or3mNHkiEY\n\tK4gMlYow==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1506052023;\n\tbh=ZsdAJUIqTO4KvPRvFWjKzBnNDptNNDtvB0GG9itOgS4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vBp1cnQ+iWDOKqYY7s9ZsRHh6mW27je3By78zMfOOIKkkR5cedu2njXK+1X+USTIL\n\teL/leQcw50ImY8wZsckuib44a23qilXhkzjKE7aardjk5P2TDuUmK2K+9a0bG7zswA\n\tGw/jyNJe5LRuIOkDY5RVD98rCo+xTF8VG/NDwnCW9cXig7M3Xji0KpMYdOq4sPnIK8\n\t5qIexWsTU3Dzz4bhhuT2lLwj12/RMZfehMKZITmgqd2Sq/YQKWZBWB9CzH9gVen2Gf\n\tmBNv/jV9tGP/Dn8smMv+3tMznpaMDnPBMnOplHTeFsNPKUqmbc0LcSjZq+kgs9ysox\n\t47ALGfkzxyWOw=="],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conuserg-09.nifty.com v8M3kwAN029389","X-Nifty-SrcIP":"[153.142.97.92]","From":"Masahiro Yamada ","To":"linux-mtd@lists.infradead.org","Subject":"[PATCH v2 04/12] mtd: nand: denali: squash denali_enable_dma()\n\thelper into caller","Date":"Fri, 22 Sep 2017 12:46:41 +0900","Message-Id":"<1506052009-8285-5-git-send-email-yamada.masahiro@socionext.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506052009-8285-1-git-send-email-yamada.masahiro@socionext.com>","References":"<1506052009-8285-1-git-send-email-yamada.masahiro@socionext.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_204748_331156_4FF06656 ","X-CRM114-Status":"UNSURE ( 9.74 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.2 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tMarek Vasut ,\n\tRichard Weinberger , linux-kernel@vger.kernel.org,\n\tMasahiro Yamada , \n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"This helper just sets/clears a flag of DMA_ENABLE register (with\nregister read-back, I do not know why it is necessary).\n\nMove the register write code to the caller, and remove the helper.\nIt works for me without the register read-back.\n\nSigned-off-by: Masahiro Yamada \n---\n\nChanges in v2: None\n\n drivers/mtd/nand/denali.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c\nindex 4daeb7f..e7b25de 100644\n--- a/drivers/mtd/nand/denali.c\n+++ b/drivers/mtd/nand/denali.c\n@@ -465,13 +465,6 @@ static int denali_sw_ecc_fixup(struct mtd_info *mtd,\n \treturn max_bitflips;\n }\n \n-/* programs the controller to either enable/disable DMA transfers */\n-static void denali_enable_dma(struct denali_nand_info *denali, bool en)\n-{\n-\tiowrite32(en ? DMA_ENABLE__FLAG : 0, denali->reg + DMA_ENABLE);\n-\tioread32(denali->reg + DMA_ENABLE);\n-}\n-\n static void denali_setup_dma64(struct denali_nand_info *denali,\n \t\t\t dma_addr_t dma_addr, int page, int write)\n {\n@@ -619,7 +612,7 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,\n \t\tecc_err_mask = INTR__ECC_ERR;\n \t}\n \n-\tdenali_enable_dma(denali, true);\n+\tiowrite32(DMA_ENABLE__FLAG, denali->reg + DMA_ENABLE);\n \n \tdenali_reset_irq(denali);\n \tdenali_setup_dma(denali, dma_addr, page, write);\n@@ -631,7 +624,8 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,\n \telse if (irq_status & ecc_err_mask)\n \t\tret = -EBADMSG;\n \n-\tdenali_enable_dma(denali, false);\n+\tiowrite32(0, denali->reg + DMA_ENABLE);\n+\n \tdma_unmap_single(denali->dev, dma_addr, size, dir);\n \n \tif (irq_status & INTR__ERASED_PAGE)\n","prefixes":["v2","04/12"]}