{"id":817307,"url":"http://patchwork.ozlabs.org/api/patches/817307/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1506052009-8285-10-git-send-email-yamada.masahiro@socionext.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506052009-8285-10-git-send-email-yamada.masahiro@socionext.com>","list_archive_url":null,"date":"2017-09-22T03:46:46","name":"[v2,09/12] mtd: nand: denali: use upper/lower_32_bits() macro for clean-up","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7d95aba772d3f851d8617bb2622eb0a08b7d237f","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/?format=json","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"delegate":{"id":58324,"url":"http://patchwork.ozlabs.org/api/users/58324/?format=json","username":"bbrezillon","first_name":"Boris","last_name":"Brezillon","email":"boris.brezillon@free-electrons.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1506052009-8285-10-git-send-email-yamada.masahiro@socionext.com/mbox/","series":[{"id":4537,"url":"http://patchwork.ozlabs.org/api/series/4537/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4537","date":"2017-09-22T03:46:37","name":"mtd: nand: denali: more clean-ups","version":2,"mbox":"http://patchwork.ozlabs.org/series/4537/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817307/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817307/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"O4i1clAs\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"gK8ttR9e\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyzwy5mxlz9t3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 13:48:50 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvExB-0004fB-0b; Fri, 22 Sep 2017 03:48:37 +0000","from conuserg-09.nifty.com ([210.131.2.76])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvEwJ-0004Fa-3K\n\tfor linux-mtd@lists.infradead.org; Fri, 22 Sep 2017 03:47:45 +0000","from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-09.nifty.com with ESMTP id v8M3kwAS029389;\n\tFri, 22 Sep 2017 12:47:06 +0900"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=6s2Y3HjJQPnJrFK+WVE1QYk4raUPUqyYFpcrOtGmMKU=;\n\tb=O4i1clAsgU7fig7idhAyIjzfIq\n\tx6bUNGSvwmJDXl4W3bSl3FNb3dBEWRlWtGl+B8TS+zbWtZ3xtqNJI4PEHx0vQ/e+1sC+D58kbsVm1\n\tRfoM4Ot6fxQud0jqRQ4Q4lw/zWtyXqdEEX3EryOU013sB+s8oj6ayeTW7DqDqelcbEabE632fEVBz\n\txNH+WKdeYvqz/bFRai6YWG8rXITuq9sNI9CgaDVrsvCr9WrvuEuaRYTPC9YzX163wRek5SgywLd2K\n\tlpr3oEBMO2RFtkWM8DiJ5TgJTmF3iJ99Nty/mcLJp/L/A7rdl5nb0oSCn3QGUEUGYMnHpWqgNTmdd\n\tWqFUwfOg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1506052027;\n\tbh=wmbV0VGRYDYqlpq9k7TR5Yr0qy0FTTPJUWitri53kgY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gK8ttR9egls/zULl3y2X/bVDtiymTRV/4SVTAZ6r9XhYPGeqvEBGPnpzvl49GFuyi\n\tBuUdxKxXGRxNTdKRSVuWQqH+MzkfaqHDkdJmme63nruKi3r1jqRJyWzUImAyFjrdxw\n\tl0x5SfIqkxvvk7tvxyzIg60jQ5Mx74FX439dXnmyvpazVZ0eRC4HkcbySoqHx1jwGd\n\tk9zbtUVaQguYuQz3nF+Wz7oXjsuBzryBjVJGmqCZjAeyG8oQSpj5a3+4NF+7f67YU7\n\tNZGcMTQ60+XsBmgO7oP/jCdzedIv0vyMHncJU6gK35kSLsU6vvotIS9pMnr16/Wc2Q\n\tvVch/QI7mNEyg=="],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conuserg-09.nifty.com v8M3kwAS029389","X-Nifty-SrcIP":"[153.142.97.92]","From":"Masahiro Yamada <yamada.masahiro@socionext.com>","To":"linux-mtd@lists.infradead.org","Subject":"[PATCH v2 09/12] mtd: nand: denali: use upper/lower_32_bits() macro\n\tfor clean-up","Date":"Fri, 22 Sep 2017 12:46:46 +0900","Message-Id":"<1506052009-8285-10-git-send-email-yamada.masahiro@socionext.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506052009-8285-1-git-send-email-yamada.masahiro@socionext.com>","References":"<1506052009-8285-1-git-send-email-yamada.masahiro@socionext.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_204743_466869_F61B486B ","X-CRM114-Status":"UNSURE (   9.72  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.2 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.2 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-mtd/>","List-Post":"<mailto:linux-mtd@lists.infradead.org>","List-Help":"<mailto:linux-mtd-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>","Cc":"Boris Brezillon <boris.brezillon@free-electrons.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tRichard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>, \n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"I used (uint64_t) cast to avoid \"right shift count >= width of type\"\nwarning.  <linux/kernel.h> provides nice helpers to cater to it.\nThe code will be cleaner, and easier to understand.\n\nSigned-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>\n---\n\nChanges in v2:\n  - Newly added\n\n drivers/mtd/nand/denali.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c\nindex 02ce310..e567ad9 100644\n--- a/drivers/mtd/nand/denali.c\n+++ b/drivers/mtd/nand/denali.c\n@@ -469,10 +469,10 @@ static void denali_setup_dma64(struct denali_nand_info *denali,\n \t\t\t  0x01002000 | (64 << 16) | (write << 8) | page_count);\n \n \t/* 2. set memory low address */\n-\tdenali_host_write(denali, mode, dma_addr);\n+\tdenali_host_write(denali, mode, lower_32_bits(dma_addr));\n \n \t/* 3. set memory high address */\n-\tdenali_host_write(denali, mode, (uint64_t)dma_addr >> 32);\n+\tdenali_host_write(denali, mode, upper_32_bits(dma_addr));\n }\n \n static void denali_setup_dma32(struct denali_nand_info *denali,\n","prefixes":["v2","09/12"]}