{"id":817199,"url":"http://patchwork.ozlabs.org/api/patches/817199/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/1506033838-2078-4-git-send-email-eajames@linux.vnet.ibm.com/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506033838-2078-4-git-send-email-eajames@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-21T22:43:58","name":"[linux,dev-4.10,3/3] drivers/hwmon/occ: Remove repeated ops for OCC command in progress","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"4f06b8d8c17af4520b89fa388406464be615ff44","submitter":{"id":70876,"url":"http://patchwork.ozlabs.org/api/people/70876/?format=json","name":"Eddie James","email":"eajames@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/1506033838-2078-4-git-send-email-eajames@linux.vnet.ibm.com/mbox/","series":[{"id":4493,"url":"http://patchwork.ozlabs.org/api/series/4493/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/list/?series=4493","date":"2017-09-21T22:43:57","name":"drivers/fsi: Fixup client remove functions","version":1,"mbox":"http://patchwork.ozlabs.org/series/4493/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817199/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817199/checks/","tags":{},"related":[],"headers":{"Return-Path":"<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xysD65L4Wz9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 08:46:30 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xysD64QY6zDr4N\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 08:46:30 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xys9g4lbvzDqT0\n\tfor <openbmc@lists.ozlabs.org>; Fri, 22 Sep 2017 08:44:23 +1000 (AEST)","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8LMiI7D138946\n\tfor <openbmc@lists.ozlabs.org>; Thu, 21 Sep 2017 18:44:21 -0400","from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d4m70xh32-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <openbmc@lists.ozlabs.org>; Thu, 21 Sep 2017 18:44:19 -0400","from localhost\n\tby e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <openbmc@lists.ozlabs.org> from <eajames@linux.vnet.ibm.com>;\n\tThu, 21 Sep 2017 18:44:08 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 21 Sep 2017 18:44:05 -0400","from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com\n\t[9.57.199.106])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8LMi5tg29229186; Thu, 21 Sep 2017 22:44:05 GMT","from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A8DDF2803A;\n\tThu, 21 Sep 2017 18:43:58 -0400 (EDT)","from oc3016140333.ibm.com (unknown [9.41.174.252])\n\tby b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP id 17ABE2803E;\n\tThu, 21 Sep 2017 18:43:58 -0400 (EDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=eajames@linux.vnet.ibm.com; receiver=<UNKNOWN>)","From":"Eddie James <eajames@linux.vnet.ibm.com>","To":"openbmc@lists.ozlabs.org","Subject":"[PATCH linux dev-4.10 3/3] drivers/hwmon/occ: Remove repeated ops\n\tfor OCC command in progress","Date":"Thu, 21 Sep 2017 17:43:58 -0500","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1506033838-2078-1-git-send-email-eajames@linux.vnet.ibm.com>","References":"<1506033838-2078-1-git-send-email-eajames@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17092122-0052-0000-0000-0000026561FB","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007775; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00920429; UDB=6.00462502;\n\tIPR=6.00700651; \n\tBA=6.00005601; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017240;\n\tXFM=3.00000015; UTC=2017-09-21 22:44:07","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092122-0053-0000-0000-000052158F6E","Message-Id":"<1506033838-2078-4-git-send-email-eajames@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-21_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709210305","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC <openbmc.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/openbmc/>","List-Post":"<mailto:openbmc@lists.ozlabs.org>","List-Help":"<mailto:openbmc-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>","Cc":"andrew@aj.id.au, \"Edward A. James\" <eajames@us.ibm.com>","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"},"content":"From: \"Edward A. James\" <eajames@us.ibm.com>\n\nThis is now handled in the occ driver.\n\nSigned-off-by: Edward A. James <eajames@us.ibm.com>\n---\n drivers/hwmon/occ/p9_sbe.c | 14 +-------------\n 1 file changed, 1 insertion(+), 13 deletions(-)","diff":"diff --git a/drivers/hwmon/occ/p9_sbe.c b/drivers/hwmon/occ/p9_sbe.c\nindex 2d50a94..c7e0d9c 100644\n--- a/drivers/hwmon/occ/p9_sbe.c\n+++ b/drivers/hwmon/occ/p9_sbe.c\n@@ -26,14 +26,10 @@ struct p9_sbe_occ {\n static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd)\n {\n \tint rc, error;\n-\tunsigned long start;\n \tstruct occ_client *client;\n \tstruct occ_response *resp = &occ->resp;\n \tstruct p9_sbe_occ *p9_sbe_occ = to_p9_sbe_occ(occ);\n \n-\tstart = jiffies;\n-\n-retry:\n \tclient = occ_drv_open(p9_sbe_occ->sbe, 0);\n \tif (!client) {\n \t\trc = -ENODEV;\n@@ -52,15 +48,7 @@ static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd)\n \n \tswitch (resp->return_status) {\n \tcase RESP_RETURN_CMD_IN_PRG:\n-\t\tif (time_after(jiffies,\n-\t\t\t       start + msecs_to_jiffies(OCC_TIMEOUT_MS)))\n-\t\t\trc = -EALREADY;\n-\t\telse {\n-\t\t\tset_current_state(TASK_INTERRUPTIBLE);\n-\t\t\tschedule_timeout(msecs_to_jiffies(OCC_CMD_IN_PRG_MS));\n-\n-\t\t\tgoto retry;\n-\t\t}\n+\t\trc = -ETIMEDOUT;\n \t\tbreak;\n \tcase RESP_RETURN_SUCCESS:\n \t\tocc_reset_error(occ);\n","prefixes":["linux","dev-4.10","3/3"]}