{"id":817134,"url":"http://patchwork.ozlabs.org/api/patches/817134/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-4-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-4-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:24","name":"[03/64] drivers: net: pcnet32: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"f34337f7e8b7e054a19efc3454f33463d5b96c47","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-4-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817134/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817134/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IyLJWcAz\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykP64s2Lz9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:38:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751846AbdIURGD (ORCPT );\n\tThu, 21 Sep 2017 13:06:03 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:35337 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751787AbdIURGB (ORCPT\n\t); Thu, 21 Sep 2017 13:06:01 -0400","by mail-pg0-f65.google.com with SMTP id j16so3743214pga.2;\n\tThu, 21 Sep 2017 10:06:00 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.05.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:05:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=mf5GUXwd056ObFNWRko2OsgEcApKF0212LP95f5HCg0=;\n\tb=IyLJWcAz6NRnICW2mRnWB7cr1qHhkOqQBa+7+Tr76nYyI5SjM0gKQeaip7ijZcuzG5\n\thwoxmhUc2rufKWiMZr2DB5vBLOuNm0YRBW5pDfjo7F7kd6tyQkacXlTjoeXqBsy7LR8w\n\ticTIwv5g/ElYQhfRiwmTcVsrVqNatOE0P6xz0WV5qWC6d4wrwZkkaEuL9GXzbskHYX1V\n\tHZMBqSNAH0NZdk5m3+6+a8e+1QStoZK3kjF6madxBqoxxXiveHTFli1fgSHHcdwCg+e6\n\toXsSaBN3KE5TjL8eAore7DEnVPSSXZnBVrqRUvumrZ0/XllsOcZzetSmjBooEUbOSu2d\n\tdlGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=mf5GUXwd056ObFNWRko2OsgEcApKF0212LP95f5HCg0=;\n\tb=kLtpefb70yYTIHZRiO2Q6eq7eYg+CFNc+jXrHjAKeWViLfuX9asnz/ediIXJJ1Hlez\n\t5zMJ2K0DnwV9OCqCb1HluSAwsOKVuST52w3IvPIUIIep1T2Tmp7SvlrC9eq0kikv4+sF\n\tGf66HStrDI2TZinyQszI6z3wp7T2/QqzO8/fIYClb7T4//WWd3673don43Kusk5XKBQ4\n\tmRk+Gq1JxkGUese4t2tvJRoRilK1hFjpovq6oWF7UglVf8LHaQAJHFgT11pooUUL61g/\n\t3LbKbVdn9U+1sKHjfjTRoqabYpiflka4UZAk57a3/vJB6pHEvT+dozPnz85zkd1Qt70a\n\tbVKA==","X-Gm-Message-State":"AHPjjUjCLcf+NUDL3WDqooDM0MLFoDOQ4NbB6xgmN73JXA3R2wV0RLQW\n\tUuG/nB2TasRsEm0nhO5b/fMf+60BsGY=","X-Google-Smtp-Source":"AOwi7QDohUevIWJVQUQWqGr4H+yDRT0HzJLmLtxwtiEqqeDMw58eMZXdjSISxOJj59xPmyKj0HlPJg==","X-Received":"by 10.84.234.140 with SMTP id n12mr6241533plk.209.1506013560239; \n\tThu, 21 Sep 2017 10:06:00 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 03/64] drivers: net: pcnet32: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:24 +0530","Message-Id":"<1506013525-29291-4-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/amd/pcnet32.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c\nindex 7f60d17..e461536 100644\n--- a/drivers/net/ethernet/amd/pcnet32.c\n+++ b/drivers/net/ethernet/amd/pcnet32.c\n@@ -1970,9 +1970,8 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev)\n \t\t\tlp->options |= PCNET32_PORT_MII;\n \t}\n \n-\tinit_timer(&lp->watchdog_timer);\n-\tlp->watchdog_timer.data = (unsigned long)dev;\n-\tlp->watchdog_timer.function = (void *)&pcnet32_watchdog;\n+\tsetup_timer(&lp->watchdog_timer, (void *)&pcnet32_watchdog,\n+\t\t (unsigned long)dev);\n \n \t/* The PCNET32-specific entries in the device structure. */\n \tdev->netdev_ops = &pcnet32_netdev_ops;\n","prefixes":["03/64"]}