{"id":817130,"url":"http://patchwork.ozlabs.org/api/patches/817130/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-11-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-11-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:31","name":"[10/64] drivers: net: appletalk: cops: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"cb10d42c4b2a63a5f093f27054ca877a4cfeee61","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-11-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817130/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817130/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fFM4DQUF\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykM601d0z9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:37:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752069AbdIURGu (ORCPT );\n\tThu, 21 Sep 2017 13:06:50 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:35908 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752057AbdIURGp (ORCPT\n\t); Thu, 21 Sep 2017 13:06:45 -0400","by mail-pg0-f66.google.com with SMTP id d8so3742220pgt.3;\n\tThu, 21 Sep 2017 10:06:45 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.06.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:06:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=/GUhZqrRPleaN3Dg2PjafdzOKK0tvxz7vKHby9kUYRk=;\n\tb=fFM4DQUFtiD7+A/y6bEf7eZCGQxzJbYgcMQ6t2VCh/jJQXq51OaP7tAGyU+LI+J++4\n\tHyELKj/752VlsIpcCRxgVDQc8LWjTznMp5IDL0gszQeh/rMreaSHPulfjgUZsxbuIRnV\n\tdgXptv1wapNJFsgHdBSTsbImjlDvnJnpSuUfr/IpnmiM4ZQLnLyxPshjKkeEEHDVAnO3\n\twTN11BP5z/mDyOM+x3PpQCFMl99r/9gDz/U1RYSC4gdO0vs1l/QwrJzwu5OEZ4fFTuzq\n\t+Dy//hwFKCfJDAzj3pGMqTWVaZD8bj5yEbndIxLDL1j/E4ty01KLQoDVBhs5/YmCDWKk\n\tkGrA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=/GUhZqrRPleaN3Dg2PjafdzOKK0tvxz7vKHby9kUYRk=;\n\tb=K2qD/13FmKvh2vrsZ4wiNv4eJAz5ayafJBRs4yjUyN7XPXf6V4G+eqfdAkrEsj2w/y\n\tXaWmnJyNvIfPiwpYGRAJOussMLY7z5Hrw2Dg+HffdF1VxyPeKNi82dAV/b1x5BkI+oiV\n\tdT6uEx4156MDB9WNSjBsVvL0TGD5r+3zueJxcC5WGHuyBpS7U+AKcW1dlJ9uwX7MGnVI\n\tmqWwiFsbk0IflGXeKn8uL4yk68Pwks9VrNKFkUShr7/1TQY8RmJGNGyAtvkMqqIjLgD8\n\tebvYdF7Dlo4mwSFJ9IVz/lPLjOSaFQkUVyOHAbqTjWUW6pFr0Jx4+Y0woqYZs4HdGylV\n\tidhQ==","X-Gm-Message-State":"AHPjjUjq6JFjT1jbqdRG1UIbzRZWY6Kgib+NcNcwDlEztki4VO8ycYL/\n\t85S7r3Za+NfsPb+Wrf5SRosUvaixaVQ=","X-Google-Smtp-Source":"AOwi7QDxnLrCacpc/X5JiPedEzeqHb2ZeTPfpAfZG6mmjtsfp30jra4gaselb6lkt48ovXYK3lzxlg==","X-Received":"by 10.159.194.137 with SMTP id y9mr6247813pln.77.1506013605008; \n\tThu, 21 Sep 2017 10:06:45 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 10/64] drivers: net: appletalk: cops: use setup_timer()\n\thelper.","Date":"Thu, 21 Sep 2017 22:34:31 +0530","Message-Id":"<1506013525-29291-11-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/appletalk/cops.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/appletalk/cops.c b/drivers/net/appletalk/cops.c\nindex 486e1e6..caf0428 100644\n--- a/drivers/net/appletalk/cops.c\n+++ b/drivers/net/appletalk/cops.c\n@@ -424,9 +424,7 @@ static int cops_open(struct net_device *dev)\n \t\t */\n \t\tif(lp->board==TANGENT)\t/* Poll 20 times per second */\n \t\t{\n-\t\t init_timer(&cops_timer);\n-\t\t cops_timer.function = cops_poll;\n-\t\t cops_timer.data \t= (unsigned long)dev;\n+\t\t setup_timer(&cops_timer, cops_poll, (unsigned long)dev);\n \t\t cops_timer.expires \t= jiffies + HZ/20;\n \t\t add_timer(&cops_timer);\n \t\t} \n","prefixes":["10/64"]}